You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/22 10:13:03 UTC

[GitHub] [superset] geido opened a new pull request #13270: test: FormLabel dedicated directory and tests

geido opened a new pull request #13270:
URL: https://github.com/apache/superset/pull/13270


   ### SUMMARY
   This PR only includes tests for the FormLabel component but no storybook. The FormLabel is a React Bootstrap component that we aim to deprecate asap, so the goal of this PR is only to contribute to the stability of the system as it currently stands with no additional investment. 
   
   This PR also moves the FormLabel component to a dedicated directory.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] geido closed pull request #13270: test: FormLabel dedicated directory and tests

Posted by GitBox <gi...@apache.org>.
geido closed pull request #13270:
URL: https://github.com/apache/superset/pull/13270


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] geido commented on pull request #13270: test: FormLabel dedicated directory and tests

Posted by GitBox <gi...@apache.org>.
geido commented on pull request #13270:
URL: https://github.com/apache/superset/pull/13270#issuecomment-783260947


   @junlincc @rusackas 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] junlincc commented on pull request #13270: test: FormLabel dedicated directory and tests

Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #13270:
URL: https://github.com/apache/superset/pull/13270#issuecomment-783864897


   Thanks for the PR! this project is progressing so nicely, thanks to you all @geido @michael-s-molina @yardz 🙏
   
   ![image](https://user-images.githubusercontent.com/67837651/108801529-d0709180-754a-11eb-8af4-1f73a24700c3.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov-io commented on pull request #13270: test: FormLabel dedicated directory and tests

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #13270:
URL: https://github.com/apache/superset/pull/13270#issuecomment-783293858


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13270?src=pr&el=h1) Report
   > Merging [#13270](https://codecov.io/gh/apache/superset/pull/13270?src=pr&el=desc) (55c1cf3) into [master](https://codecov.io/gh/apache/superset/commit/9b5e66b728190e0dde5e6ddfb0f018cbdd8e5283?el=desc) (9b5e66b) will **decrease** coverage by `20.46%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13270/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13270?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master   #13270       +/-   ##
   ===========================================
   - Coverage   72.29%   51.82%   -20.47%     
   ===========================================
     Files         864      473      -391     
     Lines       44883    15526    -29357     
     Branches     5403     3972     -1431     
   ===========================================
   - Hits        32450     8047    -24403     
   + Misses      12224     7479     -4745     
   + Partials      209        0      -209     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `51.82% <100.00%> (?)` | |
   | javascript | `?` | |
   | python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13270?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...perset-frontend/src/components/FormLabel/index.tsx](https://codecov.io/gh/apache/superset/pull/13270/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRm9ybUxhYmVsL2luZGV4LnRzeA==) | `100.00% <100.00%> (ø)` | |
   | [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/13270/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/13270/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...tend/src/dashboard/util/getDirectPathToTabIndex.js](https://codecov.io/gh/apache/superset/pull/13270/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERpcmVjdFBhdGhUb1RhYkluZGV4Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/13270/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...tersConfigModal/Footer/CancelConfirmationAlert.tsx](https://codecov.io/gh/apache/superset/pull/13270/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0Zvb3Rlci9DYW5jZWxDb25maXJtYXRpb25BbGVydC50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...ConfigModal/FiltersConfigForm/FilterScope/state.ts](https://codecov.io/gh/apache/superset/pull/13270/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL3N0YXRlLnRz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...odal/FiltersConfigForm/FilterScope/ScopingTree.tsx](https://codecov.io/gh/apache/superset/pull/13270/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL1Njb3BpbmdUcmVlLnRzeA==) | `6.25% <0.00%> (-93.75%)` | :arrow_down: |
   | [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/superset/pull/13270/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
   | [...d/src/dashboard/util/updateComponentParentsList.js](https://codecov.io/gh/apache/superset/pull/13270/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3VwZGF0ZUNvbXBvbmVudFBhcmVudHNMaXN0Lmpz) | `0.00% <0.00%> (-87.50%)` | :arrow_down: |
   | ... and [780 more](https://codecov.io/gh/apache/superset/pull/13270/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13270?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13270?src=pr&el=footer). Last update [9b5e66b...55c1cf3](https://codecov.io/gh/apache/superset/pull/13270?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] geido closed pull request #13270: test: FormLabel dedicated directory and tests

Posted by GitBox <gi...@apache.org>.
geido closed pull request #13270:
URL: https://github.com/apache/superset/pull/13270


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] rusackas merged pull request #13270: test: FormLabel dedicated directory and tests

Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #13270:
URL: https://github.com/apache/superset/pull/13270


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov-io edited a comment on pull request #13270: test: FormLabel dedicated directory and tests

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13270:
URL: https://github.com/apache/superset/pull/13270#issuecomment-783293858


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13270?src=pr&el=h1) Report
   > Merging [#13270](https://codecov.io/gh/apache/superset/pull/13270?src=pr&el=desc) (55c1cf3) into [master](https://codecov.io/gh/apache/superset/commit/9b5e66b728190e0dde5e6ddfb0f018cbdd8e5283?el=desc) (9b5e66b) will **decrease** coverage by `14.15%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13270/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13270?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master   #13270       +/-   ##
   ===========================================
   - Coverage   72.29%   58.14%   -14.16%     
   ===========================================
     Files         864      478      -386     
     Lines       44883    15980    -28903     
     Branches     5403     4121     -1282     
   ===========================================
   - Hits        32450     9292    -23158     
   + Misses      12224     6688     -5536     
   + Partials      209        0      -209     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `58.14% <100.00%> (?)` | |
   | javascript | `?` | |
   | python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13270?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...perset-frontend/src/components/FormLabel/index.tsx](https://codecov.io/gh/apache/superset/pull/13270/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRm9ybUxhYmVsL2luZGV4LnRzeA==) | `100.00% <100.00%> (ø)` | |
   | [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/13270/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/13270/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/13270/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...tersConfigModal/Footer/CancelConfirmationAlert.tsx](https://codecov.io/gh/apache/superset/pull/13270/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0Zvb3Rlci9DYW5jZWxDb25maXJtYXRpb25BbGVydC50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...ConfigModal/FiltersConfigForm/FilterScope/state.ts](https://codecov.io/gh/apache/superset/pull/13270/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL3N0YXRlLnRz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...odal/FiltersConfigForm/FilterScope/ScopingTree.tsx](https://codecov.io/gh/apache/superset/pull/13270/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL1Njb3BpbmdUcmVlLnRzeA==) | `6.25% <0.00%> (-93.75%)` | :arrow_down: |
   | [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/superset/pull/13270/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
   | [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/superset/pull/13270/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
   | [superset-frontend/src/components/IconTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13270/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvblRvb2x0aXAudHN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
   | ... and [778 more](https://codecov.io/gh/apache/superset/pull/13270/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13270?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13270?src=pr&el=footer). Last update [9b5e66b...55c1cf3](https://codecov.io/gh/apache/superset/pull/13270?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] michael-s-molina commented on a change in pull request #13270: test: FormLabel dedicated directory and tests

Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on a change in pull request #13270:
URL: https://github.com/apache/superset/pull/13270#discussion_r581114193



##########
File path: superset-frontend/src/components/FormLabel/index.tsx
##########
@@ -36,7 +36,7 @@ export default function FormLabel({
       <ControlLabel htmlFor={htmlFor}>
         {children}
         {required && (
-          <span className="text-danger m-l-4">
+          <span className="text-danger m-l-4" data-test-id="span-required">

Review comment:
       We can remove this ID if we access the element by `parentNode`

##########
File path: superset-frontend/src/components/FormLabel/FormLabel.test.tsx
##########
@@ -0,0 +1,53 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import { render, screen } from 'spec/helpers/testing-library';
+import { FormControl } from 'react-bootstrap';
+import FormLabel from './index';
+
+const mockedProps = {
+  children: 'Form label',
+  required: false,
+  htmlFor: 'form-control',
+};
+
+test('should render', () => {
+  const { container } = render(<FormLabel {...mockedProps} />);
+  expect(container).toBeInTheDocument();
+});
+
+test('should render a Label', () => {
+  render(
+    <>
+      <FormLabel {...mockedProps} />
+      <FormControl id="form-control" />
+    </>,
+  );
+  expect(screen.getByLabelText('Form label')).toBeInTheDocument();
+});
+
+test('should be shown as required', () => {
+  const requiredProps = {
+    ...mockedProps,
+    required: true,
+  };
+  render(<FormLabel {...requiredProps} />);
+  expect(screen.getByTestId('span-required')).toBeInTheDocument();

Review comment:
       I think we can replace the ID with getByText and parentNode.
   `expect(screen.getByText('*').parentNode). toBeInTheDocument();`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov-io edited a comment on pull request #13270: test: FormLabel dedicated directory and tests

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13270:
URL: https://github.com/apache/superset/pull/13270#issuecomment-783293858


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13270?src=pr&el=h1) Report
   > Merging [#13270](https://codecov.io/gh/apache/superset/pull/13270?src=pr&el=desc) (44efac3) into [master](https://codecov.io/gh/apache/superset/commit/9b5e66b728190e0dde5e6ddfb0f018cbdd8e5283?el=desc) (9b5e66b) will **decrease** coverage by `10.09%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13270/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13270?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master   #13270       +/-   ##
   ===========================================
   - Coverage   72.29%   62.20%   -10.10%     
   ===========================================
     Files         864      567      -297     
     Lines       44883    20665    -24218     
     Branches     5403     5421       +18     
   ===========================================
   - Hits        32450    12854    -19596     
   + Misses      12224     7602     -4622     
     Partials      209      209               
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `62.20% <ø> (-0.05%)` | :arrow_down: |
   | python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13270?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...perset-frontend/src/components/FormLabel/index.tsx](https://codecov.io/gh/apache/superset/pull/13270/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRm9ybUxhYmVsL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...rontend/src/views/CRUD/dashboard/DashboardCard.tsx](https://codecov.io/gh/apache/superset/pull/13270/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZENhcmQudHN4) | `73.68% <0.00%> (-2.00%)` | :arrow_down: |
   | [...perset-frontend/src/views/CRUD/chart/ChartCard.tsx](https://codecov.io/gh/apache/superset/pull/13270/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRDYXJkLnRzeA==) | `70.27% <0.00%> (-1.96%)` | :arrow_down: |
   | [superset-frontend/src/views/CRUD/types.ts](https://codecov.io/gh/apache/superset/pull/13270/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvdHlwZXMudHM=) | `100.00% <0.00%> (ø)` | |
   | [superset/datasets/commands/update.py](https://codecov.io/gh/apache/superset/pull/13270/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvdXBkYXRlLnB5) | | |
   | [superset/datasets/dao.py](https://codecov.io/gh/apache/superset/pull/13270/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvZGFvLnB5) | | |
   | [superset/databases/dao.py](https://codecov.io/gh/apache/superset/pull/13270/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2Rhby5weQ==) | | |
   | [superset/utils/dashboard\_import\_export.py](https://codecov.io/gh/apache/superset/pull/13270/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2ltcG9ydF9leHBvcnQucHk=) | | |
   | [superset/annotation\_layers/annotations/dao.py](https://codecov.io/gh/apache/superset/pull/13270/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvZGFvLnB5) | | |
   | [superset/db\_engine\_specs/vertica.py](https://codecov.io/gh/apache/superset/pull/13270/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ZlcnRpY2EucHk=) | | |
   | ... and [297 more](https://codecov.io/gh/apache/superset/pull/13270/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13270?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13270?src=pr&el=footer). Last update [9b5e66b...44efac3](https://codecov.io/gh/apache/superset/pull/13270?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org