You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Gabriel Moreira (JIRA)" <ji...@apache.org> on 2011/04/05 16:12:05 UTC

[jira] [Created] (WICKET-3597) WICKET 1.5 RC-3 BUG WITH CONDITIONAL COMMENTS

WICKET 1.5 RC-3 BUG WITH CONDITIONAL COMMENTS
---------------------------------------------

                 Key: WICKET-3597
                 URL: https://issues.apache.org/jira/browse/WICKET-3597
             Project: Wicket
          Issue Type: Bug
          Components: wicket-core
    Affects Versions: 1.5-RC3
         Environment: Windows 7 64b - Chrome 11, Firefox 3.6
            Reporter: Gabriel Moreira


IE Conditional Comments with script block causes malformed HTML on Chrome and Firefox.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (WICKET-3597) Wicket 1.5 RC-3 Bug with conditional comments

Posted by "Gabriel Moreira (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gabriel Moreira updated WICKET-3597:
------------------------------------

    Summary: Wicket 1.5 RC-3 Bug with conditional comments  (was: WICKET 1.5 RC-3 BUG WITH CONDITIONAL COMMENTS)

> Wicket 1.5 RC-3 Bug with conditional comments
> ---------------------------------------------
>
>                 Key: WICKET-3597
>                 URL: https://issues.apache.org/jira/browse/WICKET-3597
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-core
>    Affects Versions: 1.5-RC3
>         Environment: Windows 7 64b - Chrome 11, Firefox 3.6
>            Reporter: Gabriel Moreira
>              Labels: javascript
>         Attachments: Chrome 11 Bug.jpg, Firefox bug.jpg, myproject.rar, screenshot-1.jpg
>
>
> IE Conditional Comments with script block causes malformed HTML on Chrome and Firefox.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (WICKET-3597) Wicket 1.5 RC-3 Bug with conditional comments

Posted by "Martin Grigorov (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13162159#comment-13162159 ] 

Martin Grigorov commented on WICKET-3597:
-----------------------------------------

Use org.apache.wicket.markup.html.IHeaderResponse.renderString(CharSequence) for such needs.
                
> Wicket 1.5 RC-3 Bug with conditional comments
> ---------------------------------------------
>
>                 Key: WICKET-3597
>                 URL: https://issues.apache.org/jira/browse/WICKET-3597
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.5-RC3
>         Environment: Windows 7 64b - Chrome 11, Firefox 3.6
>            Reporter: Gabriel Moreira
>            Assignee: Martin Grigorov
>              Labels: javascript
>             Fix For: 1.5-RC4
>
>         Attachments: Chrome 11 Bug.jpg, Firefox bug.jpg, myproject.rar, screenshot-1.jpg
>
>
> IE Conditional Comments with script block causes malformed HTML on Chrome and Firefox.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (WICKET-3597) Wicket 1.5 RC-3 Bug with conditional comments

Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Grigorov reassigned WICKET-3597:
---------------------------------------

    Assignee: Martin Grigorov

> Wicket 1.5 RC-3 Bug with conditional comments
> ---------------------------------------------
>
>                 Key: WICKET-3597
>                 URL: https://issues.apache.org/jira/browse/WICKET-3597
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-core
>    Affects Versions: 1.5-RC3
>         Environment: Windows 7 64b - Chrome 11, Firefox 3.6
>            Reporter: Gabriel Moreira
>            Assignee: Martin Grigorov
>              Labels: javascript
>         Attachments: Chrome 11 Bug.jpg, Firefox bug.jpg, myproject.rar, screenshot-1.jpg
>
>
> IE Conditional Comments with script block causes malformed HTML on Chrome and Firefox.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (WICKET-3597) WICKET 1.5 RC-3 BUG WITH CONDITIONAL COMMENTS

Posted by "Gabriel Moreira (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gabriel Moreira updated WICKET-3597:
------------------------------------

    Attachment: screenshot-1.jpg

> WICKET 1.5 RC-3 BUG WITH CONDITIONAL COMMENTS
> ---------------------------------------------
>
>                 Key: WICKET-3597
>                 URL: https://issues.apache.org/jira/browse/WICKET-3597
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-core
>    Affects Versions: 1.5-RC3
>         Environment: Windows 7 64b - Chrome 11, Firefox 3.6
>            Reporter: Gabriel Moreira
>              Labels: javascript
>         Attachments: Chrome 11 Bug.jpg, Firefox bug.jpg, myproject.rar, screenshot-1.jpg
>
>
> IE Conditional Comments with script block causes malformed HTML on Chrome and Firefox.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (WICKET-3597) WICKET 1.5 RC-3 BUG WITH CONDITIONAL COMMENTS

Posted by "Gabriel Moreira (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gabriel Moreira updated WICKET-3597:
------------------------------------

    Attachment: Chrome 11 Bug.jpg

> WICKET 1.5 RC-3 BUG WITH CONDITIONAL COMMENTS
> ---------------------------------------------
>
>                 Key: WICKET-3597
>                 URL: https://issues.apache.org/jira/browse/WICKET-3597
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-core
>    Affects Versions: 1.5-RC3
>         Environment: Windows 7 64b - Chrome 11, Firefox 3.6
>            Reporter: Gabriel Moreira
>              Labels: javascript
>         Attachments: Chrome 11 Bug.jpg
>
>
> IE Conditional Comments with script block causes malformed HTML on Chrome and Firefox.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (WICKET-3597) Wicket 1.5 RC-3 Bug with conditional comments

Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Grigorov resolved WICKET-3597.
-------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.5-RC4

Fixed with r1089558.

> Wicket 1.5 RC-3 Bug with conditional comments
> ---------------------------------------------
>
>                 Key: WICKET-3597
>                 URL: https://issues.apache.org/jira/browse/WICKET-3597
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-core
>    Affects Versions: 1.5-RC3
>         Environment: Windows 7 64b - Chrome 11, Firefox 3.6
>            Reporter: Gabriel Moreira
>            Assignee: Martin Grigorov
>              Labels: javascript
>             Fix For: 1.5-RC4
>
>         Attachments: Chrome 11 Bug.jpg, Firefox bug.jpg, myproject.rar, screenshot-1.jpg
>
>
> IE Conditional Comments with script block causes malformed HTML on Chrome and Firefox.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (WICKET-3597) WICKET 1.5 RC-3 BUG WITH CONDITIONAL COMMENTS

Posted by "Gabriel Moreira (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gabriel Moreira updated WICKET-3597:
------------------------------------

    Attachment: Firefox bug.jpg

> WICKET 1.5 RC-3 BUG WITH CONDITIONAL COMMENTS
> ---------------------------------------------
>
>                 Key: WICKET-3597
>                 URL: https://issues.apache.org/jira/browse/WICKET-3597
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-core
>    Affects Versions: 1.5-RC3
>         Environment: Windows 7 64b - Chrome 11, Firefox 3.6
>            Reporter: Gabriel Moreira
>              Labels: javascript
>         Attachments: Chrome 11 Bug.jpg, Firefox bug.jpg, myproject.rar, screenshot-1.jpg
>
>
> IE Conditional Comments with script block causes malformed HTML on Chrome and Firefox.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (WICKET-3597) Wicket 1.5 RC-3 Bug with conditional comments

Posted by "Branden Visser (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13162157#comment-13162157 ] 

Branden Visser commented on WICKET-3597:
----------------------------------------

I'm a little curious about the impact of the change in this commit. If you have a script tag that is not of type "text/javascript", then injecting a /* into the element may have undesired consequences on the template. Is it not valid to have a script tag with type="text/html", and not have /* injected to the output?
                
> Wicket 1.5 RC-3 Bug with conditional comments
> ---------------------------------------------
>
>                 Key: WICKET-3597
>                 URL: https://issues.apache.org/jira/browse/WICKET-3597
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.5-RC3
>         Environment: Windows 7 64b - Chrome 11, Firefox 3.6
>            Reporter: Gabriel Moreira
>            Assignee: Martin Grigorov
>              Labels: javascript
>             Fix For: 1.5-RC4
>
>         Attachments: Chrome 11 Bug.jpg, Firefox bug.jpg, myproject.rar, screenshot-1.jpg
>
>
> IE Conditional Comments with script block causes malformed HTML on Chrome and Firefox.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (WICKET-3597) WICKET 1.5 RC-3 BUG WITH CONDITIONAL COMMENTS

Posted by "Gabriel Moreira (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gabriel Moreira updated WICKET-3597:
------------------------------------

    Attachment: myproject.rar

> WICKET 1.5 RC-3 BUG WITH CONDITIONAL COMMENTS
> ---------------------------------------------
>
>                 Key: WICKET-3597
>                 URL: https://issues.apache.org/jira/browse/WICKET-3597
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-core
>    Affects Versions: 1.5-RC3
>         Environment: Windows 7 64b - Chrome 11, Firefox 3.6
>            Reporter: Gabriel Moreira
>              Labels: javascript
>         Attachments: Chrome 11 Bug.jpg, Firefox bug.jpg, myproject.rar, screenshot-1.jpg
>
>
> IE Conditional Comments with script block causes malformed HTML on Chrome and Firefox.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira