[GitHub] [incubator-echarts] Ovilia commented on a change in pull request #12016: fix bug #11517 the precision of markLine

[GitBox <gi...@apache.org>]

Ovilia commented on a change in pull request #12016: fix bug #11517 the precision of markLine
URL: https://github.com/apache/incubator-echarts/pull/12016#discussion_r365632734
 
 

 ##########
 File path: src/component/marker/MarkLineView.js
 ##########
 @@ -67,9 +67,12 @@ var markLineTransform = function (seriesModel, coordSys, mlModel, item) {
         mlTo.coord[baseIndex] = Infinity;
 
         var precision = mlModel.get('precision');
-        if (precision >= 0 && typeof value === 'number') {
+        if (precision && precision >= 0 && typeof value === 'number') {
 
 Review comment:
   Check if `precision` is `'auto'` instead of `null`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org