You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Piyush Hari (JIRA)" <de...@myfaces.apache.org> on 2007/05/17 23:04:17 UTC
[jira] Created: (TRINIDAD-23) goButton on PDAs should be rendererd
as a linked button and not a button
goButton on PDAs should be rendererd as a linked button and not a button
------------------------------------------------------------------------
Key: TRINIDAD-23
URL: https://issues.apache.org/jira/browse/TRINIDAD-23
Project: MyFaces Trinidad
Issue Type: Improvement
Environment: PDAs
Reporter: Piyush Hari
At present the following logic in GoButtonRenderer renders a goButton as a LINK (html 'a' tag) on PDAs because they don't support button tag :
String element = useButtonTag ? "button" : "a";
PDAs don't support <buttons> but support <input type="buttons"> . So, use <input> instead of <a> for PDAs
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TRINIDAD-23) goButton on PDAs should be
rendererd as a linked button and not a button
Posted by "Piyush Hari (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12496688 ]
Piyush Hari commented on TRINIDAD-23:
-------------------------------------
Link to the old JIRA :
https://issues.apache.org/jira/browse/ADFFACES-266
> goButton on PDAs should be rendererd as a linked button and not a button
> ------------------------------------------------------------------------
>
> Key: TRINIDAD-23
> URL: https://issues.apache.org/jira/browse/TRINIDAD-23
> Project: MyFaces Trinidad
> Issue Type: Improvement
> Environment: PDAs
> Reporter: Piyush Hari
>
> At present the following logic in GoButtonRenderer renders a goButton as a LINK (html 'a' tag) on PDAs because they don't support button tag :
>
> String element = useButtonTag ? "button" : "a";
>
> PDAs don't support <buttons> but support <input type="buttons"> . So, use <input> instead of <a> for PDAs
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TRINIDAD-23) goButton on PDAs should be rendererd
as a linked button and not a button
Posted by "Piyush Hari (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-23?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Piyush Hari updated TRINIDAD-23:
--------------------------------
Status: Patch Available (was: Open)
> goButton on PDAs should be rendererd as a linked button and not a button
> ------------------------------------------------------------------------
>
> Key: TRINIDAD-23
> URL: https://issues.apache.org/jira/browse/TRINIDAD-23
> Project: MyFaces Trinidad
> Issue Type: Improvement
> Environment: PDAs
> Reporter: Piyush Hari
> Attachments: patch_may17_goButton_pda.patch
>
>
> At present the following logic in GoButtonRenderer renders a goButton as a LINK (html 'a' tag) on PDAs because they don't support button tag :
>
> String element = useButtonTag ? "button" : "a";
>
> PDAs don't support <buttons> but support <input type="buttons"> . So, use <input> instead of <a> for PDAs
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TRINIDAD-23) goButton on PDAs should be
rendererd as a linked button and not a button
Posted by "Jeanne Waldman (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12498420 ]
Jeanne Waldman commented on TRINIDAD-23:
----------------------------------------
I sent Piyush a few code review comments, so we need a new patch.
1. make buttonInputOrLink private
2. boolean useButtonTag = useButtonTags(arc); is not being used (you call useButtonTags again)
3. use constants for Button, input, a
4. use .equals to string compare
> goButton on PDAs should be rendererd as a linked button and not a button
> ------------------------------------------------------------------------
>
> Key: TRINIDAD-23
> URL: https://issues.apache.org/jira/browse/TRINIDAD-23
> Project: MyFaces Trinidad
> Issue Type: Improvement
> Environment: PDAs
> Reporter: Piyush Hari
> Priority: Minor
> Attachments: patch_may17_goButton.patch, patch_may17_goButton.patch, patch_may17_goButton_pda.patch
>
>
> At present the following logic in GoButtonRenderer renders a goButton as a LINK (html 'a' tag) on PDAs because they don't support button tag :
>
> String element = useButtonTag ? "button" : "a";
>
> PDAs don't support <buttons> but support <input type="buttons"> . So, use <input> instead of <a> for PDAs
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TRINIDAD-23) goButton on PDAs should be rendererd
as a linked button and not a button
Posted by "Jeanne Waldman (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-23?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeanne Waldman updated TRINIDAD-23:
-----------------------------------
Resolution: Fixed
Fix Version/s: 1.0.1-core
Status: Resolved (was: Patch Available)
Committed svn 541125
Trinidad trunk
For Piyush Hari
> goButton on PDAs should be rendererd as a linked button and not a button
> ------------------------------------------------------------------------
>
> Key: TRINIDAD-23
> URL: https://issues.apache.org/jira/browse/TRINIDAD-23
> Project: MyFaces Trinidad
> Issue Type: Improvement
> Environment: PDAs
> Reporter: Piyush Hari
> Assigned To: Jeanne Waldman
> Priority: Minor
> Fix For: 1.0.1-core
>
> Attachments: patch_may17_goButton.patch, patch_may17_goButton.patch, patch_may17_goButton_pda.patch, patch_may23_goButton.patch
>
>
> At present the following logic in GoButtonRenderer renders a goButton as a LINK (html 'a' tag) on PDAs because they don't support button tag :
>
> String element = useButtonTag ? "button" : "a";
>
> PDAs don't support <buttons> but support <input type="buttons"> . So, use <input> instead of <a> for PDAs
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TRINIDAD-23) goButton on PDAs should be rendererd
as a linked button and not a button
Posted by "Piyush Hari (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-23?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Piyush Hari updated TRINIDAD-23:
--------------------------------
Status: Patch Available (was: Open)
> goButton on PDAs should be rendererd as a linked button and not a button
> ------------------------------------------------------------------------
>
> Key: TRINIDAD-23
> URL: https://issues.apache.org/jira/browse/TRINIDAD-23
> Project: MyFaces Trinidad
> Issue Type: Improvement
> Environment: PDAs
> Reporter: Piyush Hari
> Priority: Minor
> Attachments: patch_may17_goButton.patch, patch_may17_goButton.patch, patch_may17_goButton_pda.patch
>
>
> At present the following logic in GoButtonRenderer renders a goButton as a LINK (html 'a' tag) on PDAs because they don't support button tag :
>
> String element = useButtonTag ? "button" : "a";
>
> PDAs don't support <buttons> but support <input type="buttons"> . So, use <input> instead of <a> for PDAs
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TRINIDAD-23) goButton on PDAs should be rendererd
as a linked button and not a button
Posted by "Piyush Hari (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-23?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Piyush Hari updated TRINIDAD-23:
--------------------------------
Status: Open (was: Patch Available)
> goButton on PDAs should be rendererd as a linked button and not a button
> ------------------------------------------------------------------------
>
> Key: TRINIDAD-23
> URL: https://issues.apache.org/jira/browse/TRINIDAD-23
> Project: MyFaces Trinidad
> Issue Type: Improvement
> Environment: PDAs
> Reporter: Piyush Hari
> Priority: Minor
> Attachments: patch_may17_goButton_pda.patch
>
>
> At present the following logic in GoButtonRenderer renders a goButton as a LINK (html 'a' tag) on PDAs because they don't support button tag :
>
> String element = useButtonTag ? "button" : "a";
>
> PDAs don't support <buttons> but support <input type="buttons"> . So, use <input> instead of <a> for PDAs
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.