[GitHub] [calcite] gierlachg commented on a change in pull request #2530: [CALCITE-4532] Correct code generated for primitive-object ConstantExpression

[GitBox <gi...@apache.org>]

gierlachg commented on a change in pull request #2530:
URL: https://github.com/apache/calcite/pull/2530#discussion_r714729470



##########
File path: linq4j/src/main/java/org/apache/calcite/linq4j/tree/ConstantExpression.java
##########
@@ -136,6 +136,10 @@ private static ExpressionWriter write(ExpressionWriter writer,
       write(writer, value, primitive2.primitiveClass);
       return writer.append(")");
     }
+    Primitive primitive3 = Primitive.ofBox(value.getClass());
+    if (Object.class.equals(type) && primitive3 != null) {

Review comment:
       Wanted to stay consistent with `primitive2` couple of lines above.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org