[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4586: Externalize kvm agent storage reboot configuration

[GitBox <gi...@apache.org>]

DaanHoogland commented on a change in pull request #4586:
URL: https://github.com/apache/cloudstack/pull/4586#discussion_r601682574



##########
File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/KVMHAMonitor.java
##########
@@ -32,17 +33,23 @@
 import java.util.concurrent.ConcurrentHashMap;
 
 public class KVMHAMonitor extends KVMHABase implements Runnable {
+
     private static final Logger s_logger = Logger.getLogger(KVMHAMonitor.class);
-    private final Map<String, NfsStoragePool> _storagePool = new ConcurrentHashMap<String, NfsStoragePool>();
+    private final Map<String, NfsStoragePool> _storagePool = new ConcurrentHashMap<>();

Review comment:
       you mean
   ```suggestion
       private final Map<String, NfsStoragePool> storagePool = new ConcurrentHashMap<>();
   ```
   @RodrigoDLopez ;)
   (will need work in the rest of the file!!!)

##########
File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/KVMHAMonitor.java
##########
@@ -32,17 +33,23 @@
 import java.util.concurrent.ConcurrentHashMap;
 
 public class KVMHAMonitor extends KVMHABase implements Runnable {
+
     private static final Logger s_logger = Logger.getLogger(KVMHAMonitor.class);
-    private final Map<String, NfsStoragePool> _storagePool = new ConcurrentHashMap<String, NfsStoragePool>();
+    private final Map<String, NfsStoragePool> _storagePool = new ConcurrentHashMap<>();
+    private final boolean rebootHostAndAlertManagementOnHearbeatTimeout;
 
-    private final String _hostIP; /* private ip address */
+    /* private ip address */
+    private final String _hostIP;

Review comment:
       same here 
   ```suggestion
       private final String hostIP;
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org