[GitHub] [ignite-3] ygerzhedovich commented on a diff in pull request #1867: IGNITE-19068 Sql. Introduce timestamp type

["ygerzhedovich (via GitHub)" <gi...@apache.org>]

ygerzhedovich commented on code in PR #1867:
URL: https://github.com/apache/ignite-3/pull/1867#discussion_r1158148376


##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/api/ItCommonApiTest.java:
##########
@@ -95,4 +108,61 @@ public void testSessionExpiration() throws Exception {
         // second session could start new query
         ses2.execute(null, "SELECT 2 + 2").close();
     }
+
+    /** Check timestamp type operations correctness using sql and kv api. */
+    @Test
+    public void checkTimestampOperations() {
+        String kvTblName = "tbl_all_columns_sql";
+        String schemaName = "PUBLIC";
+        String keyCol = "key";
+        int maxTimePrecision = TemporalColumnType.MAX_TIME_PRECISION;
+
+        Ignite node = CLUSTER_NODES.get(0);
+
+        // TODO: https://issues.apache.org/jira/browse/IGNITE-19162 Trim all less than millisecond information from timestamp
+        //String tsStr = "2023-03-29T08:22:33.005007Z";

Review Comment:
   in case you use precition 9 it should be "2023-03-29T08:22:33.005007000Z"



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org