You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/05/13 21:34:00 UTC

[jira] [Work logged] (ARTEMIS-2757) AMQP: Broker grants credit before accepting the inbound messages that caused it to grant credit

     [ https://issues.apache.org/jira/browse/ARTEMIS-2757?focusedWorklogId=432843&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-432843 ]

ASF GitHub Bot logged work on ARTEMIS-2757:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 13/May/20 21:33
            Start Date: 13/May/20 21:33
    Worklog Time Spent: 10m 
      Work Description: tabish121 commented on pull request #3130:
URL: https://github.com/apache/activemq-artemis/pull/3130#issuecomment-628257816


   I've spent the afternoon testing this and from what I can tell while it does seem to mitigate the issue to some degree the underlying problem still presents if the broker it pressed.  
   
   In this trace the broker is still pretty far behind in sending dispositions while it is granting more credit to the sender all the while.  
   > -> AMQP: Transfer{handle=0, deliveryId=599999, deliveryTag={504876}, messageFormat=null, settled=false, more=false, rcvSettleMode=null, state=null, resume=null, aborted=null, batchable=null}
   <- AMQP: Disposition{role=RECEIVER, first=519174, last=519174, settled=true, state=Accepted{}, batchable=false}
   <- AMQP: Flow{nextIncomingId=599984, incomingWindow=2147483647, nextOutgoingId=1, outgoingWindow=2147483647, handle=0, deliveryCount=599983, linkCredit=1000, available=0, drain=false, echo=false, properties=null}
   
   The issue doesn't seem to occur to the same degree as before as my Quiver benchmark runs tend to succeed without the massive memory overhead that ensues when the broker gets horribly far behind but it seems like it is still possible to get there over the long haul. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 432843)
    Remaining Estimate: 0h
            Time Spent: 10m

> AMQP: Broker grants credit before accepting the inbound messages that caused it to grant credit
> -----------------------------------------------------------------------------------------------
>
>                 Key: ARTEMIS-2757
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2757
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: AMQP
>    Affects Versions: 2.12.0
>         Environment: AMQP Client sending unsettled messages asynchronously
>            Reporter: Timothy A. Bish
>            Priority: Critical
>             Fix For: 2.13.0
>
>         Attachments: async-sender-output.txt.tar.bz2
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The broker is granting credit to AMQP senders before it has processed and settled (accepted) incoming messages.  When the client sends enough messages to the broker to have crossed the 70% mark that it uses as a replenishment threshold the broker is immediately granting more credit regardless of having actually enqueued and sent the settlement disposition to the sending client thereby essentially granting infinite amounts of credit to a sending client as it bombards the broker with messages. 
>  Small log snippet showing broker dispositions working at a significant backlog compared to flows it is sending:
> {code:java}
> <- AMQP: Disposition{role=RECEIVER, first=528649, last=528649}
> -> AMQP: Transfer{handle=0, deliveryId=594049, deliveryTag={539299}}
> <- AMQP: Flow{nextIncomingId=594014, incomingWindow=2147483647, nextOutgoingId=1, outgoingWindow=2147483647, handle=0, deliveryCount=594013, linkCredit=1000, available=0, drain=false, echo=false, properties=null}
> {code}
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)