[GitHub] spark pull request: SPARK-1706: Allow multiple executors per worke...

[andrewor14 <gi...@git.apache.org>]

Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/731#discussion_r25113210
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/ApplicationDescription.scala ---
    @@ -20,13 +20,14 @@ package org.apache.spark.deploy
     private[spark] class ApplicationDescription(
         val name: String,
         val maxCores: Option[Int],
    -    val memoryPerSlave: Int,
    +    val memoryPerExecutorMB: Int,
         val command: Command,
         var appUiUrl: String,
         val eventLogDir: Option[String] = None)
       extends Serializable {
     
       val user = System.getProperty("user.name", "<unknown>")
    -
    +  // only valid when spark.executor.multiPerWorker is set to true
    +  var maxCorePerExecutor = maxCores
    --- End diff --
    
    this setting doesn't make sense. `maxCores` is the number of cores shared across all nodes in the cluster, not the number of cores on each executor.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org