You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@linkis.apache.org by GitBox <gi...@apache.org> on 2022/03/22 09:48:45 UTC
[GitHub] [incubator-linkis] huapan123456 opened a new pull request #1777: [feature] #1452 support "hive.aux.jars.path" for hive engine
huapan123456 opened a new pull request #1777:
URL: https://github.com/apache/incubator-linkis/pull/1777
### What is the purpose of the change
(For example: EngineConn-Core defines the the abstractions and interfaces of the EngineConn core functions.
The Engine Service in Linkis 0.x is refactored, EngineConn will handle the engine connection and session management.
Related issues: #590. )
### Brief change log
support "hive.aux.jars.path" for hive engine
### Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
### Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- Anything that affects deployment: ( no )
- The MGS(Microservice Governance Services), i.e., Spring Cloud Gateway, OpenFeign, Eureka.: ( no)
### Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org
[GitHub] [incubator-linkis] peacewong commented on a change in pull request #1777: [feature] #1452 support "hive.aux.jars.path" for hive engine
Posted by GitBox <gi...@apache.org>.
peacewong commented on a change in pull request #1777:
URL: https://github.com/apache/incubator-linkis/pull/1777#discussion_r832067687
##########
File path: linkis-engineconn-plugins/engineconn-plugins/hive/src/main/scala/org/apache/linkis/engineplugin/hive/creation/HiveEngineConnFactory.scala
##########
@@ -69,6 +69,11 @@ class HiveEngineConnFactory extends ComputationSingleExecutorEngineConnFactory w
hiveConf.setVar(HiveConf.ConfVars.HIVEFETCHOUTPUTSERDE, HiveEngineConfiguration.BASE64_SERDE_CLASS)
hiveConf.set("enable_fetch_base64","true")
}
+ //add hive.aux.jars.path to hive conf
+ if(StringUtils.isNotEmpty(HiveEngineConfiguration.HIVE_AUX_JARS_PATH)) {
Review comment:
Is it better to use isNotBlank here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org
[GitHub] [incubator-linkis] peacewong merged pull request #1777: [feature] #1452 support "hive.aux.jars.path" for hive engine
Posted by GitBox <gi...@apache.org>.
peacewong merged pull request #1777:
URL: https://github.com/apache/incubator-linkis/pull/1777
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org
[GitHub] [incubator-linkis] huapan123456 commented on a change in pull request #1777: [feature] #1452 support "hive.aux.jars.path" for hive engine
Posted by GitBox <gi...@apache.org>.
huapan123456 commented on a change in pull request #1777:
URL: https://github.com/apache/incubator-linkis/pull/1777#discussion_r832757800
##########
File path: linkis-engineconn-plugins/engineconn-plugins/hive/src/main/scala/org/apache/linkis/engineplugin/hive/creation/HiveEngineConnFactory.scala
##########
@@ -69,6 +69,11 @@ class HiveEngineConnFactory extends ComputationSingleExecutorEngineConnFactory w
hiveConf.setVar(HiveConf.ConfVars.HIVEFETCHOUTPUTSERDE, HiveEngineConfiguration.BASE64_SERDE_CLASS)
hiveConf.set("enable_fetch_base64","true")
}
+ //add hive.aux.jars.path to hive conf
+ if(StringUtils.isNotEmpty(HiveEngineConfiguration.HIVE_AUX_JARS_PATH)) {
Review comment:
Yes, it's better to use isNotBlank . I will update it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org