You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/01/20 05:06:07 UTC
[GitHub] [pulsar-client-go] jonyhy96 opened a new issue #444: Some error results are commented
jonyhy96 opened a new issue #444:
URL: https://github.com/apache/pulsar-client-go/issues/444
#### Expected behavior
Uncomment the error result
#### Actual behavior
https://github.com/apache/pulsar-client-go/blob/master/pulsar/error.go#L42-L73
Some error results are commented
If there is any specific reason that these error results has to be commented?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] freeznet commented on issue #444: Some error results are commented
Posted by GitBox <gi...@apache.org>.
freeznet commented on issue #444:
URL: https://github.com/apache/pulsar-client-go/issues/444#issuecomment-769521661
hi @jonyhy96, i agree with your point. should complete `func getResultStr(r Result) string` first and use `newError` to export the needed errors.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] jonyhy96 commented on issue #444: Some error results are commented
Posted by GitBox <gi...@apache.org>.
jonyhy96 commented on issue #444:
URL: https://github.com/apache/pulsar-client-go/issues/444#issuecomment-764199629
Besides these errors are unexported, we can't assert errors use errors.Is in client side. Perhaps these errors should be export in error.go and use newError to create one?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] jiazhai commented on issue #444: Some error results are commented
Posted by GitBox <gi...@apache.org>.
jiazhai commented on issue #444:
URL: https://github.com/apache/pulsar-client-go/issues/444#issuecomment-772998191
Thanks for @jonyhy96 and @freeznet for the root cause of this issue, mark this as help wanted, so anyone would like to contribute could help on this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] freeznet edited a comment on issue #444: Some error results are commented
Posted by GitBox <gi...@apache.org>.
freeznet edited a comment on issue #444:
URL: https://github.com/apache/pulsar-client-go/issues/444#issuecomment-769521661
hi @jonyhy96, i agree with your point. should complete `func getResultStr(r Result) string` first and use `newError` to export the needed errors. would you like to initialize a pull-request?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] jonyhy96 edited a comment on issue #444: Some error results are commented
Posted by GitBox <gi...@apache.org>.
jonyhy96 edited a comment on issue #444:
URL: https://github.com/apache/pulsar-client-go/issues/444#issuecomment-763335144
/cc @wolfstudy @merlimat
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] jonyhy96 edited a comment on issue #444: Some error results are commented
Posted by GitBox <gi...@apache.org>.
jonyhy96 edited a comment on issue #444:
URL: https://github.com/apache/pulsar-client-go/issues/444#issuecomment-764199629
Besides these [errors](https://github.com/apache/pulsar-client-go/blob/master/pulsar/producer_partition.go#L45-L48) are unexported, we can't assert errors use errors.Is in client side. Perhaps these errors should be export in error.go and use newError to create one?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] jonyhy96 edited a comment on issue #444: Some error results are commented
Posted by GitBox <gi...@apache.org>.
jonyhy96 edited a comment on issue #444:
URL: https://github.com/apache/pulsar-client-go/issues/444#issuecomment-764199629
Besides these [errors](https://github.com/apache/pulsar-client-go/blob/master/pulsar/producer_partition.go#L45-L48) are unexported, we can't assert errors use errors.Is in client side. Perhaps these errors should be export in error.go and use newError to create one?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] wolfstudy closed issue #444: Some error results are commented
Posted by GitBox <gi...@apache.org>.
wolfstudy closed issue #444:
URL: https://github.com/apache/pulsar-client-go/issues/444
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] jonyhy96 edited a comment on issue #444: Some error results are commented
Posted by GitBox <gi...@apache.org>.
jonyhy96 edited a comment on issue #444:
URL: https://github.com/apache/pulsar-client-go/issues/444#issuecomment-763335144
/cc @wolfstudy @merlimat
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] jonyhy96 commented on issue #444: Some error results are commented
Posted by GitBox <gi...@apache.org>.
jonyhy96 commented on issue #444:
URL: https://github.com/apache/pulsar-client-go/issues/444#issuecomment-764199629
Besides these errors are unexported, we can't assert errors use errors.Is in client side. Perhaps these errors should be export in error.go and use newError to create one?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] jonyhy96 commented on issue #444: Some error results are commented
Posted by GitBox <gi...@apache.org>.
jonyhy96 commented on issue #444:
URL: https://github.com/apache/pulsar-client-go/issues/444#issuecomment-763335144
/cc @wolfstudy
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org