[GitHub] [superset] michael-s-molina commented on a change in pull request #13241: test: add Tests and Storybook for AsyncAceEditor

[GitBox <gi...@apache.org>]

michael-s-molina commented on a change in pull request #13241:
URL: https://github.com/apache/superset/pull/13241#discussion_r580146037



##########
File path: superset-frontend/spec/helpers/Worker.ts
##########
@@ -21,9 +21,12 @@ class Worker {
 
   onMessage: Function;
 
+  terminate: Function;
+
   constructor(stringUrl: string) {
     this.url = stringUrl;
     this.onMessage = () => {};
+    this.terminate = () => {};

Review comment:
       During `ReactAce` `willUnmount` cycle the `brace` package invokes `Worker` `terminate`. 
   
   <img width="623" alt="Screen Shot 2021-02-22 at 7 33 04 AM" src="https://user-images.githubusercontent.com/70410625/108696807-cade6180-74e0-11eb-824e-18bf54476d01.png">
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org