You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/12/14 15:02:51 UTC
[GitHub] [pulsar] syhily opened a new issue, #18932: [Client] Drop jcommander dependency in Pulsar java client
syhily opened a new issue, #18932:
URL: https://github.com/apache/pulsar/issues/18932
### Search before asking
- [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar.
### Motivation
Pulsar add the `jcommander` as dependency in `pulsar-common` module, but it should be a optional dependency because most people don't need it in client side.
### Solution
Make the `jcommander` in `pulsar-common` with `<optional>true</optional>`.
### Alternatives
_No response_
### Anything else?
_No response_
### Are you willing to submit a PR?
- [ ] I'm willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on issue #18932: [Client] Drop jcommander dependency in Pulsar java client
Posted by GitBox <gi...@apache.org>.
tisonkun commented on issue #18932:
URL: https://github.com/apache/pulsar/issues/18932#issuecomment-1371907851
@etcZYP Assigned. Go ahead!
... and feel free to ask if you are uncertain.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on issue #18932: [Client] Drop jcommander dependency in Pulsar java client
Posted by GitBox <gi...@apache.org>.
tisonkun commented on issue #18932:
URL: https://github.com/apache/pulsar/issues/18932#issuecomment-1351596937
I agree. Actually, this can be a bad design since the CLI tools is used for generating docs only. We may totally move the functionalities to `pulsar-client-tools` related modules.
cc @nicoloboschi @urfreespace @SignorMercurio
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on issue #18932: [Client] Drop jcommander dependency in Pulsar java client
Posted by GitBox <gi...@apache.org>.
tisonkun commented on issue #18932:
URL: https://github.com/apache/pulsar/issues/18932#issuecomment-1384811263
@etcZYP I think you should directly send a patch against the master branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] etcZYP commented on issue #18932: [Client] Drop jcommander dependency in Pulsar java client
Posted by GitBox <gi...@apache.org>.
etcZYP commented on issue #18932:
URL: https://github.com/apache/pulsar/issues/18932#issuecomment-1384792564
> @etcZYP Assigned. Go ahead!
>
> ... and feel free to ask if you are uncertain.
can you plz tell me which branch should i merge into?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tobehardest commented on issue #18932: [Client] Drop jcommander dependency in Pulsar java client
Posted by "tobehardest (via GitHub)" <gi...@apache.org>.
tobehardest commented on issue #18932:
URL: https://github.com/apache/pulsar/issues/18932#issuecomment-1491395405
Maybe I can try to see if I can solve this, can you assign it to me?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on issue #18932: [Client] Drop jcommander dependency in Pulsar java client
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on issue #18932:
URL: https://github.com/apache/pulsar/issues/18932#issuecomment-1491397519
@tobehardest there are three assignees from then here. I suggest you make a patch and I'll be glad to review and assign this ticket to you.
Also cc @jak78 do you still work on this ticket?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on issue #18932: [Client] Drop jcommander dependency in Pulsar java client
Posted by GitBox <gi...@apache.org>.
tisonkun commented on issue #18932:
URL: https://github.com/apache/pulsar/issues/18932#issuecomment-1351610559
A test script to guard this refactor if it happens is [reference-doc-generator.py](https://github.com/apache/pulsar-site/tree/main/tools/pytools#reference-doc-generator) in the site repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jak78 commented on issue #18932: [Client] Drop jcommander dependency in Pulsar java client
Posted by "jak78 (via GitHub)" <gi...@apache.org>.
jak78 commented on issue #18932:
URL: https://github.com/apache/pulsar/issues/18932#issuecomment-1491452742
@tobehardest I’m glad you can make it, you can go ahead. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on issue #18932: [Client] Drop jcommander dependency in Pulsar java client
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #18932:
URL: https://github.com/apache/pulsar/issues/18932#issuecomment-1529243020
The issue had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on issue #18932: [Client] Drop jcommander dependency in Pulsar java client
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on issue #18932:
URL: https://github.com/apache/pulsar/issues/18932#issuecomment-1619347317
Extend #20700 to fix this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun closed issue #18932: [Client] Drop jcommander dependency in Pulsar java client
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun closed issue #18932: [Client] Drop jcommander dependency in Pulsar java client
URL: https://github.com/apache/pulsar/issues/18932
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jak78 commented on issue #18932: [Client] Drop jcommander dependency in Pulsar java client
Posted by "jak78 (via GitHub)" <gi...@apache.org>.
jak78 commented on issue #18932:
URL: https://github.com/apache/pulsar/issues/18932#issuecomment-1453398286
Hello @etcZYP ! Are you still working on this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jak78 commented on issue #18932: [Client] Drop jcommander dependency in Pulsar java client
Posted by "jak78 (via GitHub)" <gi...@apache.org>.
jak78 commented on issue #18932:
URL: https://github.com/apache/pulsar/issues/18932#issuecomment-1460194994
OK I'll try to fix it by next week
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on issue #18932: [Client] Drop jcommander dependency in Pulsar java client
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #18932:
URL: https://github.com/apache/pulsar/issues/18932#issuecomment-1433994155
The issue had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on issue #18932: [Client] Drop jcommander dependency in Pulsar java client
Posted by GitBox <gi...@apache.org>.
tisonkun commented on issue #18932:
URL: https://github.com/apache/pulsar/issues/18932#issuecomment-1354110598
We may move out these classes to a dedicated module.
One class needs more consideration is `org.apache.pulsar.client.impl.conf.CmdGenerateDocumentation` in `pulsar-client-original`. It depends on jcommander transitively. And its FQN is referred by [reference-doc-generator.py](https://github.com/apache/pulsar-site/tree/main/tools/pytools#reference-doc-generator) in the site repo.
Either we move it to another module while keep its FQN, or we should update the FQN and do some compatibility logics in the pytools in the site repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on issue #18932: [Client] Drop jcommander dependency in Pulsar java client
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on issue #18932:
URL: https://github.com/apache/pulsar/issues/18932#issuecomment-1460162929
Unassign the previous inactive assignee. @jak78 Would you like to take over this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] etcZYP commented on issue #18932: [Client] Drop jcommander dependency in Pulsar java client
Posted by GitBox <gi...@apache.org>.
etcZYP commented on issue #18932:
URL: https://github.com/apache/pulsar/issues/18932#issuecomment-1371899978
assign to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on issue #18932: [Client] Drop jcommander dependency in Pulsar java client
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on issue #18932:
URL: https://github.com/apache/pulsar/issues/18932#issuecomment-1615546511
I remove part of the usage in https://github.com/apache/pulsar/pull/20700, while there are still several others. What a mess 🤣.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org