You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/30 14:52:25 UTC
[GitHub] [arrow-rs] iajoiner opened a new pull request, #2612: Update version to `22.0.0`
iajoiner opened a new pull request, #2612:
URL: https://github.com/apache/arrow-rs/pull/2612
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #2542.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] iajoiner commented on pull request #2612: Update version to `22.0.0` and update `CHANGELOG`
Posted by GitBox <gi...@apache.org>.
iajoiner commented on PR #2612:
URL: https://github.com/apache/arrow-rs/pull/2612#issuecomment-1234973200
@alamb We should be good now haha.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #2612: Update version to `22.0.0` and update `CHANGELOG`
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #2612:
URL: https://github.com/apache/arrow-rs/pull/2612#issuecomment-1235341227
And now that I think about what I am actually doing maually here, it is mostly moving the component tags like `object-store` or `arrow` from the PR (which are automatically labeled) to the specific issue (which are not). That is probably something I can script and will look into for the next release 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on a diff in pull request #2612: Update version to `22.0.0` and update `CHANGELOG`
Posted by GitBox <gi...@apache.org>.
alamb commented on code in PR #2612:
URL: https://github.com/apache/arrow-rs/pull/2612#discussion_r961537026
##########
dev/release/README.md:
##########
@@ -69,7 +69,7 @@ git checkout master
git pull
git checkout -b make-release
-# Move the content of CHANGELOG.md to CHANGELOG-old.md
+# Copy the content of CHANGELOG.md to the beginning of CHANGELOG-old.md
Review Comment:
❤️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on a diff in pull request #2612: Update version to `22.0.0` and update `CHANGELOG`
Posted by GitBox <gi...@apache.org>.
alamb commented on code in PR #2612:
URL: https://github.com/apache/arrow-rs/pull/2612#discussion_r958638396
##########
CHANGELOG.md:
##########
@@ -19,114 +19,110 @@
# Changelog
-## [21.0.0](https://github.com/apache/arrow-rs/tree/21.0.0) (2022-08-18)
Review Comment:
🤔 something I clearly haven't documented is that I normally copy the old release notes into https://github.com/apache/arrow-rs/blob/master/CHANGELOG-old.md -- is there any chance yuo can do that too (and make a note in the readme?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #2612: Update version to `22.0.0` and update `CHANGELOG`
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #2612:
URL: https://github.com/apache/arrow-rs/pull/2612#issuecomment-1234575649
@iajoiner thanks again for this PR. I took the liberty of merging up from master to resolve a merge conflict. I have also updated tags on the various tickets.
If you get chance to address the feedback on this PR (e.g. restore the old release notes in CHANGELOG-old.md) by tomorrow morning (US Eastern) that would be great. Otherwise no sweat and I'll handle doing it.
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #2612: Update version to `22.0.0` and update `CHANGELOG`
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #2612:
URL: https://github.com/apache/arrow-rs/pull/2612#issuecomment-1234576247
(I plan to merge this PR tomorrow morning and cut a release candidate)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] iajoiner commented on a diff in pull request #2612: Update version to `22.0.0` and update `CHANGELOG`
Posted by GitBox <gi...@apache.org>.
iajoiner commented on code in PR #2612:
URL: https://github.com/apache/arrow-rs/pull/2612#discussion_r961812162
##########
CHANGELOG.md:
##########
@@ -19,114 +19,110 @@
# Changelog
-## [21.0.0](https://github.com/apache/arrow-rs/tree/21.0.0) (2022-08-18)
Review Comment:
@alamb Yes. That's appropriate for this weekend lol.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb merged pull request #2612: Update version to `22.0.0` and update `CHANGELOG`
Posted by GitBox <gi...@apache.org>.
alamb merged PR #2612:
URL: https://github.com/apache/arrow-rs/pull/2612
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ursabot commented on pull request #2612: Update version to `22.0.0` and update `CHANGELOG`
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #2612:
URL: https://github.com/apache/arrow-rs/pull/2612#issuecomment-1235774346
Benchmark runs are scheduled for baseline = 2b2c15b856085bf32a874582efa65ce4904f969c and contender = e5b9d05ec50807666efe401729708d53216d79fc. e5b9d05ec50807666efe401729708d53216d79fc is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/f86cb8098a74478a9af64ae732e0f70a...e45411237e474571bdada4810f35fd9d/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/b56b28d89e824146b911e2015314ba1c...724707bad3f8495e91e2abd3c0ec6fce/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/3e80844dde3e44958d18d404c7673989...d74730d55f4e4713923d041d8d5e9e2d/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/fa27ecd1d3f34c45b4007f3c34696f5b...61c38bedb1f14454abf811ca1303b654/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on a diff in pull request #2612: Update version to `22.0.0` and update `CHANGELOG`
Posted by GitBox <gi...@apache.org>.
alamb commented on code in PR #2612:
URL: https://github.com/apache/arrow-rs/pull/2612#discussion_r961590270
##########
CHANGELOG.md:
##########
@@ -19,114 +19,110 @@
# Changelog
-## [21.0.0](https://github.com/apache/arrow-rs/tree/21.0.0) (2022-08-18)
Review Comment:
It would be awesome to do so -- I haven't had the time. Any chance you want to take it on ? Some simple shell script / python would probably be sufficient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] iajoiner commented on pull request #2612: Update version to `22.0.0` and update `CHANGELOG`
Posted by GitBox <gi...@apache.org>.
iajoiner commented on PR #2612:
URL: https://github.com/apache/arrow-rs/pull/2612#issuecomment-1234829756
@alamb Don’t worry I will take care of that.
On Thursday, September 1, 2022, Andrew Lamb ***@***.***>
wrote:
> @iajoiner <https://github.com/iajoiner> thanks again for this PR. I took
> the liberty of merging up from master to resolve a merge conflict. I have
> also updated tags on the various tickets.
>
> If you get chance to address the feedback on this PR (e.g. restore the old
> release notes in CHANGELOG-old.md) by tomorrow morning (US Eastern) that
> would be great. Otherwise no sweat and I'll handle doing it.
>
> Thanks
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/arrow-rs/pull/2612#issuecomment-1234575649>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ADPH4IKI47ZSUTBEB3FMVELV4DRWJANCNFSM6AAAAAAQAPTXQA>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] iajoiner commented on a diff in pull request #2612: Update version to `22.0.0` and update `CHANGELOG`
Posted by GitBox <gi...@apache.org>.
iajoiner commented on code in PR #2612:
URL: https://github.com/apache/arrow-rs/pull/2612#discussion_r961218536
##########
CHANGELOG.md:
##########
@@ -19,114 +19,110 @@
# Changelog
-## [21.0.0](https://github.com/apache/arrow-rs/tree/21.0.0) (2022-08-18)
Review Comment:
Sure! I think we should automate this as well haha.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org