You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/06/28 04:43:09 UTC

[GitHub] [shardingsphere-elasticjob] skaic opened a new pull request #1911: SingleSharding process keep pace with MultipleSharding process

skaic opened a new pull request #1911:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1911


   Fixes #1910.
   
   Changes proposed in this pull request:
   - remove SingleSharding process run in currentThread
   - catch ExecutionException and throw the JobSystemException of executorService.submit
   -  `assertExecuteFailureWhenThrowExceptionForMultipleShardingItems`  test is JobSystemException
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere-elasticjob] skaic commented on pull request #1911: SingleSharding process keep pace with MultipleSharding process

Posted by GitBox <gi...@apache.org>.
skaic commented on pull request #1911:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1911#issuecomment-870168017


   Thanks for the reply. @TeslaCN 
   
   I'm trying work of https://github.com/apache/shardingsphere-elasticjob/issues/1464 . 
   So I need all process run are same `currentThread` or  `executorService.submit` at first.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere-elasticjob] skaic closed pull request #1911: SingleSharding process keep pace with MultipleSharding process

Posted by GitBox <gi...@apache.org>.
skaic closed pull request #1911:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1911


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere-elasticjob] TeslaCN commented on pull request #1911: SingleSharding process keep pace with MultipleSharding process

Posted by GitBox <gi...@apache.org>.
TeslaCN commented on pull request #1911:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1911#issuecomment-870171192


   > Thanks for the reply. @TeslaCN
   > 
   > I'm trying work of #1464 .
   > So I need all process run are same `currentThread` or `executorService.submit` at first.
   
   I think it is better to discuss about how before doing that.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere-elasticjob] codecov-commenter commented on pull request #1911: SingleSharding process keep pace with MultipleSharding process

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1911:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1911#issuecomment-869352622


   # [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1911?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1911](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1911?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7c543e4) into [master](https://codecov.io/gh/apache/shardingsphere-elasticjob/commit/adcf88ce2decc6dce507c93cfa5c2911df2ee7f2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (adcf88c) will **decrease** coverage by `0.08%`.
   > The diff coverage is `83.33%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1911/graphs/tree.svg?width=650&height=150&src=pr&token=8ZMVc4Yo4Z&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1911?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1911      +/-   ##
   ============================================
   - Coverage     85.66%   85.57%   -0.09%     
   + Complexity      114      113       -1     
   ============================================
     Files           276      276              
     Lines          6026     6031       +5     
     Branches        922      922              
   ============================================
   - Hits           5162     5161       -1     
   - Misses          525      529       +4     
   - Partials        339      341       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1911?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...sphere/elasticjob/executor/ElasticJobExecutor.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1lY29zeXN0ZW0vZWxhc3RpY2pvYi1leGVjdXRvci9lbGFzdGljam9iLWV4ZWN1dG9yLWtlcm5lbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9leGVjdXRvci9FbGFzdGljSm9iRXhlY3V0b3IuamF2YQ==) | `89.69% <83.33%> (-1.62%)` | :arrow_down: |
   | [...e/shardingsphere/elasticjob/infra/env/IpUtils.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLWluZnJhLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9pbmZyYS9lbnYvSXBVdGlscy5qYXZh) | `60.00% <0.00%> (-4.62%)` | :arrow_down: |
   | [...sticjob/reg/zookeeper/ZookeeperRegistryCenter.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLXJlZ2lzdHJ5LWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9yZWcvem9va2VlcGVyL1pvb2tlZXBlclJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `72.44% <0.00%> (-0.79%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1911?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1911?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [adcf88c...7c543e4](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1911?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere-elasticjob] skaic closed pull request #1911: SingleSharding process keep pace with MultipleSharding process

Posted by GitBox <gi...@apache.org>.
skaic closed pull request #1911:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1911


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere-elasticjob] skaic commented on pull request #1911: SingleSharding process keep pace with MultipleSharding process

Posted by GitBox <gi...@apache.org>.
skaic commented on pull request #1911:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1911#issuecomment-870168017






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere-elasticjob] TeslaCN commented on pull request #1911: SingleSharding process keep pace with MultipleSharding process

Posted by GitBox <gi...@apache.org>.
TeslaCN commented on pull request #1911:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1911#issuecomment-870171192


   > Thanks for the reply. @TeslaCN
   > 
   > I'm trying work of #1464 .
   > So I need all process run are same `currentThread` or `executorService.submit` at first.
   
   I think it is better to discuss about how before doing that.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere-elasticjob] skaic commented on pull request #1911: SingleSharding process keep pace with MultipleSharding process

Posted by GitBox <gi...@apache.org>.
skaic commented on pull request #1911:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1911#issuecomment-870171675


   Yes, you are right.  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org