You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2019/11/10 09:59:58 UTC
[kudu-CR] mini chronyd: switch to using symbolic links
Hello Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/14684
to review the following change.
Change subject: mini_chronyd: switch to using symbolic links
......................................................................
mini_chronyd: switch to using symbolic links
The one gotcha is that the symbolic links won't exist a priori in a remote
dist-test machine, which causes MiniChronyd::GetPath to fail to find the
chrony binaries. To fix this, run_dist_test.py must recreate the links.
Change-Id: Id24d97d2badfee3e121f01a5280a2879513782de
---
M build-support/run_dist_test.py
M src/kudu/clock/CMakeLists.txt
2 files changed, 17 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/84/14684/1
--
To view, visit http://gerrit.cloudera.org:8080/14684
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id24d97d2badfee3e121f01a5280a2879513782de
Gerrit-Change-Number: 14684
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
[kudu-CR] mini chronyd: switch to using symbolic links
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14684
to look at the new patch set (#3).
Change subject: mini_chronyd: switch to using symbolic links
......................................................................
mini_chronyd: switch to using symbolic links
The one gotcha is that the symbolic links won't exist a priori in a remote
dist-test machine, which causes MiniChronyd::GetPath to fail to find the
chrony binaries. To fix this, run_dist_test.py must recreate the links.
Change-Id: Id24d97d2badfee3e121f01a5280a2879513782de
---
M build-support/run_dist_test.py
M src/kudu/clock/CMakeLists.txt
2 files changed, 17 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/84/14684/3
--
To view, visit http://gerrit.cloudera.org:8080/14684
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id24d97d2badfee3e121f01a5280a2879513782de
Gerrit-Change-Number: 14684
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] mini chronyd: switch to using symbolic links
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14684 )
Change subject: mini_chronyd: switch to using symbolic links
......................................................................
mini_chronyd: switch to using symbolic links
The one gotcha is that the symbolic links won't exist a priori in a remote
dist-test machine, which causes MiniChronyd::GetPath to fail to find the
chrony binaries. To fix this, run_dist_test.py must recreate the links.
Change-Id: Id24d97d2badfee3e121f01a5280a2879513782de
Reviewed-on: http://gerrit.cloudera.org:8080/14684
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M build-support/run_dist_test.py
M src/kudu/clock/CMakeLists.txt
2 files changed, 17 insertions(+), 9 deletions(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/14684
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id24d97d2badfee3e121f01a5280a2879513782de
Gerrit-Change-Number: 14684
Gerrit-PatchSet: 4
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] mini chronyd: switch to using symbolic links
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14684 )
Change subject: mini_chronyd: switch to using symbolic links
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14684/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/14684/2//COMMIT_MSG@9
PS2, Line 9: The one gotcha is that the symbolic links won't exist a priori
Why is it needed at all? I'm not sure I understand: as of now, tests involving chronyd as as a test NTP server work without any symlinks.
--
To view, visit http://gerrit.cloudera.org:8080/14684
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id24d97d2badfee3e121f01a5280a2879513782de
Gerrit-Change-Number: 14684
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 12 Nov 2019 18:07:54 +0000
Gerrit-HasComments: Yes
[kudu-CR] mini chronyd: switch to using symbolic links
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14684 )
Change subject: mini_chronyd: switch to using symbolic links
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14684/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/14684/2//COMMIT_MSG@9
PS2, Line 9: The one gotcha is that the symbolic links won't exist a priori
> Why is it needed at all? I'm not sure I understand: as of now, tests invol
Right, but I think symlinking the chrony binaries is cleaner. It's also more consistent with how we manage other thirdparty dependencies like this (e.g. Sentry and Hive bundles).
--
To view, visit http://gerrit.cloudera.org:8080/14684
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id24d97d2badfee3e121f01a5280a2879513782de
Gerrit-Change-Number: 14684
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 12 Nov 2019 21:23:34 +0000
Gerrit-HasComments: Yes
[kudu-CR] mini chronyd: switch to using symbolic links
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has removed a vote on this change.
Change subject: mini_chronyd: switch to using symbolic links
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/14684
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Id24d97d2badfee3e121f01a5280a2879513782de
Gerrit-Change-Number: 14684
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] mini chronyd: switch to using symbolic links
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14684 )
Change subject: mini_chronyd: switch to using symbolic links
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14684
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id24d97d2badfee3e121f01a5280a2879513782de
Gerrit-Change-Number: 14684
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 13 Nov 2019 15:01:11 +0000
Gerrit-HasComments: No
[kudu-CR] mini chronyd: switch to using symbolic links
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14684 )
Change subject: mini_chronyd: switch to using symbolic links
......................................................................
Patch Set 1: Verified+1
Overriding Jenkins, unrelated HMS test failure.
--
To view, visit http://gerrit.cloudera.org:8080/14684
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id24d97d2badfee3e121f01a5280a2879513782de
Gerrit-Change-Number: 14684
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 12 Nov 2019 06:12:54 +0000
Gerrit-HasComments: No
[kudu-CR] mini chronyd: switch to using symbolic links
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14684 )
Change subject: mini_chronyd: switch to using symbolic links
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
It seems this patch needs to be rebased, but overall LGTM.
http://gerrit.cloudera.org:8080/#/c/14684/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/14684/2//COMMIT_MSG@9
PS2, Line 9: The one gotcha is that the symbolic links won't exist a priori
> Right, but I think symlinking the chrony binaries is cleaner. It's also mor
I agree: symlinking is cleaner since that way there is no duplication of the same data on disk, at least.
--
To view, visit http://gerrit.cloudera.org:8080/14684
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id24d97d2badfee3e121f01a5280a2879513782de
Gerrit-Change-Number: 14684
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 13 Nov 2019 04:05:18 +0000
Gerrit-HasComments: Yes
[kudu-CR] mini chronyd: switch to using symbolic links
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14684 )
Change subject: mini_chronyd: switch to using symbolic links
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14684
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id24d97d2badfee3e121f01a5280a2879513782de
Gerrit-Change-Number: 14684
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 12 Nov 2019 13:44:38 +0000
Gerrit-HasComments: No