You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@yunikorn.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2023/11/10 02:01:00 UTC

[jira] [Updated] (YUNIKORN-2137) Remove defer cleanup in checkLimits

     [ https://issues.apache.org/jira/browse/YUNIKORN-2137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

ASF GitHub Bot updated YUNIKORN-2137:
-------------------------------------
    Labels: newbie pull-request-available  (was: newbie)

> Remove defer cleanup in checkLimits
> -----------------------------------
>
>                 Key: YUNIKORN-2137
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-2137
>             Project: Apache YuniKorn
>          Issue Type: Improvement
>          Components: core - scheduler
>            Reporter: PoAn Yang
>            Assignee: JiaChi Wang
>            Priority: Minor
>              Labels: newbie, pull-request-available
>
> Code Reference: [https://github.com/apache/yunikorn-core/blob/30e69f97585bc3a82f4b9c54f4cc4b601120a776/pkg/common/configs/configvalidator.go#L586-L594]
> Slack Reference: [https://yunikornworkspace.slack.com/archives/CL9CRJ1KM/p1699430436233019]
>  
> The {{existedUserName}} and {{existedGroupName}} in {{checkLimits}} will be GC after the goroutine leaves the function. It's safe to remove the defer function.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: issues-help@yunikorn.apache.org