[GitHub] [bookkeeper] StevenLuMT commented on a diff in pull request #3418: fix Flaky-test: BookieZKExpireTest.testBookieServerZKSessionExpireBehaviour

[GitBox <gi...@apache.org>]

StevenLuMT commented on code in PR #3418:
URL: https://github.com/apache/bookkeeper/pull/3418#discussion_r928182181


##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/zk/ZKMetadataDriverBase.java:
##########
@@ -165,7 +165,8 @@ public String getScheme() {
     protected void initialize(AbstractConfiguration<?> conf,
                               StatsLogger statsLogger,
                               RetryPolicy zkRetryPolicy,
-                              Optional<Object> optionalCtx) throws MetadataException {
+                              Optional<Object> optionalCtx,
+                              boolean zkRetryExpired) throws MetadataException {

Review Comment:
   this check(zkRetryExpired) is difficult to understand, what scene is set to true and what scene is set to false



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org