You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/02/17 01:03:49 UTC
[GitHub] [beam] chamikaramj commented on a change in pull request #13908: [BEAM-10671] Add environmentOptions to Java.
chamikaramj commented on a change in pull request #13908:
URL: https://github.com/apache/beam/pull/13908#discussion_r577247819
##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/options/PortablePipelineOptions.java
##########
@@ -103,4 +103,32 @@
String getOutputExecutablePath();
void setOutputExecutablePath(String outputExecutablePath);
+
+ @Description(
+ "Options for configuring the environment of portable workers. Recognized options depend on the value of defaultEnvironmentType:\n"
+ + "DOCKER: docker_container_image (optional)\n"
+ + "EXTERNAL: external_service_address (required)\n"
Review comment:
Please mention the format these options should be specified with an example.
##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/options/PortablePipelineOptions.java
##########
@@ -103,4 +103,32 @@
String getOutputExecutablePath();
void setOutputExecutablePath(String outputExecutablePath);
+
+ @Description(
+ "Options for configuring the environment of portable workers. Recognized options depend on the value of defaultEnvironmentType:\n"
Review comment:
Mention that this will be used to configure default environment of the pipeline SDK but not the external SDKs of any cross-language pipelines used by the pipeline.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org