Re: [PR] [improve][admin] Include schema ledger ids in topic internal-info [pulsar]

["merlimat (via GitHub)" <gi...@apache.org>]

merlimat commented on PR #19883:
URL: https://github.com/apache/pulsar/pull/19883#issuecomment-6357226242

   Hi @rdhabalia, this is still useful: `stats-internal` already shows schema ledgers, but it needs the
   topic loaded, and that's exactly what fails in #19882/#20415. Since the PR had gone quiet, I've pushed
   two commits to your branch:
   
   - merged `master` (no rebase), resolving the conflicts in `PersistentTopicsBase` and
     `ClientGetSchemaTest`;
   - f0655c0105:
     - checks for `BookkeeperSchemaStorage` with `instanceof` instead of casting unconditionally;
     - reads the schema locator only after the `GET_STATS` authorization check;
     - still returns the managed ledger info if the locator read fails;
     - keeps `schemaLedgers` in the partitioned-topic response;
     - rewrites the test to assert that the deleted ledger id is reported.
   
   I also updated the title and description to match. @vineeth1995 @tisonkun could you take another
   look?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org