You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2019/02/07 17:04:20 UTC
[GitHub] dpa99c commented on issue #413: beforeload callback doesnt get
called on Android
dpa99c commented on issue #413: beforeload callback doesnt get called on Android
URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/413#issuecomment-461512565
I reworked the Android implementation under https://github.com/apache/cordova-plugin-inappbrowser/pull/367 and `beforeload` definitely worked on Android when I did it.
But I've just regression tested and the event is not being fired now because the [`shouldOverrideUrlLoading()` method](https://github.com/apache/cordova-plugin-inappbrowser/blob/master/src/android/InAppBrowser.java#L1171) on the WebViewClient is never getting invoked.
I wonder if an update to the Android Chrome Webview has broken this, since I'm testing exactly the same code that worked before on exactly the same device... Will investigate...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org