You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/21 11:18:26 UTC
[GitHub] [spark] HyukjinKwon opened a new pull request, #39157: [SPARK-41646][CONNECT] Deduplicate docstrings in pyspark.sql.connect.session
HyukjinKwon opened a new pull request, #39157:
URL: https://github.com/apache/spark/pull/39157
### What changes were proposed in this pull request?
This PR proposes to deduplicate docstrings in `pyspark.sql.connect.session`.
### Why are the changes needed?
For easier maintenance
### Does this PR introduce _any_ user-facing change?
No, dev-only. There're mintor doc changes that mention about remote support in Apache Spark 3.4.
### How was this patch tested?
No test. It has to be manually verified until we resolve SPARK-41653.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #39157: [SPARK-41646][CONNECT] Deduplicate docstrings in pyspark.sql.connect.session
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on code in PR #39157:
URL: https://github.com/apache/spark/pull/39157#discussion_r1054292437
##########
python/pyspark/sql/connect/session.py:
##########
@@ -112,39 +72,6 @@ def config(
*,
map: Optional[Dict[str, "OptionalPrimitiveType"]] = None,
) -> "SparkSession.Builder":
- """Sets a config option. Options set using this method are automatically propagated to
Review Comment:
These method would be fully internal and can't be exposed to end users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #39157: [SPARK-41646][CONNECT] Deduplicate docstrings in pyspark.sql.connect.session
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #39157:
URL: https://github.com/apache/spark/pull/39157#issuecomment-1362263803
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on pull request #39157: [SPARK-41646][CONNECT] Deduplicate docstrings in pyspark.sql.connect.session
Posted by GitBox <gi...@apache.org>.
amaliujia commented on PR #39157:
URL: https://github.com/apache/spark/pull/39157#issuecomment-1362301045
LGTM!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #39157: [SPARK-41646][CONNECT] Deduplicate docstrings in pyspark.sql.connect.session
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #39157: [SPARK-41646][CONNECT] Deduplicate docstrings in pyspark.sql.connect.session
URL: https://github.com/apache/spark/pull/39157
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org