You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Alejandro Fernandez <af...@hortonworks.com> on 2016/02/09 22:49:13 UTC
Review Request 43378: Ambari Upgrade should not automatically add
stack properties that reference localhost like
dfs.namenode.secondary.http-address, mark with DONT_ADD_ON_UPGRADE
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43378/
-----------------------------------------------------------
Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Jonathan Hurley, Jayush Luniya, Nate Cole, Srimanth Gunturi, and Sid Wagle.
Bugs: AMBARI-14979
https://issues.apache.org/jira/browse/AMBARI-14979
Repository: ambari
Description
-------
STR
* Ambari 2.0.2
* Added NameNode HA
* Upgraded to Ambari 2.2.0, which added dfs.namenode.secondary.http-address="localhost:50090"
This is an example of how Ambari upgrade should not be modifying stack properties.
Diffs
-----
ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/configuration/accumulo-site.xml 2e75768
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/application-properties.xml 74b1537
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-startup.properties.xml 66a297c
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/configuration/hbase-site.xml 4fefb1e
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/core-site.xml 4d73250
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hdfs-site.xml ea5514d
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-site.xml 80da3a1
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/webhcat-site.xml 72a5710
ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/configuration/kafka-broker.xml b23075d
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/ranger-knox-plugin-properties.xml 0ab649c
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/configuration/oozie-site.xml 5a18875
ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.3/configuration/oozie-site.xml 2ecc0ca
ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/ranger-env.xml 0cffae0
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-site.xml 889e310
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-site.xml 4719dbb
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration-mapred/mapred-site.xml 5737c4d
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration/yarn-site.xml 802a1f5
ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml aad9ba5
ambari-server/src/main/resources/stacks/HDP/2.1/services/OOZIE/configuration/oozie-site.xml af1a0a8
ambari-server/src/main/resources/stacks/HDP/2.1/services/YARN/configuration/yarn-site.xml 667c374
ambari-server/src/main/resources/stacks/HDP/2.2/services/HBASE/configuration/ranger-hbase-plugin-properties.xml 4e87151
ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/ranger-hdfs-plugin-properties.xml 8bb6369
ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-site.xml 35db348
ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/ranger-hive-plugin-properties.xml a9ceb29
ambari-server/src/main/resources/stacks/HDP/2.2/services/STORM/configuration/ranger-storm-plugin-properties.xml ef07f4f
ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/configuration/yarn-site.xml e75442f
ambari-server/src/main/resources/stacks/HDP/2.3/services/KAFKA/configuration/kafka-broker.xml 8c2f34a
ambari-server/src/main/resources/stacks/HDP/2.3/services/KAFKA/configuration/ranger-kafka-plugin-properties.xml 490e059
ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-env.xml 1e86e7d
ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/storm-site.xml ca6d2b6
Diff: https://reviews.apache.org/r/43378/diff/
Testing
-------
Verified on a live cluster during Ambari upgrade
Ran all service checks, which passed
Thanks,
Alejandro Fernandez
Re: Review Request 43378: Ambari Upgrade should not automatically add
stack properties that reference localhost like
dfs.namenode.secondary.http-address, mark with DONT_ADD_ON_UPGRADE
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43378/#review118473
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/configuration/accumulo-site.xml (line 27)
<https://reviews.apache.org/r/43378/#comment179712>
Any property with "localhost" shouldn't be added automatically on Ambari upgrade.
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hdfs-site.xml (line 370)
<https://reviews.apache.org/r/43378/#comment179713>
This was the bug fix. If NameNode HA is present, then we should not add this config.
- Alejandro Fernandez
On Feb. 9, 2016, 9:49 p.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43378/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2016, 9:49 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Jonathan Hurley, Jayush Luniya, Nate Cole, Srimanth Gunturi, and Sid Wagle.
>
>
> Bugs: AMBARI-14979
> https://issues.apache.org/jira/browse/AMBARI-14979
>
>
> Repository: ambari
>
>
> Description
> -------
>
> STR
>
> * Ambari 2.0.2
> * Added NameNode HA
> * Upgraded to Ambari 2.2.0, which added dfs.namenode.secondary.http-address="localhost:50090"
>
> This is an example of how Ambari upgrade should not be modifying stack properties.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/configuration/accumulo-site.xml 2e75768
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/application-properties.xml 74b1537
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-startup.properties.xml 66a297c
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/configuration/hbase-site.xml 4fefb1e
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/core-site.xml 4d73250
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hdfs-site.xml ea5514d
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-site.xml 80da3a1
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/webhcat-site.xml 72a5710
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/configuration/kafka-broker.xml b23075d
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/ranger-knox-plugin-properties.xml 0ab649c
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/configuration/oozie-site.xml 5a18875
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.3/configuration/oozie-site.xml 2ecc0ca
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/ranger-env.xml 0cffae0
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-site.xml 889e310
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-site.xml 4719dbb
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration-mapred/mapred-site.xml 5737c4d
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration/yarn-site.xml 802a1f5
> ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml aad9ba5
> ambari-server/src/main/resources/stacks/HDP/2.1/services/OOZIE/configuration/oozie-site.xml af1a0a8
> ambari-server/src/main/resources/stacks/HDP/2.1/services/YARN/configuration/yarn-site.xml 667c374
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HBASE/configuration/ranger-hbase-plugin-properties.xml 4e87151
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/ranger-hdfs-plugin-properties.xml 8bb6369
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-site.xml 35db348
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/ranger-hive-plugin-properties.xml a9ceb29
> ambari-server/src/main/resources/stacks/HDP/2.2/services/STORM/configuration/ranger-storm-plugin-properties.xml ef07f4f
> ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/configuration/yarn-site.xml e75442f
> ambari-server/src/main/resources/stacks/HDP/2.3/services/KAFKA/configuration/kafka-broker.xml 8c2f34a
> ambari-server/src/main/resources/stacks/HDP/2.3/services/KAFKA/configuration/ranger-kafka-plugin-properties.xml 490e059
> ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-env.xml 1e86e7d
> ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/storm-site.xml ca6d2b6
>
> Diff: https://reviews.apache.org/r/43378/diff/
>
>
> Testing
> -------
>
> Verified on a live cluster during Ambari upgrade
> Ran all service checks, which passed
>
>
> Thanks,
>
> Alejandro Fernandez
>
>
Re: Review Request 43378: Ambari Upgrade should not automatically add
stack properties that reference localhost like
dfs.namenode.secondary.http-address, mark with DONT_ADD_ON_UPGRADE
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43378/#review118619
-----------------------------------------------------------
Ship it!
Ship It!
- Andrew Onischuk
On Feb. 9, 2016, 9:49 p.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43378/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2016, 9:49 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Jonathan Hurley, Jayush Luniya, Nate Cole, Srimanth Gunturi, and Sid Wagle.
>
>
> Bugs: AMBARI-14979
> https://issues.apache.org/jira/browse/AMBARI-14979
>
>
> Repository: ambari
>
>
> Description
> -------
>
> STR
>
> * Ambari 2.0.2
> * Added NameNode HA
> * Upgraded to Ambari 2.2.0, which added dfs.namenode.secondary.http-address="localhost:50090"
>
> This is an example of how Ambari upgrade should not be modifying stack properties.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/configuration/accumulo-site.xml 2e75768
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/application-properties.xml 74b1537
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-startup.properties.xml 66a297c
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/configuration/hbase-site.xml 4fefb1e
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/core-site.xml 4d73250
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hdfs-site.xml ea5514d
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-site.xml 80da3a1
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/webhcat-site.xml 72a5710
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/configuration/kafka-broker.xml b23075d
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/ranger-knox-plugin-properties.xml 0ab649c
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/configuration/oozie-site.xml 5a18875
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.3/configuration/oozie-site.xml 2ecc0ca
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/ranger-env.xml 0cffae0
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-site.xml 889e310
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-site.xml 4719dbb
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration-mapred/mapred-site.xml 5737c4d
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration/yarn-site.xml 802a1f5
> ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml aad9ba5
> ambari-server/src/main/resources/stacks/HDP/2.1/services/OOZIE/configuration/oozie-site.xml af1a0a8
> ambari-server/src/main/resources/stacks/HDP/2.1/services/YARN/configuration/yarn-site.xml 667c374
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HBASE/configuration/ranger-hbase-plugin-properties.xml 4e87151
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/ranger-hdfs-plugin-properties.xml 8bb6369
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-site.xml 35db348
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/ranger-hive-plugin-properties.xml a9ceb29
> ambari-server/src/main/resources/stacks/HDP/2.2/services/STORM/configuration/ranger-storm-plugin-properties.xml ef07f4f
> ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/configuration/yarn-site.xml e75442f
> ambari-server/src/main/resources/stacks/HDP/2.3/services/KAFKA/configuration/kafka-broker.xml 8c2f34a
> ambari-server/src/main/resources/stacks/HDP/2.3/services/KAFKA/configuration/ranger-kafka-plugin-properties.xml 490e059
> ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-env.xml 1e86e7d
> ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/storm-site.xml ca6d2b6
>
> Diff: https://reviews.apache.org/r/43378/diff/
>
>
> Testing
> -------
>
> Verified on a live cluster during Ambari upgrade
> Ran all service checks, which passed
>
>
> Thanks,
>
> Alejandro Fernandez
>
>
Re: Review Request 43378: Ambari Upgrade should not automatically add
stack properties that reference localhost like
dfs.namenode.secondary.http-address, mark with DONT_ADD_ON_UPGRADE
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43378/#review118686
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On Feb. 9, 2016, 11:49 p.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43378/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2016, 11:49 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Jonathan Hurley, Jayush Luniya, Nate Cole, Srimanth Gunturi, and Sid Wagle.
>
>
> Bugs: AMBARI-14979
> https://issues.apache.org/jira/browse/AMBARI-14979
>
>
> Repository: ambari
>
>
> Description
> -------
>
> STR
>
> * Ambari 2.0.2
> * Added NameNode HA
> * Upgraded to Ambari 2.2.0, which added dfs.namenode.secondary.http-address="localhost:50090"
>
> This is an example of how Ambari upgrade should not be modifying stack properties.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/configuration/accumulo-site.xml 2e75768
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/application-properties.xml 74b1537
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-startup.properties.xml 66a297c
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/configuration/hbase-site.xml 4fefb1e
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/core-site.xml 4d73250
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hdfs-site.xml ea5514d
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-site.xml 80da3a1
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/webhcat-site.xml 72a5710
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/configuration/kafka-broker.xml b23075d
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/ranger-knox-plugin-properties.xml 0ab649c
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/configuration/oozie-site.xml 5a18875
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.3/configuration/oozie-site.xml 2ecc0ca
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/ranger-env.xml 0cffae0
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-site.xml 889e310
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-site.xml 4719dbb
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration-mapred/mapred-site.xml 5737c4d
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration/yarn-site.xml 802a1f5
> ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml aad9ba5
> ambari-server/src/main/resources/stacks/HDP/2.1/services/OOZIE/configuration/oozie-site.xml af1a0a8
> ambari-server/src/main/resources/stacks/HDP/2.1/services/YARN/configuration/yarn-site.xml 667c374
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HBASE/configuration/ranger-hbase-plugin-properties.xml 4e87151
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/ranger-hdfs-plugin-properties.xml 8bb6369
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-site.xml 35db348
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/ranger-hive-plugin-properties.xml a9ceb29
> ambari-server/src/main/resources/stacks/HDP/2.2/services/STORM/configuration/ranger-storm-plugin-properties.xml ef07f4f
> ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/configuration/yarn-site.xml e75442f
> ambari-server/src/main/resources/stacks/HDP/2.3/services/KAFKA/configuration/kafka-broker.xml 8c2f34a
> ambari-server/src/main/resources/stacks/HDP/2.3/services/KAFKA/configuration/ranger-kafka-plugin-properties.xml 490e059
> ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-env.xml 1e86e7d
> ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/storm-site.xml ca6d2b6
>
> Diff: https://reviews.apache.org/r/43378/diff/
>
>
> Testing
> -------
>
> Verified on a live cluster during Ambari upgrade
> Ran all service checks, which passed
>
>
> Thanks,
>
> Alejandro Fernandez
>
>
Re: Review Request 43378: Ambari Upgrade should not automatically add
stack properties that reference localhost like
dfs.namenode.secondary.http-address, mark with DONT_ADD_ON_UPGRADE
Posted by Alejandro Fernandez <af...@hortonworks.com>.
> On Feb. 9, 2016, 11:51 p.m., Andrew Onischuk wrote:
> > Ok this looks good to me.
> >
> > But one quick question why do we need those properties with values in the first place.
> > Maybe it's better to simply delete a value from them if we don't use it.
> >
> > Example of property without value:
> > <property>
> > <name>hive.server2.authentication.ldap.baseDN</name>
> > <!-- actually not needed <property-type>DONT_ADD_ON_UPGRADE</property-type> -->
> > <value-attributes>
> > <empty-value-valid>true</empty-value-valid>
> > </value-attributes>
> > <depends-on>
> > <property>
> > <type>hive-site</type>
> > <name>hive.server2.authentication</name>
> > </property>
> > </depends-on>
> > </property>
> >
> > Adding a property without default value will cause upgrade and blueprints not to add it by default.
Good question.
Seems like there are some properties whose value can legitimately be null as opposed to "", such as the one you described above.
In other cases, we do not even add the add the property at all, such as dfs.namenode.secondary.http-address
The *-site.xml files especially have a lot of properties whose default value includes "localhost" and then it is up to stack advisor and the UI to replace the value.
In these cases, we don't ever want to add the property on an Ambari upgrade. I created an internal Jira for us not to automatically add stack properties on Ambari upgrade since in many cases it has led to bugs. In the past, it may have been easier at the time.
- Alejandro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43378/#review118501
-----------------------------------------------------------
On Feb. 9, 2016, 9:49 p.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43378/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2016, 9:49 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Jonathan Hurley, Jayush Luniya, Nate Cole, Srimanth Gunturi, and Sid Wagle.
>
>
> Bugs: AMBARI-14979
> https://issues.apache.org/jira/browse/AMBARI-14979
>
>
> Repository: ambari
>
>
> Description
> -------
>
> STR
>
> * Ambari 2.0.2
> * Added NameNode HA
> * Upgraded to Ambari 2.2.0, which added dfs.namenode.secondary.http-address="localhost:50090"
>
> This is an example of how Ambari upgrade should not be modifying stack properties.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/configuration/accumulo-site.xml 2e75768
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/application-properties.xml 74b1537
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-startup.properties.xml 66a297c
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/configuration/hbase-site.xml 4fefb1e
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/core-site.xml 4d73250
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hdfs-site.xml ea5514d
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-site.xml 80da3a1
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/webhcat-site.xml 72a5710
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/configuration/kafka-broker.xml b23075d
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/ranger-knox-plugin-properties.xml 0ab649c
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/configuration/oozie-site.xml 5a18875
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.3/configuration/oozie-site.xml 2ecc0ca
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/ranger-env.xml 0cffae0
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-site.xml 889e310
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-site.xml 4719dbb
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration-mapred/mapred-site.xml 5737c4d
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration/yarn-site.xml 802a1f5
> ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml aad9ba5
> ambari-server/src/main/resources/stacks/HDP/2.1/services/OOZIE/configuration/oozie-site.xml af1a0a8
> ambari-server/src/main/resources/stacks/HDP/2.1/services/YARN/configuration/yarn-site.xml 667c374
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HBASE/configuration/ranger-hbase-plugin-properties.xml 4e87151
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/ranger-hdfs-plugin-properties.xml 8bb6369
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-site.xml 35db348
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/ranger-hive-plugin-properties.xml a9ceb29
> ambari-server/src/main/resources/stacks/HDP/2.2/services/STORM/configuration/ranger-storm-plugin-properties.xml ef07f4f
> ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/configuration/yarn-site.xml e75442f
> ambari-server/src/main/resources/stacks/HDP/2.3/services/KAFKA/configuration/kafka-broker.xml 8c2f34a
> ambari-server/src/main/resources/stacks/HDP/2.3/services/KAFKA/configuration/ranger-kafka-plugin-properties.xml 490e059
> ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-env.xml 1e86e7d
> ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/storm-site.xml ca6d2b6
>
> Diff: https://reviews.apache.org/r/43378/diff/
>
>
> Testing
> -------
>
> Verified on a live cluster during Ambari upgrade
> Ran all service checks, which passed
>
>
> Thanks,
>
> Alejandro Fernandez
>
>
Re: Review Request 43378: Ambari Upgrade should not automatically add
stack properties that reference localhost like
dfs.namenode.secondary.http-address, mark with DONT_ADD_ON_UPGRADE
Posted by Andrew Onischuk <ao...@hortonworks.com>.
> On Feb. 9, 2016, 11:51 p.m., Andrew Onischuk wrote:
> > Ok this looks good to me.
> >
> > But one quick question why do we need those properties with values in the first place.
> > Maybe it's better to simply delete a value from them if we don't use it.
> >
> > Example of property without value:
> > <property>
> > <name>hive.server2.authentication.ldap.baseDN</name>
> > <!-- actually not needed <property-type>DONT_ADD_ON_UPGRADE</property-type> -->
> > <value-attributes>
> > <empty-value-valid>true</empty-value-valid>
> > </value-attributes>
> > <depends-on>
> > <property>
> > <type>hive-site</type>
> > <name>hive.server2.authentication</name>
> > </property>
> > </depends-on>
> > </property>
> >
> > Adding a property without default value will cause upgrade and blueprints not to add it by default.
>
> Alejandro Fernandez wrote:
> Good question.
> Seems like there are some properties whose value can legitimately be null as opposed to "", such as the one you described above.
>
> In other cases, we do not even add the add the property at all, such as dfs.namenode.secondary.http-address
> The *-site.xml files especially have a lot of properties whose default value includes "localhost" and then it is up to stack advisor and the UI to replace the value.
> In these cases, we don't ever want to add the property on an Ambari upgrade. I created an internal Jira for us not to automatically add stack properties on Ambari upgrade since in many cases it has led to bugs. In the past, it may have been easier at the time.
Actually properties with null value won't be added on upgrade at all.
Maybe you're right and those values are needed not stack advisor.
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43378/#review118501
-----------------------------------------------------------
On Feb. 9, 2016, 9:49 p.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43378/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2016, 9:49 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Jonathan Hurley, Jayush Luniya, Nate Cole, Srimanth Gunturi, and Sid Wagle.
>
>
> Bugs: AMBARI-14979
> https://issues.apache.org/jira/browse/AMBARI-14979
>
>
> Repository: ambari
>
>
> Description
> -------
>
> STR
>
> * Ambari 2.0.2
> * Added NameNode HA
> * Upgraded to Ambari 2.2.0, which added dfs.namenode.secondary.http-address="localhost:50090"
>
> This is an example of how Ambari upgrade should not be modifying stack properties.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/configuration/accumulo-site.xml 2e75768
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/application-properties.xml 74b1537
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-startup.properties.xml 66a297c
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/configuration/hbase-site.xml 4fefb1e
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/core-site.xml 4d73250
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hdfs-site.xml ea5514d
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-site.xml 80da3a1
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/webhcat-site.xml 72a5710
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/configuration/kafka-broker.xml b23075d
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/ranger-knox-plugin-properties.xml 0ab649c
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/configuration/oozie-site.xml 5a18875
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.3/configuration/oozie-site.xml 2ecc0ca
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/ranger-env.xml 0cffae0
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-site.xml 889e310
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-site.xml 4719dbb
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration-mapred/mapred-site.xml 5737c4d
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration/yarn-site.xml 802a1f5
> ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml aad9ba5
> ambari-server/src/main/resources/stacks/HDP/2.1/services/OOZIE/configuration/oozie-site.xml af1a0a8
> ambari-server/src/main/resources/stacks/HDP/2.1/services/YARN/configuration/yarn-site.xml 667c374
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HBASE/configuration/ranger-hbase-plugin-properties.xml 4e87151
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/ranger-hdfs-plugin-properties.xml 8bb6369
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-site.xml 35db348
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/ranger-hive-plugin-properties.xml a9ceb29
> ambari-server/src/main/resources/stacks/HDP/2.2/services/STORM/configuration/ranger-storm-plugin-properties.xml ef07f4f
> ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/configuration/yarn-site.xml e75442f
> ambari-server/src/main/resources/stacks/HDP/2.3/services/KAFKA/configuration/kafka-broker.xml 8c2f34a
> ambari-server/src/main/resources/stacks/HDP/2.3/services/KAFKA/configuration/ranger-kafka-plugin-properties.xml 490e059
> ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-env.xml 1e86e7d
> ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/storm-site.xml ca6d2b6
>
> Diff: https://reviews.apache.org/r/43378/diff/
>
>
> Testing
> -------
>
> Verified on a live cluster during Ambari upgrade
> Ran all service checks, which passed
>
>
> Thanks,
>
> Alejandro Fernandez
>
>
Re: Review Request 43378: Ambari Upgrade should not automatically add
stack properties that reference localhost like
dfs.namenode.secondary.http-address, mark with DONT_ADD_ON_UPGRADE
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43378/#review118501
-----------------------------------------------------------
Ok this looks good to me.
But one quick question why do we need those properties with values in the first place.
Maybe it's better to simply delete a value from them if we don't use it.
Example of property without value:
<property>
<name>hive.server2.authentication.ldap.baseDN</name>
<!-- actually not needed <property-type>DONT_ADD_ON_UPGRADE</property-type> -->
<value-attributes>
<empty-value-valid>true</empty-value-valid>
</value-attributes>
<depends-on>
<property>
<type>hive-site</type>
<name>hive.server2.authentication</name>
</property>
</depends-on>
</property>
Adding a property without default value will cause upgrade and blueprints not to add it by default.
- Andrew Onischuk
On Feb. 9, 2016, 9:49 p.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43378/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2016, 9:49 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Jonathan Hurley, Jayush Luniya, Nate Cole, Srimanth Gunturi, and Sid Wagle.
>
>
> Bugs: AMBARI-14979
> https://issues.apache.org/jira/browse/AMBARI-14979
>
>
> Repository: ambari
>
>
> Description
> -------
>
> STR
>
> * Ambari 2.0.2
> * Added NameNode HA
> * Upgraded to Ambari 2.2.0, which added dfs.namenode.secondary.http-address="localhost:50090"
>
> This is an example of how Ambari upgrade should not be modifying stack properties.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/configuration/accumulo-site.xml 2e75768
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/application-properties.xml 74b1537
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-startup.properties.xml 66a297c
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/configuration/hbase-site.xml 4fefb1e
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/core-site.xml 4d73250
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hdfs-site.xml ea5514d
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-site.xml 80da3a1
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/webhcat-site.xml 72a5710
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/configuration/kafka-broker.xml b23075d
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/ranger-knox-plugin-properties.xml 0ab649c
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/configuration/oozie-site.xml 5a18875
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.3/configuration/oozie-site.xml 2ecc0ca
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/ranger-env.xml 0cffae0
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-site.xml 889e310
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-site.xml 4719dbb
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration-mapred/mapred-site.xml 5737c4d
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration/yarn-site.xml 802a1f5
> ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml aad9ba5
> ambari-server/src/main/resources/stacks/HDP/2.1/services/OOZIE/configuration/oozie-site.xml af1a0a8
> ambari-server/src/main/resources/stacks/HDP/2.1/services/YARN/configuration/yarn-site.xml 667c374
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HBASE/configuration/ranger-hbase-plugin-properties.xml 4e87151
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/ranger-hdfs-plugin-properties.xml 8bb6369
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-site.xml 35db348
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/ranger-hive-plugin-properties.xml a9ceb29
> ambari-server/src/main/resources/stacks/HDP/2.2/services/STORM/configuration/ranger-storm-plugin-properties.xml ef07f4f
> ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/configuration/yarn-site.xml e75442f
> ambari-server/src/main/resources/stacks/HDP/2.3/services/KAFKA/configuration/kafka-broker.xml 8c2f34a
> ambari-server/src/main/resources/stacks/HDP/2.3/services/KAFKA/configuration/ranger-kafka-plugin-properties.xml 490e059
> ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-env.xml 1e86e7d
> ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/storm-site.xml ca6d2b6
>
> Diff: https://reviews.apache.org/r/43378/diff/
>
>
> Testing
> -------
>
> Verified on a live cluster during Ambari upgrade
> Ran all service checks, which passed
>
>
> Thanks,
>
> Alejandro Fernandez
>
>
Re: Review Request 43378: Ambari Upgrade should not automatically add
stack properties that reference localhost like
dfs.namenode.secondary.http-address, mark with DONT_ADD_ON_UPGRADE
Posted by Alejandro Fernandez <af...@hortonworks.com>.
> On Feb. 10, 2016, 2:47 p.m., Jonathan Hurley wrote:
> > Any change we could renamed this `IGNORE_ON_UPGRADE` instead of `DONT_ADD_ON_UPGRADE` ?
I'd like to defer this for now until we have consensus on whether or not Ambari Upgrades should be automatically adding stack configs.
- Alejandro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43378/#review118659
-----------------------------------------------------------
On Feb. 9, 2016, 9:49 p.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43378/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2016, 9:49 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Jonathan Hurley, Jayush Luniya, Nate Cole, Srimanth Gunturi, and Sid Wagle.
>
>
> Bugs: AMBARI-14979
> https://issues.apache.org/jira/browse/AMBARI-14979
>
>
> Repository: ambari
>
>
> Description
> -------
>
> STR
>
> * Ambari 2.0.2
> * Added NameNode HA
> * Upgraded to Ambari 2.2.0, which added dfs.namenode.secondary.http-address="localhost:50090"
>
> This is an example of how Ambari upgrade should not be modifying stack properties.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/configuration/accumulo-site.xml 2e75768
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/application-properties.xml 74b1537
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-startup.properties.xml 66a297c
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/configuration/hbase-site.xml 4fefb1e
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/core-site.xml 4d73250
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hdfs-site.xml ea5514d
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-site.xml 80da3a1
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/webhcat-site.xml 72a5710
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/configuration/kafka-broker.xml b23075d
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/ranger-knox-plugin-properties.xml 0ab649c
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/configuration/oozie-site.xml 5a18875
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.3/configuration/oozie-site.xml 2ecc0ca
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/ranger-env.xml 0cffae0
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-site.xml 889e310
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-site.xml 4719dbb
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration-mapred/mapred-site.xml 5737c4d
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration/yarn-site.xml 802a1f5
> ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml aad9ba5
> ambari-server/src/main/resources/stacks/HDP/2.1/services/OOZIE/configuration/oozie-site.xml af1a0a8
> ambari-server/src/main/resources/stacks/HDP/2.1/services/YARN/configuration/yarn-site.xml 667c374
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HBASE/configuration/ranger-hbase-plugin-properties.xml 4e87151
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/ranger-hdfs-plugin-properties.xml 8bb6369
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-site.xml 35db348
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/ranger-hive-plugin-properties.xml a9ceb29
> ambari-server/src/main/resources/stacks/HDP/2.2/services/STORM/configuration/ranger-storm-plugin-properties.xml ef07f4f
> ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/configuration/yarn-site.xml e75442f
> ambari-server/src/main/resources/stacks/HDP/2.3/services/KAFKA/configuration/kafka-broker.xml 8c2f34a
> ambari-server/src/main/resources/stacks/HDP/2.3/services/KAFKA/configuration/ranger-kafka-plugin-properties.xml 490e059
> ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-env.xml 1e86e7d
> ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/storm-site.xml ca6d2b6
>
> Diff: https://reviews.apache.org/r/43378/diff/
>
>
> Testing
> -------
>
> Verified on a live cluster during Ambari upgrade
> Ran all service checks, which passed
>
>
> Thanks,
>
> Alejandro Fernandez
>
>
Re: Review Request 43378: Ambari Upgrade should not automatically add
stack properties that reference localhost like
dfs.namenode.secondary.http-address, mark with DONT_ADD_ON_UPGRADE
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43378/#review118659
-----------------------------------------------------------
Ship it!
Any change we could renamed this `IGNORE_ON_UPGRADE` instead of `DONT_ADD_ON_UPGRADE` ?
- Jonathan Hurley
On Feb. 9, 2016, 4:49 p.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43378/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2016, 4:49 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Jonathan Hurley, Jayush Luniya, Nate Cole, Srimanth Gunturi, and Sid Wagle.
>
>
> Bugs: AMBARI-14979
> https://issues.apache.org/jira/browse/AMBARI-14979
>
>
> Repository: ambari
>
>
> Description
> -------
>
> STR
>
> * Ambari 2.0.2
> * Added NameNode HA
> * Upgraded to Ambari 2.2.0, which added dfs.namenode.secondary.http-address="localhost:50090"
>
> This is an example of how Ambari upgrade should not be modifying stack properties.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/configuration/accumulo-site.xml 2e75768
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/application-properties.xml 74b1537
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-startup.properties.xml 66a297c
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/configuration/hbase-site.xml 4fefb1e
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/core-site.xml 4d73250
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hdfs-site.xml ea5514d
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-site.xml 80da3a1
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/webhcat-site.xml 72a5710
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/configuration/kafka-broker.xml b23075d
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/ranger-knox-plugin-properties.xml 0ab649c
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/configuration/oozie-site.xml 5a18875
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.3/configuration/oozie-site.xml 2ecc0ca
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/ranger-env.xml 0cffae0
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-site.xml 889e310
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-site.xml 4719dbb
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration-mapred/mapred-site.xml 5737c4d
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration/yarn-site.xml 802a1f5
> ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml aad9ba5
> ambari-server/src/main/resources/stacks/HDP/2.1/services/OOZIE/configuration/oozie-site.xml af1a0a8
> ambari-server/src/main/resources/stacks/HDP/2.1/services/YARN/configuration/yarn-site.xml 667c374
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HBASE/configuration/ranger-hbase-plugin-properties.xml 4e87151
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/ranger-hdfs-plugin-properties.xml 8bb6369
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-site.xml 35db348
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/ranger-hive-plugin-properties.xml a9ceb29
> ambari-server/src/main/resources/stacks/HDP/2.2/services/STORM/configuration/ranger-storm-plugin-properties.xml ef07f4f
> ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/configuration/yarn-site.xml e75442f
> ambari-server/src/main/resources/stacks/HDP/2.3/services/KAFKA/configuration/kafka-broker.xml 8c2f34a
> ambari-server/src/main/resources/stacks/HDP/2.3/services/KAFKA/configuration/ranger-kafka-plugin-properties.xml 490e059
> ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-env.xml 1e86e7d
> ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/storm-site.xml ca6d2b6
>
> Diff: https://reviews.apache.org/r/43378/diff/
>
>
> Testing
> -------
>
> Verified on a live cluster during Ambari upgrade
> Ran all service checks, which passed
>
>
> Thanks,
>
> Alejandro Fernandez
>
>