You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/06/19 22:54:41 UTC

[GitHub] [fineract] thesmallstar opened a new pull request #1091: Fixes broken build

thesmallstar opened a new pull request #1091:
URL: https://github.com/apache/fineract/pull/1091


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [fineract] vorburger merged pull request #1091: Fixes broken build due to spotless and error-prone

Posted by GitBox <gi...@apache.org>.
vorburger merged pull request #1091:
URL: https://github.com/apache/fineract/pull/1091


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [fineract] percyashu commented on pull request #1091: Fixes broken build due to spotless and error-prone

Posted by GitBox <gi...@apache.org>.
percyashu commented on pull request #1091:
URL: https://github.com/apache/fineract/pull/1091#issuecomment-646905903


   LGTM 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [fineract] percyashu commented on pull request #1091: Fixes broken build due to spotless and error-prone

Posted by GitBox <gi...@apache.org>.
percyashu commented on pull request #1091:
URL: https://github.com/apache/fineract/pull/1091#issuecomment-646900396


   @thesmallstar I think if you fix the current 1 problem, the compileIntegrationTest may yield no violation.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [fineract] thesmallstar commented on pull request #1091: Fixes broken build due to spotless and error-prone

Posted by GitBox <gi...@apache.org>.
thesmallstar commented on pull request #1091:
URL: https://github.com/apache/fineract/pull/1091#issuecomment-646901127


   @percyashu yes :) Let's see what Travis says now.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [fineract] thesmallstar commented on pull request #1091: Fixes broken build

Posted by GitBox <gi...@apache.org>.
thesmallstar commented on pull request #1091:
URL: https://github.com/apache/fineract/pull/1091#issuecomment-646889814


   Error-prone needs a fix, looking into it. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org