You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Ekaterina Dimitrova (Jira)" <ji...@apache.org> on 2020/06/15 22:14:00 UTC

[jira] [Commented] (CASSANDRA-15877) Followup on CASSANDRA-15600

    [ https://issues.apache.org/jira/browse/CASSANDRA-15877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136175#comment-17136175 ] 

Ekaterina Dimitrova commented on CASSANDRA-15877:
-------------------------------------------------

[[branch |https://github.com/ekaterinadimitrova2/cassandra/tree/CASSANDRA-15600-followup]] [[Java8 CI |https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/216/workflows/2e1ae6fe-6b04-4099-a550-8e069cd030cb]] [[Java11 CI |https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/216/workflows/f98e8ecf-8852-43a6-90aa-c3078418cac1]] [[pull request |https://github.com/ekaterinadimitrova2/cassandra/pull/44]]

*Comments on the CI run:*
 - Unit tests Java8
testNoTreesRetainedAfterDifference - org.apache.cassandra.repair.RepairJobTest - failure already presented on trunk, CASSANDRA-15872
 - Unit tests Java11
testTimeout - org.apache.cassandra.net.ConnectionTest - looks unrelated
 - CQLSH tests Java8
test_compression_cql_options - compression_test.TestCompression - looks unrelated
 - DTests Java8
test_restart_node_localhost - pushed_notifications_test.TestPushedNotifications,
test_move_single_node_localhost - pushed_notifications_test.TestPushedNotifications - already on trunk, missed after a patch committed last week, contacted the author
test_disk_balance_after_joining_ring_lcs - disk_balance_test.TestDiskBalance - presented on trunk already
 - DTests Java11
test_speculative_data_request - read_repair_test.TestSpeculativeReadRepair - CASSANDRA-15792
test_restart_node_localhost - pushed_notifications_test.TestPushedNotifications, test_move_single_node_localhost - pushed_notifications_test.TestPushedNotifications - already on trunk, missed after a patch committed last week, contacted the author

*The first commit is the actual patch. The second commit applies our custom CircleCI config and shouldn't be committed! Kept for test purposes.*

 

> Followup on CASSANDRA-15600
> ---------------------------
>
>                 Key: CASSANDRA-15877
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15877
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Feature/Virtual Nodes
>            Reporter: Ekaterina Dimitrova
>            Assignee: Ekaterina Dimitrova
>            Priority: Normal
>             Fix For: 4.0, 4.0-alpha
>
>
> As part of CASSANDRA-15600  generateSplits method replaced the generateRandomTokens for NoReplicationAwareTokenAllocator.  generateSplits should be used also in ReplicationAwareTokenAllocator.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org