You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "henrib (via GitHub)" <gi...@apache.org> on 2025/08/13 14:51:52 UTC
[PR] Get current metadata location from table identifier [iceberg]
henrib opened a new pull request, #13801:
URL: https://github.com/apache/iceberg/pull/13801
- Code & test;
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Get current metadata location from table identifier [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #13801: Get current metadata location from table identifier
URL: https://github.com/apache/iceberg/pull/13801
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Get current metadata location from table identifier [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13801:
URL: https://github.com/apache/iceberg/pull/13801#issuecomment-3387847793
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Get current metadata location from table identifier [iceberg]
Posted by "pvary (via GitHub)" <gi...@apache.org>.
pvary commented on PR #13801:
URL: https://github.com/apache/iceberg/pull/13801#issuecomment-3188091918
I think a more general solution would be better.
Maybe add a new method to the Catalog API?
CC: @gaborkaszab
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Get current metadata location from table identifier [iceberg]
Posted by "henrib (via GitHub)" <gi...@apache.org>.
henrib commented on code in PR #13801:
URL: https://github.com/apache/iceberg/pull/13801#discussion_r2285166533
##########
api/src/main/java/org/apache/iceberg/catalog/Catalog.java:
##########
@@ -325,6 +326,47 @@ default boolean dropTable(TableIdentifier identifier) {
*/
Table loadTable(TableIdentifier identifier);
+ /**
+ * Computes the eTag of a given table.
+ *
+ * <p>This fetches the up-to-date eTag for a given table identifier</p>
+ *
+ * @param identifier the table identifier
+ * @return the eTag as a type 5 uuid or null if the eTag could not be computed
+ */
+ default UUID getTableETag(TableIdentifier identifier) {
Review Comment:
Hi @gaborkaszab,
I was trying to address the comments and derive a way to compute an eTag from the metadata location. The original PR - and I will revert to this - is only meant to address from the HiveCatalog perspective a way to assess staleness of a Table object from a server side perspective. The REST catalog in Hive is embedded and to cache table objects, the initial issue and PR seems like a reasonable ask.
Whether the same idea can be applied broadly or to other catalogs is certainly valid but at this point, it should probably be discussed in its own issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Get current metadata location from table identifier [iceberg]
Posted by "gaborkaszab (via GitHub)" <gi...@apache.org>.
gaborkaszab commented on code in PR #13801:
URL: https://github.com/apache/iceberg/pull/13801#discussion_r2285030317
##########
api/src/main/java/org/apache/iceberg/catalog/Catalog.java:
##########
@@ -325,6 +326,47 @@ default boolean dropTable(TableIdentifier identifier) {
*/
Table loadTable(TableIdentifier identifier);
+ /**
+ * Computes the eTag of a given table.
+ *
+ * <p>This fetches the up-to-date eTag for a given table identifier</p>
+ *
+ * @param identifier the table identifier
+ * @return the eTag as a type 5 uuid or null if the eTag could not be computed
+ */
+ default UUID getTableETag(TableIdentifier identifier) {
Review Comment:
Hi @henrib ,
I've been following this PR and the related issue also, and I see that you introduced some APIs for exposing ETags on the Catalog interface. I think at this point we should discuss the design in general because this goes somewhat against what the relevant proposal has for REST catalog. A [relevant comment](https://github.com/apache/iceberg/issues/13800#issuecomment-3196775991) I left on the issue.
I think I went through the same thought process as you, but in general, when I was designing the same functionality on the REST catalog, I was strongly advised not to expose the ETags to the clients of the catalogs. As opposed to this, the design we went for is that make the caching of tables and the freshness-aware loading to happen seamlessly to the clients and be embedded into the REST Catalog implementation. I believe, a similar implementation for HiveCatalog would also make sense, but for that there might be some pre-requisites to take care. Please check the comment I wrote on the issue, and also [the proposal](https://docs.google.com/document/d/1rnVSP_iv2I47giwfAe-Z3DYhKkKwWCVvCkC9rEvtaLA/edit?tab=t.0#heading=h.5voryi2hj0go) I had for REST catalog.
But in general, Iceberg API changes like this should go through as an [Improvement Proposal](https://iceberg.apache.org/contribute/?h=proposal#apache-iceberg-improvement-proposals) with a design doc, official voting and such.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Get current metadata location from table identifier [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13801:
URL: https://github.com/apache/iceberg/pull/13801#issuecomment-3413318775
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org