You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Kirill Balyasnikov (JIRA)" <ji...@apache.org> on 2008/10/21 12:08:44 UTC
[jira] Created: (WICKET-1883) Refactor some constants in
WebRequestCodingStrategy
Refactor some constants in WebRequestCodingStrategy
---------------------------------------------------
Key: WICKET-1883
URL: https://issues.apache.org/jira/browse/WICKET-1883
Project: Wicket
Issue Type: Wish
Components: wicket
Reporter: Kirill Balyasnikov
Priority: Trivial
I'm new to Wicket but as i see many people would like to hide the fact they are using the framework due to security reasons. At this time wicket expose some of it's internal structure via url's containing "wicket:", "interface" and others. These strings are declared constants in WebRequestCodingStrategy:
public static final String NAME_SPACE = "wicket:";
public static final String INTERFACE_PARAMETER_NAME = NAME_SPACE + "interface";
public static final String BEHAVIOR_ID_PARAMETER_NAME = NAME_SPACE + "behaviorId";
public static final String BOOKMARKABLE_PAGE_PARAMETER_NAME = NAME_SPACE + "bookmarkablePage";
I propose to transform these constants to simple properties like:
setNameSpace()
setInterfaceParameterName()
setBehaviorIdParameterName()
As it seems to me such simple refactoring will not break backward compatibility with previous versions of Wicket.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1883) Refactor some constants in
WebRequestCodingStrategy
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12641424#action_12641424 ]
Igor Vaynberg commented on WICKET-1883:
---------------------------------------
i dont get this, even after you change the constants it is still easy to tell you are using wicket if you have urls like
?foo:bar=:34:path.to.component:::
people who are concerned with security should use crypted url coding strategy to make all their urls look like this
?x=987DASD7ASD7AS9D7AS8AS8AS79SA7D9AS79AS7DAS798S7ASD
> Refactor some constants in WebRequestCodingStrategy
> ---------------------------------------------------
>
> Key: WICKET-1883
> URL: https://issues.apache.org/jira/browse/WICKET-1883
> Project: Wicket
> Issue Type: Wish
> Components: wicket
> Reporter: Kirill Balyasnikov
> Priority: Trivial
>
> I'm new to Wicket but as i see many people would like to hide the fact they are using the framework due to security reasons. At this time wicket expose some of it's internal structure via url's containing "wicket:", "interface" and others. These strings are declared constants in WebRequestCodingStrategy:
> public static final String NAME_SPACE = "wicket:";
> public static final String INTERFACE_PARAMETER_NAME = NAME_SPACE + "interface";
> public static final String BEHAVIOR_ID_PARAMETER_NAME = NAME_SPACE + "behaviorId";
> public static final String BOOKMARKABLE_PAGE_PARAMETER_NAME = NAME_SPACE + "bookmarkablePage";
> I propose to transform these constants to simple properties like:
> setNameSpace()
> setInterfaceParameterName()
> setBehaviorIdParameterName()
> As it seems to me such simple refactoring will not break backward compatibility with previous versions of Wicket.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1883) Refactor some constants in
WebRequestCodingStrategy
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg updated WICKET-1883:
----------------------------------
Fix Version/s: 1.5-M1
the url stuff is changing completely in 1.5 where it will be much more pluggable. lets wait until then to look into this.
> Refactor some constants in WebRequestCodingStrategy
> ---------------------------------------------------
>
> Key: WICKET-1883
> URL: https://issues.apache.org/jira/browse/WICKET-1883
> Project: Wicket
> Issue Type: Wish
> Components: wicket
> Reporter: Kirill Balyasnikov
> Priority: Trivial
> Fix For: 1.5-M1
>
> Attachments: 1883.patch
>
>
> I'm new to Wicket but as i see many people would like to hide the fact they are using the framework due to security reasons. At this time wicket expose some of it's internal structure via url's containing "wicket:", "interface" and others. These strings are declared constants in WebRequestCodingStrategy:
> public static final String NAME_SPACE = "wicket:";
> public static final String INTERFACE_PARAMETER_NAME = NAME_SPACE + "interface";
> public static final String BEHAVIOR_ID_PARAMETER_NAME = NAME_SPACE + "behaviorId";
> public static final String BOOKMARKABLE_PAGE_PARAMETER_NAME = NAME_SPACE + "bookmarkablePage";
> I propose to transform these constants to simple properties like:
> setNameSpace()
> setInterfaceParameterName()
> setBehaviorIdParameterName()
> As it seems to me such simple refactoring will not break backward compatibility with previous versions of Wicket.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-1883) Refactor some constants in
WebRequestCodingStrategy
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg resolved WICKET-1883.
-----------------------------------
Assignee: Igor Vaynberg
Resolution: Invalid
this part of wicket has been rebuilt in 1.5
> Refactor some constants in WebRequestCodingStrategy
> ---------------------------------------------------
>
> Key: WICKET-1883
> URL: https://issues.apache.org/jira/browse/WICKET-1883
> Project: Wicket
> Issue Type: Wish
> Components: wicket
> Reporter: Kirill Balyasnikov
> Assignee: Igor Vaynberg
> Priority: Trivial
> Fix For: 1.5-M2
>
> Attachments: 1883-entire-interface.patch, 1883.patch
>
>
> I'm new to Wicket but as i see many people would like to hide the fact they are using the framework due to security reasons. At this time wicket expose some of it's internal structure via url's containing "wicket:", "interface" and others. These strings are declared constants in WebRequestCodingStrategy:
> public static final String NAME_SPACE = "wicket:";
> public static final String INTERFACE_PARAMETER_NAME = NAME_SPACE + "interface";
> public static final String BEHAVIOR_ID_PARAMETER_NAME = NAME_SPACE + "behaviorId";
> public static final String BOOKMARKABLE_PAGE_PARAMETER_NAME = NAME_SPACE + "bookmarkablePage";
> I propose to transform these constants to simple properties like:
> setNameSpace()
> setInterfaceParameterName()
> setBehaviorIdParameterName()
> As it seems to me such simple refactoring will not break backward compatibility with previous versions of Wicket.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1883) Refactor some constants in
WebRequestCodingStrategy
Posted by "Kirill Balyasnikov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12641452#action_12641452 ]
Kirill Balyasnikov commented on WICKET-1883:
--------------------------------------------
At least average user will not be able to copy "wicket:bookmarkablePage=..." and past it into google to get tons of results.
But i agree, it will not help in case of serious hack investigation.
> Refactor some constants in WebRequestCodingStrategy
> ---------------------------------------------------
>
> Key: WICKET-1883
> URL: https://issues.apache.org/jira/browse/WICKET-1883
> Project: Wicket
> Issue Type: Wish
> Components: wicket
> Reporter: Kirill Balyasnikov
> Priority: Trivial
>
> I'm new to Wicket but as i see many people would like to hide the fact they are using the framework due to security reasons. At this time wicket expose some of it's internal structure via url's containing "wicket:", "interface" and others. These strings are declared constants in WebRequestCodingStrategy:
> public static final String NAME_SPACE = "wicket:";
> public static final String INTERFACE_PARAMETER_NAME = NAME_SPACE + "interface";
> public static final String BEHAVIOR_ID_PARAMETER_NAME = NAME_SPACE + "behaviorId";
> public static final String BOOKMARKABLE_PAGE_PARAMETER_NAME = NAME_SPACE + "bookmarkablePage";
> I propose to transform these constants to simple properties like:
> setNameSpace()
> setInterfaceParameterName()
> setBehaviorIdParameterName()
> As it seems to me such simple refactoring will not break backward compatibility with previous versions of Wicket.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1883) Refactor some constants in
WebRequestCodingStrategy
Posted by "Kirill Balyasnikov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12641439#action_12641439 ]
Kirill Balyasnikov commented on WICKET-1883:
--------------------------------------------
There are constants used only in the code. But these are exposed to the interface in some way (html markup).
Such things should be always configurable i think. But now there is no way to achieve that without copy-pasting
the entire WebRequestCodingStrategy source (not very good practice).
> Refactor some constants in WebRequestCodingStrategy
> ---------------------------------------------------
>
> Key: WICKET-1883
> URL: https://issues.apache.org/jira/browse/WICKET-1883
> Project: Wicket
> Issue Type: Wish
> Components: wicket
> Reporter: Kirill Balyasnikov
> Priority: Trivial
>
> I'm new to Wicket but as i see many people would like to hide the fact they are using the framework due to security reasons. At this time wicket expose some of it's internal structure via url's containing "wicket:", "interface" and others. These strings are declared constants in WebRequestCodingStrategy:
> public static final String NAME_SPACE = "wicket:";
> public static final String INTERFACE_PARAMETER_NAME = NAME_SPACE + "interface";
> public static final String BEHAVIOR_ID_PARAMETER_NAME = NAME_SPACE + "behaviorId";
> public static final String BOOKMARKABLE_PAGE_PARAMETER_NAME = NAME_SPACE + "bookmarkablePage";
> I propose to transform these constants to simple properties like:
> setNameSpace()
> setInterfaceParameterName()
> setBehaviorIdParameterName()
> As it seems to me such simple refactoring will not break backward compatibility with previous versions of Wicket.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1883) Refactor some constants in
WebRequestCodingStrategy
Posted by "Jeremy Thomerson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeremy Thomerson updated WICKET-1883:
-------------------------------------
Attachment: 1883-entire-interface.patch
Here is a patch that extracts all of those constants into a separate interface. Since it touches a lot of internals, it should be given a close look by whoever thinks of submitting it - if it makes it that far. I have done very simple testing with a quickstart, but not extensive.
PS - the patch is against the "wicket" folder or submodule itself.
> Refactor some constants in WebRequestCodingStrategy
> ---------------------------------------------------
>
> Key: WICKET-1883
> URL: https://issues.apache.org/jira/browse/WICKET-1883
> Project: Wicket
> Issue Type: Wish
> Components: wicket
> Reporter: Kirill Balyasnikov
> Priority: Trivial
> Fix For: 1.5-M1
>
> Attachments: 1883-entire-interface.patch, 1883.patch
>
>
> I'm new to Wicket but as i see many people would like to hide the fact they are using the framework due to security reasons. At this time wicket expose some of it's internal structure via url's containing "wicket:", "interface" and others. These strings are declared constants in WebRequestCodingStrategy:
> public static final String NAME_SPACE = "wicket:";
> public static final String INTERFACE_PARAMETER_NAME = NAME_SPACE + "interface";
> public static final String BEHAVIOR_ID_PARAMETER_NAME = NAME_SPACE + "behaviorId";
> public static final String BOOKMARKABLE_PAGE_PARAMETER_NAME = NAME_SPACE + "bookmarkablePage";
> I propose to transform these constants to simple properties like:
> setNameSpace()
> setInterfaceParameterName()
> setBehaviorIdParameterName()
> As it seems to me such simple refactoring will not break backward compatibility with previous versions of Wicket.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (WICKET-1883) Refactor some constants
in WebRequestCodingStrategy
Posted by "Jeremy Thomerson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12645077#action_12645077 ]
jthomerson edited comment on WICKET-1883 at 11/4/08 1:08 PM:
-------------------------------------------------------------------
We could give this a try. It adds a setting in IMarkupSettings that lets you configure the name space to use for URLs. It only covers the namespace - not the other terms. If you wanted to be able to override all of those, you would probably need another I*Settings interface.
was (Author: jthomerson):
We could give this a try. It adds a setting in IMarkupSettings that lets you configure the name space to use for URLs.
> Refactor some constants in WebRequestCodingStrategy
> ---------------------------------------------------
>
> Key: WICKET-1883
> URL: https://issues.apache.org/jira/browse/WICKET-1883
> Project: Wicket
> Issue Type: Wish
> Components: wicket
> Reporter: Kirill Balyasnikov
> Priority: Trivial
> Attachments: 1883.patch
>
>
> I'm new to Wicket but as i see many people would like to hide the fact they are using the framework due to security reasons. At this time wicket expose some of it's internal structure via url's containing "wicket:", "interface" and others. These strings are declared constants in WebRequestCodingStrategy:
> public static final String NAME_SPACE = "wicket:";
> public static final String INTERFACE_PARAMETER_NAME = NAME_SPACE + "interface";
> public static final String BEHAVIOR_ID_PARAMETER_NAME = NAME_SPACE + "behaviorId";
> public static final String BOOKMARKABLE_PAGE_PARAMETER_NAME = NAME_SPACE + "bookmarkablePage";
> I propose to transform these constants to simple properties like:
> setNameSpace()
> setInterfaceParameterName()
> setBehaviorIdParameterName()
> As it seems to me such simple refactoring will not break backward compatibility with previous versions of Wicket.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1883) Refactor some constants in
WebRequestCodingStrategy
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12641447#action_12641447 ]
Igor Vaynberg commented on WICKET-1883:
---------------------------------------
i agree they should be configurable, just not for purposes of security because it doesnt help.
> Refactor some constants in WebRequestCodingStrategy
> ---------------------------------------------------
>
> Key: WICKET-1883
> URL: https://issues.apache.org/jira/browse/WICKET-1883
> Project: Wicket
> Issue Type: Wish
> Components: wicket
> Reporter: Kirill Balyasnikov
> Priority: Trivial
>
> I'm new to Wicket but as i see many people would like to hide the fact they are using the framework due to security reasons. At this time wicket expose some of it's internal structure via url's containing "wicket:", "interface" and others. These strings are declared constants in WebRequestCodingStrategy:
> public static final String NAME_SPACE = "wicket:";
> public static final String INTERFACE_PARAMETER_NAME = NAME_SPACE + "interface";
> public static final String BEHAVIOR_ID_PARAMETER_NAME = NAME_SPACE + "behaviorId";
> public static final String BOOKMARKABLE_PAGE_PARAMETER_NAME = NAME_SPACE + "bookmarkablePage";
> I propose to transform these constants to simple properties like:
> setNameSpace()
> setInterfaceParameterName()
> setBehaviorIdParameterName()
> As it seems to me such simple refactoring will not break backward compatibility with previous versions of Wicket.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1883) Refactor some constants in
WebRequestCodingStrategy
Posted by "Jeremy Thomerson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeremy Thomerson updated WICKET-1883:
-------------------------------------
Attachment: 1883.patch
We could give this a try. It adds a setting in IMarkupSettings that lets you configure the name space to use for URLs.
> Refactor some constants in WebRequestCodingStrategy
> ---------------------------------------------------
>
> Key: WICKET-1883
> URL: https://issues.apache.org/jira/browse/WICKET-1883
> Project: Wicket
> Issue Type: Wish
> Components: wicket
> Reporter: Kirill Balyasnikov
> Priority: Trivial
> Attachments: 1883.patch
>
>
> I'm new to Wicket but as i see many people would like to hide the fact they are using the framework due to security reasons. At this time wicket expose some of it's internal structure via url's containing "wicket:", "interface" and others. These strings are declared constants in WebRequestCodingStrategy:
> public static final String NAME_SPACE = "wicket:";
> public static final String INTERFACE_PARAMETER_NAME = NAME_SPACE + "interface";
> public static final String BEHAVIOR_ID_PARAMETER_NAME = NAME_SPACE + "behaviorId";
> public static final String BOOKMARKABLE_PAGE_PARAMETER_NAME = NAME_SPACE + "bookmarkablePage";
> I propose to transform these constants to simple properties like:
> setNameSpace()
> setInterfaceParameterName()
> setBehaviorIdParameterName()
> As it seems to me such simple refactoring will not break backward compatibility with previous versions of Wicket.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1883) Refactor some constants in
WebRequestCodingStrategy
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg updated WICKET-1883:
----------------------------------
Fix Version/s: 1.5-M2
(was: 1.5-M1)
> Refactor some constants in WebRequestCodingStrategy
> ---------------------------------------------------
>
> Key: WICKET-1883
> URL: https://issues.apache.org/jira/browse/WICKET-1883
> Project: Wicket
> Issue Type: Wish
> Components: wicket
> Reporter: Kirill Balyasnikov
> Priority: Trivial
> Fix For: 1.5-M2
>
> Attachments: 1883-entire-interface.patch, 1883.patch
>
>
> I'm new to Wicket but as i see many people would like to hide the fact they are using the framework due to security reasons. At this time wicket expose some of it's internal structure via url's containing "wicket:", "interface" and others. These strings are declared constants in WebRequestCodingStrategy:
> public static final String NAME_SPACE = "wicket:";
> public static final String INTERFACE_PARAMETER_NAME = NAME_SPACE + "interface";
> public static final String BEHAVIOR_ID_PARAMETER_NAME = NAME_SPACE + "behaviorId";
> public static final String BOOKMARKABLE_PAGE_PARAMETER_NAME = NAME_SPACE + "bookmarkablePage";
> I propose to transform these constants to simple properties like:
> setNameSpace()
> setInterfaceParameterName()
> setBehaviorIdParameterName()
> As it seems to me such simple refactoring will not break backward compatibility with previous versions of Wicket.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.