You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/01/18 14:54:58 UTC
[GitHub] [camel] jamesnetherton opened a new pull request #6779: CAMEL-17426: Prevent MicroProfile Health conflicting health data
jamesnetherton opened a new pull request #6779:
URL: https://github.com/apache/camel/pull/6779
I reworked MP health so that it now depends on SmallRye Health & registers camel checks with the relevant liveness or readiness registry. That way each check can write its own details content and not have the chance to overwrite detail coming from other checks.
To avoid generating a very verbose health output (E.g if there many routes configured), I made the results of the routes and consumers checks to be an aggregated one. And only report the first failure encountered on the occurrence of errors. E.g:
```json
{
"status": "DOWN",
"checks": [
{
"name": "camel-routes",
"status": "UP"
},
{
"name": "context",
"status": "UP",
"data": {
"context.name": "camel-example",
"context.version": "3.15.0-SNAPSHOT",
"context.status": "Started"
}
},
{
"name": "camel-consumers",
"status": "DOWN"
"data": {
"failure.endpoint.uri": "foo:bar?option=value",
"failure.error.count": "1",
"error.message": "the error message",
"error.stacktrace": "the stack trace"
}
},
]
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] jamesnetherton edited a comment on pull request #6779: CAMEL-17426: Prevent MicroProfile Health conflicting health data
Posted by GitBox <gi...@apache.org>.
jamesnetherton edited a comment on pull request #6779:
URL: https://github.com/apache/camel/pull/6779#issuecomment-1015531508
> I could see the case where the user checks the error, fixes it, then expect her/his application to run, but realises another error gets reported
True... and this is pretty much a continuation of what happened before where all Camel health check results were aggregated.
> I realise that may not be trivial to report the list of errors, but that's not impossible :)
If SmallRye Health made it possible to structure the values of the `data` element, then you could report additional error elements pretty easily (E.g as maps or arrays). But that's not currently possible.
So I guess you're left with the options of either combining & delimiting all of the error data in a single string (not great for human readability) or not aggregating the results of the routes / consumers checks (which I'd prefer to avoid due to the potential verbosity of reporting them as individual items).
Or have additional data elements like `<health-check-id>.error.message` & `<health-check-id>.error.message`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] jamesnetherton commented on pull request #6779: CAMEL-17426: Prevent MicroProfile Health conflicting health data
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on pull request #6779:
URL: https://github.com/apache/camel/pull/6779#issuecomment-1015531508
> I could see the case where the user checks the error, fixes it, then expect her/his application to run, but realises another error gets reported
True... and this is pretty much a continuation of what happened before where all Camel health check results were aggregated.
> I realise that may not be trivial to report the list of errors, but that's not impossible :)
If SmallRye Health made it possible to structure the values of the `data` element, then you could report additional error elements pretty easily (E.g as maps or arrays). But that's not currently possible.
So I guess you're left with the options of either combining & delimiting all of the error data in a single string (not great for human readability) or not aggregating the results of the routes / consumers checks (which I'd prefer to avoid due to the potential verbosity of reporting them as individual items).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] jamesnetherton edited a comment on pull request #6779: CAMEL-17426: Prevent MicroProfile Health conflicting health data
Posted by GitBox <gi...@apache.org>.
jamesnetherton edited a comment on pull request #6779:
URL: https://github.com/apache/camel/pull/6779#issuecomment-1015531508
> I could see the case where the user checks the error, fixes it, then expect her/his application to run, but realises another error gets reported
True... and this is pretty much a continuation of what happened before where all Camel health check results were aggregated.
> I realise that may not be trivial to report the list of errors, but that's not impossible :)
If SmallRye Health made it possible to structure the values of the `data` element, then you could report additional error elements pretty easily (E.g as maps or arrays). But that's not currently possible.
So I guess you're left with the options of either combining & delimiting all of the error data in a single string (not great for human readability) or not aggregating the results of the routes / consumers checks (which I'd prefer to avoid due to the potential verbosity of reporting them as individual items).
Or have additional data elements like `<health-check-id>.error.message` & `<health-check-id>.error.stacktrace`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] astefanutti commented on pull request #6779: CAMEL-17426: Prevent MicroProfile Health conflicting health data
Posted by GitBox <gi...@apache.org>.
astefanutti commented on pull request #6779:
URL: https://github.com/apache/camel/pull/6779#issuecomment-1015620642
> So I guess you're left with the options of either combining & delimiting all of the error data in a single string (not great for human readability) or not aggregating the results of the routes / consumers checks (which I'd prefer to avoid due to the potential verbosity of reporting them as individual items).
I think the output is more meant to be processed by clients like a GUI or an operator, rather than consumed by humans. We, developers, consume it, but I think that's because we are developers, even if we also happen to be human beings :).
> Or have additional data elements like `<health-check-id>.error.message` & `<health-check-id>.error.stacktrace`.
That is what I was thinking, or like `error.message[health-check-id]`.
The first point we would need to address is whether we go for individual or aggregated results. Anyway, this PR is already a great improvement over the current format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] jamesnetherton merged pull request #6779: CAMEL-17426: Prevent MicroProfile Health conflicting health data
Posted by GitBox <gi...@apache.org>.
jamesnetherton merged pull request #6779:
URL: https://github.com/apache/camel/pull/6779
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] astefanutti edited a comment on pull request #6779: CAMEL-17426: Prevent MicroProfile Health conflicting health data
Posted by GitBox <gi...@apache.org>.
astefanutti edited a comment on pull request #6779:
URL: https://github.com/apache/camel/pull/6779#issuecomment-1015518666
Is it OK for users that only the first error gets reported? I could see the case where the user checks the error, fixes it, then expect her/his application to run, but realises another error gets reported?
I realise that may not be trivial to report the list of errors, but that's not impossible :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] astefanutti commented on pull request #6779: CAMEL-17426: Prevent MicroProfile Health conflicting health data
Posted by GitBox <gi...@apache.org>.
astefanutti commented on pull request #6779:
URL: https://github.com/apache/camel/pull/6779#issuecomment-1015518666
Is it OK for users that only the first error gets reported? I could see the case where the user checks the error, fixes it, then expect her/his application to run, but realise another error gets reported?
I realise that may not be trivial to report the list of errors, but that's not impossible :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org