You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by fgiorgetti <gi...@git.apache.org> on 2018/08/03 12:50:08 UTC
[GitHub] qpid-dispatch pull request #352: DISPATCH-1095 - Only adding SASL listener w...
GitHub user fgiorgetti opened a pull request:
https://github.com/apache/qpid-dispatch/pull/352
DISPATCH-1095 - Only adding SASL listener when SASL available
This might resolve the tearDown issue when SASL is not available.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/fgiorgetti/qpid-dispatch fgiorgetti-DISPATCH-1095-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-dispatch/pull/352.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #352
----
commit 2c8adb848cdc965bc13104c471ec2c8d51d2a45a
Author: Fernando Giorgetti <fg...@...>
Date: 2018-08-03T12:47:28Z
DISPATCH-1095 - Only adding SASL listener when SASL available
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch issue #352: DISPATCH-1095 - Only adding SASL listener when SAS...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/qpid-dispatch/pull/352
# [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/352?src=pr&el=h1) Report
> Merging [#352](https://codecov.io/gh/apache/qpid-dispatch/pull/352?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/a1585a9c3f3f5ed2aa34c7b95c357256aa9e534a?src=pr&el=desc) will **increase** coverage by `0.04%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/352?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #352 +/- ##
==========================================
+ Coverage 84.46% 84.51% +0.04%
==========================================
Files 69 69
Lines 15677 15675 -2
==========================================
+ Hits 13241 13247 +6
+ Misses 2436 2428 -8
```
| [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/352?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/352/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `94.51% <0%> (+0.14%)` | :arrow_up: |
| [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/352/diff?src=pr&el=tree#diff-c3JjL21lc3NhZ2UuYw==) | `87.63% <0%> (+0.18%)` | :arrow_up: |
| [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/352/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `95.42% <0%> (+0.22%)` | :arrow_up: |
| [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/352/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `90.56% <0%> (+0.45%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/352?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/352?src=pr&el=footer). Last update [a1585a9...ec274e3](https://codecov.io/gh/apache/qpid-dispatch/pull/352?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch pull request #352: DISPATCH-1095 - Only adding SASL listener w...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/qpid-dispatch/pull/352
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org