[jira] [Commented] (SENTRY-1831) The MetastorePlugin SyncTask is leaking connection threads when read timed out issues are thrown

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SENTRY-1831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16081170#comment-16081170 ] 

Hadoop QA commented on SENTRY-1831:
-----------------------------------

Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12876481/SENTRY-1831.001.patch against master.

{color:green}Overall:{color} +1 all checks pass

{color:green}SUCCESS:{color} all tests passed

Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/2978/console

This message is automatically generated.

> The MetastorePlugin SyncTask is leaking connection threads when read timed out issues are thrown
> ------------------------------------------------------------------------------------------------
>
>                 Key: SENTRY-1831
>                 URL: https://issues.apache.org/jira/browse/SENTRY-1831
>             Project: Sentry
>          Issue Type: Bug
>          Components: Sentry
>    Affects Versions: 1.8.0
>            Reporter: Arjun Mishra
>            Assignee: Arjun Mishra
>             Fix For: 1.8.0
>
>         Attachments: SENTRY-1831.001.patch
>
>
> The MetastorePlugin.SyncTask class is a thread running in the background in the HMS side that is used to keep HMS/Sentry in sync with HDFS, or any other words, it pushes a full HMS snapshot to Sentry every time Sentry is out-of-sync. 
> However when a timed out exception is thrown when sending the snapshot to Sentry, a retry happens in the next thread run() iteration. 
> The problem is that these exceptions do not terminate the Thrift thread sending the data, and a new retry will generate a new Thrift thread be created. We should close those threads by resetting the connection when an error occurs.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)