You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/04/11 15:07:16 UTC
[GitHub] [arrow] kiszk opened a new pull request #9985: ARROW-12330: [Developer] Restore values at counters column of Archery benchmark
kiszk opened a new pull request #9985:
URL: https://github.com/apache/arrow/pull/9985
This PR restores values at `counters` column of Archery benchmark. #9140 always suppressed values at `counters` column regardless `--no-counter`. In addition, this PR stores `counters` value into json file.
Before
```
% archery benchmark diff --benchmark-filter="SetBitsTo" --output=head2.json HEAD HEAD~1
...
---------------------------------------------------------------------------
Benchmark Time CPU Iterations UserCounters...
---------------------------------------------------------------------------
SetBitsTo/2 8.15 ns 8.15 ns 81991087 bytes_per_second=234.044M/s
SetBitsTo/16 7.78 ns 7.78 ns 89928878 bytes_per_second=1.91429G/s
SetBitsTo/1024 13.9 ns 13.9 ns 50372172 bytes_per_second=68.6182G/s
SetBitsTo/131072 3508 ns 3508 ns 199335 bytes_per_second=34.7944G/s
----------------------------------------------------------------------
Non-regressions: (4)
----------------------------------------------------------------------
benchmark baseline contender change % counters
SetBitsTo/16 1.877 GiB/sec 1.914 GiB/sec 1.975 {}
SetBitsTo/2 230.566 MiB/sec 234.044 MiB/sec 1.509 {}
SetBitsTo/131072 34.722 GiB/sec 34.794 GiB/sec 0.207 {}
SetBitsTo/1024 68.593 GiB/sec 68.618 GiB/sec 0.037 {}
```
After
```
---------------------------------------------------------------------------
Benchmark Time CPU Iterations UserCounters...
---------------------------------------------------------------------------
SetBitsTo/2 8.39 ns 8.39 ns 81980047 bytes_per_second=227.438M/s
SetBitsTo/16 7.88 ns 7.88 ns 84936624 bytes_per_second=1.89105G/s
SetBitsTo/1024 13.9 ns 13.9 ns 50376587 bytes_per_second=68.6064G/s
SetBitsTo/131072 3513 ns 3513 ns 200598 bytes_per_second=34.7447G/s
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Non-regressions: (4)
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
benchmark baseline contender change % counters
SetBitsTo/2 227.438 MiB/sec 235.984 MiB/sec 3.757 {'run_name': 'SetBitsTo/2', 'repetitions': 0, 'repetition_index': 0, 'threads': 1, 'iterations': 81980047}
SetBitsTo/16 1.891 GiB/sec 1.913 GiB/sec 1.137 {'run_name': 'SetBitsTo/16', 'repetitions': 0, 'repetition_index': 0, 'threads': 1, 'iterations': 84936624}
SetBitsTo/131072 34.745 GiB/sec 34.771 GiB/sec 0.075 {'run_name': 'SetBitsTo/131072', 'repetitions': 0, 'repetition_index': 0, 'threads': 1, 'iterations': 200598}
SetBitsTo/1024 68.606 GiB/sec 68.624 GiB/sec 0.026 {'run_name': 'SetBitsTo/1024', 'repetitions': 0, 'repetition_index': 0, 'threads': 1, 'iterations': 50376587}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kiszk commented on pull request #9985: ARROW-12330: [Developer] Restore values at counters column of Archery benchmark
Posted by GitBox <gi...@apache.org>.
kiszk commented on pull request #9985:
URL: https://github.com/apache/arrow/pull/9985#issuecomment-818651310
Of course, I will fix it in a few days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs closed pull request #9985: ARROW-12330: [Developer] Restore values at counters column of Archery benchmark
Posted by GitBox <gi...@apache.org>.
kszucs closed pull request #9985:
URL: https://github.com/apache/arrow/pull/9985
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9985: ARROW-12330: [Developer] Restore values at counters column of Archery benchmark
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9985:
URL: https://github.com/apache/arrow/pull/9985#issuecomment-817322813
https://issues.apache.org/jira/browse/ARROW-12330
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #9985: ARROW-12330: [Developer] Restore values at counters column of Archery benchmark
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #9985:
URL: https://github.com/apache/arrow/pull/9985#issuecomment-818642397
@kiszk thanks for working on this! Could you please fix the archery unittests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org