You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2018/01/18 03:54:29 UTC

[GitHub] vongosling commented on a change in pull request #219: [ROCKETMQ-355] Client asyncSend is not fully async

vongosling commented on a change in pull request #219: [ROCKETMQ-355] Client asyncSend is not fully async
URL: https://github.com/apache/rocketmq/pull/219#discussion_r162241195
 
 

 ##########
 File path: client/src/main/java/org/apache/rocketmq/client/producer/MQProducer.java
 ##########
 @@ -70,12 +66,10 @@ SendResult send(final Message msg, final MessageQueueSelector selector, final Ob
         InterruptedException;
 
     void send(final Message msg, final MessageQueueSelector selector, final Object arg,
 
 Review comment:
   How do we keep backward compatibility?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services