[jira] [Commented] (SAMZA-93) Gradle check task should fail the build if license headers are missing

["David Chen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SAMZA-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14309475#comment-14309475 ] 

David Chen commented on SAMZA-93:
---------------------------------

Thanks! Sorry, had some merge issues and missed the Eclipse case since I don't use Eclipse. Added a new patch that fixes these issues and verified by running ./gradlew build after generating Eclipse and IntelliJ project files.

> Gradle check task should fail the build if license headers are missing
> ----------------------------------------------------------------------
>
>                 Key: SAMZA-93
>                 URL: https://issues.apache.org/jira/browse/SAMZA-93
>             Project: Samza
>          Issue Type: Improvement
>            Reporter: Jakob Homan
>            Assignee: David Chen
>            Priority: Minor
>         Attachments: SAMZA-93.0.patch, SAMZA-93.1.patch, SAMZA-93.2.patch
>
>
> Right now the gradle check task logs a warning for files without license headers, but it should fail the build.  Also, committers should be sure to run check before committing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)