You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "jens-scheffler-bosch (via GitHub)" <gi...@apache.org> on 2023/08/08 22:08:45 UTC

[GitHub] [airflow] jens-scheffler-bosch commented on a diff in pull request #33017: Allow PythonVenvOperator using other index url

jens-scheffler-bosch commented on code in PR #33017:
URL: https://github.com/apache/airflow/pull/33017#discussion_r1287732382


##########
airflow/operators/python.py:
##########
@@ -528,6 +537,9 @@ def __init__(
         templates_exts: list[str] | None = None,
         expect_airflow: bool = True,
         skip_on_exit_code: int | Container[int] | None = None,
+        index_urls: None | Collection[str] | str = None,
+        cache_venv: bool = False,
+        cache_path: str = "/tmp",

Review Comment:
   As proposed I separated-out the caching option, a separate PR is made for this. As it builds-on top of small re-structuring (would not call it re-factoring :-D) I made a PR to _this_ feature branch. Target merge directory of the other PR would need to be switched to apache/airflow:main post merging this PR:
   
   https://github.com/boschglobal/airflow/pull/2



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org