[GitHub] [iotdb] wangchao316 commented on a change in pull request #5347: [IOTDB-2780] Config node ratis consensus protocol implementation

[GitBox <gi...@apache.org>]

wangchao316 commented on a change in pull request #5347:
URL: https://github.com/apache/iotdb/pull/5347#discussion_r835832674



##########
File path: confignode/src/main/java/org/apache/iotdb/confignode/manager/ConfigManager.java
##########
@@ -48,36 +52,34 @@
 public class ConfigManager {
 
   private static final Logger LOGGER = LoggerFactory.getLogger(ConfigManager.class);
+  private static final ConfigNodeConf conf = ConfigNodeDescriptor.getInstance().getConf();
 
   private IConsensus consensusImpl;
   private ConsensusGroupId consensusGroupId;
 
   private DeviceGroupHashExecutor hashExecutor;
 
-  @TestOnly
-  public ConfigManager(String hashExecutorClass, int deviceGroupCount) {
-    setHashExecutor(hashExecutorClass, deviceGroupCount);

Review comment:
       why delete?  we need only  test configManager.  

##########
File path: confignode/src/assembly/resources/conf/iotdb-confignode.properties
##########
@@ -104,6 +117,19 @@ config_node_rpc_port=22277
 # If its prefix is "/", then the path is absolute. Otherwise, it is relative.
 # data_dirs=data/data
 
+
+# consensus dir
+# If this property is unset, system will save the data in the default relative path directory under the confignode folder(i.e., %CONFIGNODE_HOME%/data/consensus).
+# If it is absolute, system will save the data in exact location it points to.
+# If it is relative, system will save the data in the relative path directory it indicates under the confignode folder.
+# Note: If data_dir is assigned an empty string(i.e.,zero-size), it will be handled as a relative path.
+# For windows platform
+# If its prefix is a drive specifier followed by "\\", or if its prefix is "\\\\", then the path is absolute. Otherwise, it is relative.
+# consensus_dir=data\\consensus
+# For Linux platform
+# If its prefix is "/", then the path is absolute. Otherwise, it is relative.
+# consensus_dir=data/consensus

Review comment:
       Consesus_dir does not need to be configured separately, use data_dir/consensus




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org