You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by r-kamath <gi...@git.apache.org> on 2015/07/31 17:27:51 UTC
[GitHub] incubator-zeppelin pull request: ZEPPELIN-188 Display of line numb...
GitHub user r-kamath opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/174
ZEPPELIN-188 Display of line numbers
Partial check-in with reference to : ZEPPELIN-188.
- Add an option under the paragraph settings to show/hide line numbers in ace editor
Since Ace editor is already integrated, with minor changes, this patch will get us line numbers. Based on comments, would like to work on improving - syntax highlighting & auto-complete.
Thanks!
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/r-kamath/incubator-zeppelin master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/174.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #174
----
commit 19aecb2ccf88946d7cee9b81af0ed9dc6963d967
Author: Renjith Kamath <re...@gmail.com>
Date: 2015-07-31T15:06:57Z
ZEPPELIN-188 Display of line numbers
Add an option under the paragraph settings to show/hide line numbers in
ace editor
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] incubator-zeppelin pull request: ZEPPELIN-188 Display of
line numb...
Posted by IT CTO <go...@gmail.com>.
Just fixed it in pull request 210.
You can review and merge it.
Eran
On Thu, Aug 13, 2015 at 11:18 PM eranwitkon <gi...@git.apache.org> wrote:
> Github user eranwitkon commented on the pull request:
>
>
> https://github.com/apache/incubator-zeppelin/pull/174#issuecomment-130827787
>
> The problem above is due to the ```commitParagraph``` call within
> ```$scope.showLineNumbers``` and ```$scope.hideLineNumbers```
>
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
[GitHub] incubator-zeppelin pull request: ZEPPELIN-188 Display of line numb...
Posted by eranwitkon <gi...@git.apache.org>.
Github user eranwitkon commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/174#issuecomment-130827787
The problem above is due to the ```commitParagraph``` call within ```$scope.showLineNumbers``` and ```$scope.hideLineNumbers```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-188 Display of line numb...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/174#issuecomment-127713971
Current action bar is pretty full right now (and hard to understand)
The less actions buttons, the better
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-188 Display of line numb...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/174#issuecomment-127507327
is there a way to have this a sticky setting persisted across sections?
is this settable from the interpreter tab?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-188 Display of line numb...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/174
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-188 Display of line numb...
Posted by r-kamath <gi...@git.apache.org>.
Github user r-kamath commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/174#issuecomment-127557729
> is there a way to have this a sticky setting persisted across sections?
In 19aecb2 show/hide line number action is in the paragraph settings and is persisted only in the instance where it's turned on.
> is this settable from the interpreter tab?
We can have a new option in the Notebook settings to invoke show/hide action for all paragraphs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-188 Display of line numb...
Posted by eranwitkon <gi...@git.apache.org>.
Github user eranwitkon commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/174#issuecomment-130825698
Just found out that when we turn on line number or turn of line numbers it always reset the paragraph title.
Now, after adding the line numbers:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-188 Display of line numb...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/174#issuecomment-129259358
This is screenshot comes from this branch
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-188 Display of line numb...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/174#issuecomment-129709364
It looks good to me. It enables display line numbers while it does not change any default behavior. We can still discuss about action button in separate issue.
If there're no more discussions, i'm merging it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---