[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4308: Emit freshness lag at server level as well

[GitBox <gi...@apache.org>]

mcvsubbu commented on a change in pull request #4308: Emit freshness lag at server level as well
URL: https://github.com/apache/incubator-pinot/pull/4308#discussion_r292976573
 
 

 ##########
 File path: pinot-common/src/main/java/org/apache/pinot/common/metadata/RowMetadata.java
 ##########
 @@ -23,16 +23,19 @@
 
 
 /**
- * A class that provides relevant row-level metadata for rows ingested into a segment.
+ * A class that provides relevant row-level metadata for rows indexed into a segment.
  *
- * Currently this is relevant for rows ingested into a mutable segment.
+ * Currently this is relevant for rows ingested into a mutable segment - the metadata is expected to be
+ * provided by the underlying stream.
  */
 @InterfaceAudience.Public
 @InterfaceStability.Evolving
 public interface RowMetadata {
 
   /**
-   * Return the ingestion timestamp of the row.
+   * Return the timestamp associated with when the row was ingested upstream.
 
 Review comment:
   Please also include in the comments, what value an implementation should return if it does not have the information. Not all streams may provide a timestamp when an event was ingested upstream.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org