You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by gg...@apache.org on 2015/09/24 08:19:31 UTC

logging-log4j2 git commit: Refactor duplicates into a new constant: DEFAULT_WRITE_CONCERN.

Repository: logging-log4j2
Updated Branches:
  refs/heads/master 205acf2b2 -> b180226cc


Refactor duplicates into a new constant: DEFAULT_WRITE_CONCERN.

Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/b180226c
Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/b180226c
Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/b180226c

Branch: refs/heads/master
Commit: b180226ccca8c926f57c92ec87218b751e1c24b0
Parents: 205acf2
Author: ggregory <gg...@apache.org>
Authored: Wed Sep 23 23:19:29 2015 -0700
Committer: ggregory <gg...@apache.org>
Committed: Wed Sep 23 23:19:29 2015 -0700

----------------------------------------------------------------------
 .../log4j/nosql/appender/mongodb/MongoDbProvider.java       | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/b180226c/log4j-nosql/src/main/java/org/apache/logging/log4j/nosql/appender/mongodb/MongoDbProvider.java
----------------------------------------------------------------------
diff --git a/log4j-nosql/src/main/java/org/apache/logging/log4j/nosql/appender/mongodb/MongoDbProvider.java b/log4j-nosql/src/main/java/org/apache/logging/log4j/nosql/appender/mongodb/MongoDbProvider.java
index 9972f62..98bd50d 100644
--- a/log4j-nosql/src/main/java/org/apache/logging/log4j/nosql/appender/mongodb/MongoDbProvider.java
+++ b/log4j-nosql/src/main/java/org/apache/logging/log4j/nosql/appender/mongodb/MongoDbProvider.java
@@ -40,12 +40,13 @@ import org.apache.logging.log4j.util.Strings;
  */
 @Plugin(name = "MongoDb", category = "Core", printObject = true)
 public final class MongoDbProvider implements NoSqlProvider<MongoDbConnection> {
+    
+    private static final WriteConcern DEFAULT_WRITE_CONCERN = WriteConcern.ACKNOWLEDGED;
     private static final Logger LOGGER = StatusLogger.getLogger();
 
     private final String collectionName;
     private final DB database;
     private final String description;
-
     private final WriteConcern writeConcern;
 
     private MongoDbProvider(final DB database, final WriteConcern writeConcern, final String collectionName,
@@ -207,17 +208,17 @@ public final class MongoDbProvider implements NoSqlProvider<MongoDbConnection> {
                 } catch (final Exception e) {
                     LOGGER.error("Write concern constant [{}.{}] not found, using default.",
                             writeConcernConstantClassName, writeConcernConstant);
-                    writeConcern = WriteConcern.ACKNOWLEDGED;
+                    writeConcern = DEFAULT_WRITE_CONCERN;
                 }
             } else {
                 writeConcern = WriteConcern.valueOf(writeConcernConstant);
                 if (writeConcern == null) {
                     LOGGER.warn("Write concern constant [{}] not found, using default.", writeConcernConstant);
-                    writeConcern = WriteConcern.ACKNOWLEDGED;
+                    writeConcern = DEFAULT_WRITE_CONCERN;
                 }
             }
         } else {
-            writeConcern = WriteConcern.ACKNOWLEDGED;
+            writeConcern = DEFAULT_WRITE_CONCERN;
         }
         return writeConcern;
     }