You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Joris Van Remoortere <jo...@gmail.com> on 2014/12/05 19:38:19 UTC
Review Request 28763: Add configure flag to enable SSL.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28763/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Niklas Nielsen.
Bugs: MESOS-2108
https://issues.apache.org/jira/browse/MESOS-2108
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
3rdparty/libprocess/configure.ac 314c8b842d07e1344659449866f7e85c48854204
Diff: https://reviews.apache.org/r/28763/diff/
Testing
-------
configure with '--enable-libevent --enable--ssl' and without.
Thanks,
Joris Van Remoortere
Re: Review Request 28763: Add configure flag to enable SSL.
Posted by Niklas Nielsen <ni...@qni.dk>.
> On Dec. 24, 2014, 12:34 p.m., Mesos ReviewBot wrote:
> > Bad patch!
> >
> > Reviews applied: [28314, 28315]
> >
> > Failed command: ./support/apply-review.sh -n -r 28315
> >
> > Error:
> > 2014-12-24 20:34:41 URL:https://reviews.apache.org/r/28315/diff/raw/ [20372/20372] -> "28315.patch" [1]
> > error: patch failed: 3rdparty/libprocess/src/clock.cpp:69
> > error: 3rdparty/libprocess/src/clock.cpp: patch does not apply
> > Failed to apply patch
Mind rebasing?
- Niklas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28763/#review66052
-----------------------------------------------------------
On Dec. 24, 2014, 12:20 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28763/
> -----------------------------------------------------------
>
> (Updated Dec. 24, 2014, 12:20 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
>
>
> Bugs: MESOS-2108
> https://issues.apache.org/jira/browse/MESOS-2108
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/configure.ac 024f892106cf921d1559ecf59c81fde6a4baaa41
>
> Diff: https://reviews.apache.org/r/28763/diff/
>
>
> Testing
> -------
>
> configure with '--enable-libevent --enable--ssl' and without.
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 28763: Add configure flag to enable SSL.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28763/#review66052
-----------------------------------------------------------
Bad patch!
Reviews applied: [28314, 28315]
Failed command: ./support/apply-review.sh -n -r 28315
Error:
2014-12-24 20:34:41 URL:https://reviews.apache.org/r/28315/diff/raw/ [20372/20372] -> "28315.patch" [1]
error: patch failed: 3rdparty/libprocess/src/clock.cpp:69
error: 3rdparty/libprocess/src/clock.cpp: patch does not apply
Failed to apply patch
- Mesos ReviewBot
On Dec. 24, 2014, 8:20 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28763/
> -----------------------------------------------------------
>
> (Updated Dec. 24, 2014, 8:20 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
>
>
> Bugs: MESOS-2108
> https://issues.apache.org/jira/browse/MESOS-2108
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/configure.ac 024f892106cf921d1559ecf59c81fde6a4baaa41
>
> Diff: https://reviews.apache.org/r/28763/diff/
>
>
> Testing
> -------
>
> configure with '--enable-libevent --enable--ssl' and without.
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 28763: Add configure flag to enable SSL.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28763/#review70514
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On Jan. 31, 2015, 11:27 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28763/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2015, 11:27 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
>
>
> Bugs: MESOS-2108
> https://issues.apache.org/jira/browse/MESOS-2108
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/configure.ac 19bc601247f3b1fc6b28d3474fb39f7369bb382f
>
> Diff: https://reviews.apache.org/r/28763/diff/
>
>
> Testing
> -------
>
> configure with '--enable-libevent --enable--ssl' and without.
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 28763: Add configure flag to enable SSL.
Posted by Joris Van Remoortere <jo...@gmail.com>.
> On Feb. 17, 2015, 2:10 a.m., Niklas Nielsen wrote:
> > Joris, can this be committed in isolation or does it need to go in with other RRs? If so, let's mark it [1/X] for cherry picking :)
I suppose it can be committed in isolation as it does not disable anything. It would just be a no-op if you used the --enable-ssl flag.
- Joris
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28763/#review72669
-----------------------------------------------------------
On Jan. 31, 2015, 11:27 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28763/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2015, 11:27 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
>
>
> Bugs: MESOS-2108
> https://issues.apache.org/jira/browse/MESOS-2108
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/configure.ac 19bc601247f3b1fc6b28d3474fb39f7369bb382f
>
> Diff: https://reviews.apache.org/r/28763/diff/
>
>
> Testing
> -------
>
> configure with '--enable-libevent --enable--ssl' and without.
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 28763: Add configure flag to enable SSL.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28763/#review72669
-----------------------------------------------------------
Joris, can this be committed in isolation or does it need to go in with other RRs? If so, let's mark it [1/X] for cherry picking :)
- Niklas Nielsen
On Jan. 31, 2015, 3:27 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28763/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2015, 3:27 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
>
>
> Bugs: MESOS-2108
> https://issues.apache.org/jira/browse/MESOS-2108
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/configure.ac 19bc601247f3b1fc6b28d3474fb39f7369bb382f
>
> Diff: https://reviews.apache.org/r/28763/diff/
>
>
> Testing
> -------
>
> configure with '--enable-libevent --enable--ssl' and without.
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 28763: Add configure flag to enable SSL.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28763/#review78385
-----------------------------------------------------------
lgtm, test configure with and without (same as joris)
- Joerg Schad
On Jan. 31, 2015, 11:27 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28763/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2015, 11:27 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
>
>
> Bugs: MESOS-2108
> https://issues.apache.org/jira/browse/MESOS-2108
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/configure.ac 19bc601247f3b1fc6b28d3474fb39f7369bb382f
>
> Diff: https://reviews.apache.org/r/28763/diff/
>
>
> Testing
> -------
>
> configure with '--enable-libevent --enable--ssl' and without.
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 28763: Add configure flag to enable SSL.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28763/
-----------------------------------------------------------
(Updated Jan. 31, 2015, 11:27 p.m.)
Review request for mesos, Benjamin Hindman and Niklas Nielsen.
Changes
-------
Rebased onto r29569
Bugs: MESOS-2108
https://issues.apache.org/jira/browse/MESOS-2108
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
3rdparty/libprocess/configure.ac 19bc601247f3b1fc6b28d3474fb39f7369bb382f
Diff: https://reviews.apache.org/r/28763/diff/
Testing
-------
configure with '--enable-libevent --enable--ssl' and without.
Thanks,
Joris Van Remoortere
Re: Review Request 28763: Add configure flag to enable SSL.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28763/
-----------------------------------------------------------
(Updated Dec. 24, 2014, 8:20 p.m.)
Review request for mesos, Benjamin Hindman and Niklas Nielsen.
Changes
-------
We require libevent-socket for now since we want to support both ssl and non-ssl sockets simultaneously.
Bugs: MESOS-2108
https://issues.apache.org/jira/browse/MESOS-2108
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
3rdparty/libprocess/configure.ac 024f892106cf921d1559ecf59c81fde6a4baaa41
Diff: https://reviews.apache.org/r/28763/diff/
Testing
-------
configure with '--enable-libevent --enable--ssl' and without.
Thanks,
Joris Van Remoortere
Re: Review Request 28763: Add configure flag to enable SSL.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28763/#review64054
-----------------------------------------------------------
Bad patch!
Reviews applied: [28314, 28315]
Failed command: ./support/apply-review.sh -n -r 28315
Error:
2014-12-05 18:54:17 URL:https://reviews.apache.org/r/28315/diff/raw/ [15120/15120] -> "28315.patch" [1]
error: patch failed: 3rdparty/libprocess/src/process.cpp:574
error: 3rdparty/libprocess/src/process.cpp: patch does not apply
Failed to apply patch
- Mesos ReviewBot
On Dec. 5, 2014, 6:47 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28763/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2014, 6:47 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
>
>
> Bugs: MESOS-2108
> https://issues.apache.org/jira/browse/MESOS-2108
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/configure.ac 314c8b842d07e1344659449866f7e85c48854204
>
> Diff: https://reviews.apache.org/r/28763/diff/
>
>
> Testing
> -------
>
> configure with '--enable-libevent --enable--ssl' and without.
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 28763: Add configure flag to enable SSL.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28763/
-----------------------------------------------------------
(Updated Dec. 5, 2014, 6:47 p.m.)
Review request for mesos, Benjamin Hindman and Niklas Nielsen.
Changes
-------
add to dependency chain.
Bugs: MESOS-2108
https://issues.apache.org/jira/browse/MESOS-2108
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
3rdparty/libprocess/configure.ac 314c8b842d07e1344659449866f7e85c48854204
Diff: https://reviews.apache.org/r/28763/diff/
Testing
-------
configure with '--enable-libevent --enable--ssl' and without.
Thanks,
Joris Van Remoortere
Re: Review Request 28763: Add configure flag to enable SSL.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28763/#review64045
-----------------------------------------------------------
Bad patch!
Reviews applied: [28763]
Failed command: ./support/apply-review.sh -n -r 28763
Error:
2014-12-05 18:39:56 URL:https://reviews.apache.org/r/28763/diff/raw/ [3623/3623] -> "28763.patch" [1]
error: patch failed: 3rdparty/libprocess/configure.ac:83
error: 3rdparty/libprocess/configure.ac: patch does not apply
Failed to apply patch
- Mesos ReviewBot
On Dec. 5, 2014, 6:38 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28763/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2014, 6:38 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
>
>
> Bugs: MESOS-2108
> https://issues.apache.org/jira/browse/MESOS-2108
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/configure.ac 314c8b842d07e1344659449866f7e85c48854204
>
> Diff: https://reviews.apache.org/r/28763/diff/
>
>
> Testing
> -------
>
> configure with '--enable-libevent --enable--ssl' and without.
>
>
> Thanks,
>
> Joris Van Remoortere
>
>