You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "stack (JIRA)" <ji...@apache.org> on 2008/02/29 23:39:55 UTC
[jira] Created: (HBASE-480) Tool to manually merge two regions
Tool to manually merge two regions
----------------------------------
Key: HBASE-480
URL: https://issues.apache.org/jira/browse/HBASE-480
Project: Hadoop HBase
Issue Type: Bug
Reporter: stack
Priority: Minor
hbase-471 needs a tool to merge two regions that have same start key. This tool may be of use elsewhere making repairs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-480) Tool to manually merge two regions
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-480:
------------------------
Attachment: merge-v2.patch
Removed DisableCommand changes from the patch. Any chance of a review?
> Tool to manually merge two regions
> ----------------------------------
>
> Key: HBASE-480
> URL: https://issues.apache.org/jira/browse/HBASE-480
> Project: Hadoop HBase
> Issue Type: Bug
> Reporter: stack
> Priority: Minor
> Attachments: merge-v2.patch, merge.patch
>
>
> hbase-471 needs a tool to merge two regions that have same start key. This tool may be of use elsewhere making repairs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-480) Tool to manually merge two regions
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-480:
------------------------
Fix Version/s: 0.2.0
0.1.0
Affects Version/s: 0.16.0
0.2.0
0.1.0
Already backported. Marking as fixed in 0.1
> Tool to manually merge two regions
> ----------------------------------
>
> Key: HBASE-480
> URL: https://issues.apache.org/jira/browse/HBASE-480
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.1.0, 0.2.0, 0.16.0
> Reporter: stack
> Priority: Minor
> Fix For: 0.1.0, 0.2.0
>
> Attachments: merge-0.1-v2.patch, merge-0.1-v3.patch, merge-v2.patch, merge-v3.patch, merge.patch
>
>
> hbase-471 needs a tool to merge two regions that have same start key. This tool may be of use elsewhere making repairs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-480) Tool to manually merge two regions
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12574134#action_12574134 ]
Bryan Duxbury commented on HBASE-480:
-------------------------------------
I applied and ran tests for v2, got:
{code}
Testcase: testMergeTable took 33.626 sec
Caused an ERROR
null
java.lang.NullPointerException
at org.apache.hadoop.hbase.HMerge$OnlineMerger.nextRegion(HMerge.java:218)
at org.apache.hadoop.hbase.HMerge$OnlineMerger.next(HMerge.java:275)
at org.apache.hadoop.hbase.HMerge$Merger.process(HMerge.java:127)
at org.apache.hadoop.hbase.HMerge.merge(HMerge.java:93)
at org.apache.hadoop.hbase.TestMergeTable.testMergeTable(TestMergeTable.java:37)
{code}
> Tool to manually merge two regions
> ----------------------------------
>
> Key: HBASE-480
> URL: https://issues.apache.org/jira/browse/HBASE-480
> Project: Hadoop HBase
> Issue Type: Bug
> Reporter: stack
> Priority: Minor
> Attachments: merge-0.1-v2.patch, merge-v2.patch, merge.patch
>
>
> hbase-471 needs a tool to merge two regions that have same start key. This tool may be of use elsewhere making repairs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-480) Tool to manually merge two regions
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-480:
------------------------
Attachment: merge-0.1-v3.patch
Patch for 0.1
> Tool to manually merge two regions
> ----------------------------------
>
> Key: HBASE-480
> URL: https://issues.apache.org/jira/browse/HBASE-480
> Project: Hadoop HBase
> Issue Type: Bug
> Reporter: stack
> Priority: Minor
> Attachments: merge-0.1-v2.patch, merge-0.1-v3.patch, merge-v2.patch, merge-v3.patch, merge.patch
>
>
> hbase-471 needs a tool to merge two regions that have same start key. This tool may be of use elsewhere making repairs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-480) Tool to manually merge two regions
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-480:
------------------------
Attachment: merge-v3.patch
My fault. Had fixed that in code but hadn't updated the patch. Here's v3. Thanks for reviewing.
{code}
durruti:~/Documents/checkouts/hbase/trunk stack$ svn diff src/java/org/apache/hadoop/hbase/HMerge.java > merge-v3.patch
durruti:~/Documents/checkouts/hbase/trunk stack$ ~/bin/ant/bin/ant clean compile jar test -Dtestcase=TestMergeTable
Buildfile: build.xml
clean:
[delete] Deleting directory /Users/stack/Documents/checkouts/hbase/trunk/build
...
test:
[mkdir] Created dir: /Users/stack/Documents/checkouts/hbase/trunk/build/test/logs
[junit] Running org.apache.hadoop.hbase.TestMergeTable
[junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 34.91 sec
BUILD SUCCESSFUL
Total time: 42 seconds
{code}
> Tool to manually merge two regions
> ----------------------------------
>
> Key: HBASE-480
> URL: https://issues.apache.org/jira/browse/HBASE-480
> Project: Hadoop HBase
> Issue Type: Bug
> Reporter: stack
> Priority: Minor
> Attachments: merge-0.1-v2.patch, merge-v2.patch, merge-v3.patch, merge.patch
>
>
> hbase-471 needs a tool to merge two regions that have same start key. This tool may be of use elsewhere making repairs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-480) Tool to manually merge two regions
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12574157#action_12574157 ]
Bryan Duxbury commented on HBASE-480:
-------------------------------------
Latest 0.2 patch works now, tests pass.
> Tool to manually merge two regions
> ----------------------------------
>
> Key: HBASE-480
> URL: https://issues.apache.org/jira/browse/HBASE-480
> Project: Hadoop HBase
> Issue Type: Bug
> Reporter: stack
> Priority: Minor
> Attachments: merge-0.1-v2.patch, merge-0.1-v3.patch, merge-v2.patch, merge-v3.patch, merge.patch
>
>
> hbase-471 needs a tool to merge two regions that have same start key. This tool may be of use elsewhere making repairs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HBASE-480) Tool to manually merge two regions
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack resolved HBASE-480.
-------------------------
Resolution: Fixed
Thanks for review Bryan. Committed to TRUNK and branch.
> Tool to manually merge two regions
> ----------------------------------
>
> Key: HBASE-480
> URL: https://issues.apache.org/jira/browse/HBASE-480
> Project: Hadoop HBase
> Issue Type: Bug
> Reporter: stack
> Priority: Minor
> Attachments: merge-0.1-v2.patch, merge-0.1-v3.patch, merge-v2.patch, merge-v3.patch, merge.patch
>
>
> hbase-471 needs a tool to merge two regions that have same start key. This tool may be of use elsewhere making repairs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-480) Tool to manually merge two regions
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-480:
------------------------
Attachment: merge.patch
HBASE-480 Tool to manually merge two regions
M src/java/org/apache/hadoop/hbase/HMerge.java
(main) Added. Made this class implement Tool interface
so can source alternate configuration.
(merge): Made it protected instead of private so can
call it explicitly from subclass that does a different
'process' implementation. Added a 'force' flag that
overrides the "won't merge if makes a too-big region"
check.
(getMetaRow): Added. Add protection against null
HRegionInfo seen commonly in the past.
(checkOffLine): Added. Usually merge will not work
if table is online but offlining is not working
reliably and shouldn't get in the way of this tool
working anyways. Let subclasses choose whether this
is necessary or not.
M src/java/org/apache/hadoop/hbase/hql/DisableCommand.java
Just some clean up and added a main so can invoke this
class w/o having to go via hql
> Tool to manually merge two regions
> ----------------------------------
>
> Key: HBASE-480
> URL: https://issues.apache.org/jira/browse/HBASE-480
> Project: Hadoop HBase
> Issue Type: Bug
> Reporter: stack
> Priority: Minor
> Attachments: merge.patch
>
>
> hbase-471 needs a tool to merge two regions that have same start key. This tool may be of use elsewhere making repairs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-480) Tool to manually merge two regions
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-480:
------------------------
Attachment: merge-0.1-v2.patch
Patch for 0.1 branch.
> Tool to manually merge two regions
> ----------------------------------
>
> Key: HBASE-480
> URL: https://issues.apache.org/jira/browse/HBASE-480
> Project: Hadoop HBase
> Issue Type: Bug
> Reporter: stack
> Priority: Minor
> Attachments: merge-0.1-v2.patch, merge-v2.patch, merge.patch
>
>
> hbase-471 needs a tool to merge two regions that have same start key. This tool may be of use elsewhere making repairs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.