[GitHub] [incubator-seatunnel] garyelephant commented on a change in pull request #906: [SeaTunnel #904] [config] improve the config parse logic

[GitBox <gi...@apache.org>]

garyelephant commented on a change in pull request #906:
URL: https://github.com/apache/incubator-seatunnel/pull/906#discussion_r777078143



##########
File path: tools/checkstyle/checkStyle.xml
##########
@@ -336,13 +336,13 @@
             <property name="format" value="(^[A-Z][0-9]?)$|([A-Z][a-zA-Z0-9]*[T]$)"/>
             <message key="name.invalidPattern" value="Class type name ''{0}'' must match pattern ''{1}''."/>
         </module>
-        
+
         <module name="PackageName">
-            <property name="format" value="^org\.apache\.seatunnel(\.[a-zA-Z][a-zA-Z0-9]*)*$"/>
+            <property name="format" value="^[a-z]+(\.[a-z][a-z0-9]{1,})*$"/>

Review comment:
       why this package name check is changed to another pattern ?

##########
File path: seatunnel-config/src/test/java/org/apache/seatunnel/config/CompleteTests.java
##########
@@ -17,35 +17,23 @@
 
 package org.apache.seatunnel.config;
 
-import java.io.File;
-import java.net.URL;
+import com.typesafe.config.Config;
+import com.typesafe.config.ConfigRenderOptions;
+import com.typesafe.config.ConfigResolveOptions;
+import com.typesafe.config.SeaTunnelConfigFactory;
+import org.apache.seatunnel.config.utils.FileUtils;
 
 public class CompleteTests {
 
     public static void main(String[] args) {

Review comment:
       What is this CompleteTests for ? Also the main method will throw exception even without any assert methods.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org