You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ace.apache.org by "Toni Menzel (JIRA)" <ji...@apache.org> on 2009/10/24 18:55:59 UTC
[jira] Created: (ACE-60) New FileBasedProvider that matches any
gatewayID
New FileBasedProvider that matches any gatewayID
------------------------------------------------
Key: ACE-60
URL: https://issues.apache.org/jira/browse/ACE-60
Project: Ace
Issue Type: New Feature
Reporter: Toni Menzel
Sometimes you just want to ship to any (unknown) gateway. For sake of simplicity it should be possible to just have versions in your store folder directly.
So instead of:
store/<gatewayID>/<version>/
Allow this:
store/<version>
Because this is very similar, this can also be implemented in the existing FileBasedProvider. Anyhow, in this case things should be more split up inside FileBasedProvider itself ( has pretty big methods currently).
Patch follows.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ACE-60) Allow FileBasedProvider to match any
gatewayID as fallback
Posted by "Toni Menzel (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ACE-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12769934#action_12769934 ]
Toni Menzel commented on ACE-60:
--------------------------------
Well not very sure, actually i thought of this solution as well but i think that FileBasedProvider is anyhow more a demo/teaching solution than much more.
So, in this case i think its better to have a zero config / straiht forward solution that can possibly break.
Anyway, i am open for anything at this point..
> Allow FileBasedProvider to match any gatewayID as fallback
> ----------------------------------------------------------
>
> Key: ACE-60
> URL: https://issues.apache.org/jira/browse/ACE-60
> Project: Ace
> Issue Type: New Feature
> Reporter: Toni Menzel
> Assignee: Marcel Offermans
> Attachments: ACE-60.patch
>
>
> Sometimes you just want to ship to any (unknown) gateway. For sake of simplicity it should be possible to just have versions in your store folder directly.
> So instead of:
> store/<gatewayID>/<version>/
> Allow this:
> store/<version>
> Because this is very similar, this can also be implemented in the existing FileBasedProvider. Anyhow, in this case things should be more split up inside FileBasedProvider itself ( has pretty big methods currently).
> Patch follows.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ACE-60) Allow FileBasedProvider to match any
gatewayID as fallback
Posted by "Marcel Offermans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ACE-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12769948#action_12769948 ]
Marcel Offermans commented on ACE-60:
-------------------------------------
I don't think that configuration is an issue here, because the current "store" folder that we use is already something that must be configured right now (obviously, we provide a default configuration as part of the target).
I'll have a go at providing a configuration setting, leaving the default of that setting to use the same store folder.
> Allow FileBasedProvider to match any gatewayID as fallback
> ----------------------------------------------------------
>
> Key: ACE-60
> URL: https://issues.apache.org/jira/browse/ACE-60
> Project: Ace
> Issue Type: New Feature
> Reporter: Toni Menzel
> Assignee: Marcel Offermans
> Attachments: ACE-60.patch
>
>
> Sometimes you just want to ship to any (unknown) gateway. For sake of simplicity it should be possible to just have versions in your store folder directly.
> So instead of:
> store/<gatewayID>/<version>/
> Allow this:
> store/<version>
> Because this is very similar, this can also be implemented in the existing FileBasedProvider. Anyhow, in this case things should be more split up inside FileBasedProvider itself ( has pretty big methods currently).
> Patch follows.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ACE-60) New FileBasedProvider that matches any
gatewayID
Posted by "Toni Menzel (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ACE-60?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Toni Menzel updated ACE-60:
---------------------------
Attachment: ACE-60.patch
Attached patch changes FileBasedProvider to also allow store/<version>/ if no matching store/<gatewayID> has been found.
> New FileBasedProvider that matches any gatewayID
> ------------------------------------------------
>
> Key: ACE-60
> URL: https://issues.apache.org/jira/browse/ACE-60
> Project: Ace
> Issue Type: New Feature
> Reporter: Toni Menzel
> Attachments: ACE-60.patch
>
>
> Sometimes you just want to ship to any (unknown) gateway. For sake of simplicity it should be possible to just have versions in your store folder directly.
> So instead of:
> store/<gatewayID>/<version>/
> Allow this:
> store/<version>
> Because this is very similar, this can also be implemented in the existing FileBasedProvider. Anyhow, in this case things should be more split up inside FileBasedProvider itself ( has pretty big methods currently).
> Patch follows.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ACE-60) Allow FileBasedProvider to match any
gatewayID as fallback
Posted by "Marcel Offermans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ACE-60?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marcel Offermans reassigned ACE-60:
-----------------------------------
Assignee: Marcel Offermans
> Allow FileBasedProvider to match any gatewayID as fallback
> ----------------------------------------------------------
>
> Key: ACE-60
> URL: https://issues.apache.org/jira/browse/ACE-60
> Project: Ace
> Issue Type: New Feature
> Reporter: Toni Menzel
> Assignee: Marcel Offermans
> Attachments: ACE-60.patch
>
>
> Sometimes you just want to ship to any (unknown) gateway. For sake of simplicity it should be possible to just have versions in your store folder directly.
> So instead of:
> store/<gatewayID>/<version>/
> Allow this:
> store/<version>
> Because this is very similar, this can also be implemented in the existing FileBasedProvider. Anyhow, in this case things should be more split up inside FileBasedProvider itself ( has pretty big methods currently).
> Patch follows.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ACE-60) Allow FileBasedProvider to match any
gatewayID as fallback
Posted by "Toni Menzel (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ACE-60?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Toni Menzel updated ACE-60:
---------------------------
Summary: Allow FileBasedProvider to match any gatewayID as fallback (was: New FileBasedProvider that matches any gatewayID)
> Allow FileBasedProvider to match any gatewayID as fallback
> ----------------------------------------------------------
>
> Key: ACE-60
> URL: https://issues.apache.org/jira/browse/ACE-60
> Project: Ace
> Issue Type: New Feature
> Reporter: Toni Menzel
> Attachments: ACE-60.patch
>
>
> Sometimes you just want to ship to any (unknown) gateway. For sake of simplicity it should be possible to just have versions in your store folder directly.
> So instead of:
> store/<gatewayID>/<version>/
> Allow this:
> store/<version>
> Because this is very similar, this can also be implemented in the existing FileBasedProvider. Anyhow, in this case things should be more split up inside FileBasedProvider itself ( has pretty big methods currently).
> Patch follows.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ACE-60) Allow FileBasedProvider to match any
gatewayID as fallback
Posted by "Marcel Offermans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ACE-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12769830#action_12769830 ]
Marcel Offermans commented on ACE-60:
-------------------------------------
Applied the patch. I am wondering though if this so called "default" set of versions should be in the root of the store folder or maybe in a configurable location to avoid all possible name clashes and confusion that this scheme might bring:
<store>/<gatewayID>/<version>
and
<defaultstore>/<version>
so perhaps instead of defining just one store folder, define two. Any comments on this?
> Allow FileBasedProvider to match any gatewayID as fallback
> ----------------------------------------------------------
>
> Key: ACE-60
> URL: https://issues.apache.org/jira/browse/ACE-60
> Project: Ace
> Issue Type: New Feature
> Reporter: Toni Menzel
> Assignee: Marcel Offermans
> Attachments: ACE-60.patch
>
>
> Sometimes you just want to ship to any (unknown) gateway. For sake of simplicity it should be possible to just have versions in your store folder directly.
> So instead of:
> store/<gatewayID>/<version>/
> Allow this:
> store/<version>
> Because this is very similar, this can also be implemented in the existing FileBasedProvider. Anyhow, in this case things should be more split up inside FileBasedProvider itself ( has pretty big methods currently).
> Patch follows.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ACE-60) Allow FileBasedProvider to match any
gatewayID as fallback
Posted by "Toni Menzel (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ACE-60?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Toni Menzel updated ACE-60:
---------------------------
Attachment: ACE-60-ignore-hidden.patch
trunk works fine, thanks marcel! Anyhow, on mac things fail easily when things like ".DS_Store" show up in the inspected folders. The attached patch fixes this.
> Allow FileBasedProvider to match any gatewayID as fallback
> ----------------------------------------------------------
>
> Key: ACE-60
> URL: https://issues.apache.org/jira/browse/ACE-60
> Project: Ace
> Issue Type: New Feature
> Reporter: Toni Menzel
> Assignee: Marcel Offermans
> Attachments: ACE-60-ignore-hidden.patch, ACE-60.patch
>
>
> Sometimes you just want to ship to any (unknown) gateway. For sake of simplicity it should be possible to just have versions in your store folder directly.
> So instead of:
> store/<gatewayID>/<version>/
> Allow this:
> store/<version>
> Because this is very similar, this can also be implemented in the existing FileBasedProvider. Anyhow, in this case things should be more split up inside FileBasedProvider itself ( has pretty big methods currently).
> Patch follows.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.