You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "pan3793 (via GitHub)" <gi...@apache.org> on 2026/05/08 05:15:37 UTC
[PR] HADOOP-19887. Improve GHA website workflow [hadoop]
pan3793 opened a new pull request, #8482:
URL: https://github.com/apache/hadoop/pull/8482
<!--
Thanks for sending a pull request!
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
2. Make sure your PR title starts with JIRA issue id, e.g., 'HADOOP-17799. Your PR title ...'.
-->
### Description of PR
- Upgrade actions to the latest version
- Manage Maven cache via `actions/setup-java`
- Switch `mvn` to `mvnw`, so it always picks the requested version of maven, instead of using `mvn` shipped in OS or installed by `actions/setup-java`.
### How was this patch tested?
I manually run those commands locally to ensure they work as expected.
### For code changes:
- [x] Does the title or this PR starts with the corresponding JIRA issue id (HADOOP-19887)?
- [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, `NOTICE-binary` files?
### AI Tooling
No AI usage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
Re: [PR] HADOOP-19887. Improve GHA website workflow [hadoop]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #8482:
URL: https://github.com/apache/hadoop/pull/8482#discussion_r3206608313
##########
.github/workflows/website.yml:
##########
@@ -26,31 +26,24 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout Hadoop trunk
- uses: actions/checkout@v3
- with:
- repository: apache/hadoop
+ uses: actions/checkout@v6
- name: Set up JDK 17
uses: actions/setup-java@v5
with:
java-version: '17'
distribution: 'temurin'
- - name: Cache local Maven repository
- uses: actions/cache@v3
- with:
- path: ~/.m2/repository
- key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
- restore-keys: |
- ${{ runner.os }}-maven-
+ cache: 'maven'
+ check-latest: false
- name: Build Hadoop maven plugins
- run: cd hadoop-maven-plugins && mvn --batch-mode install
+ run: ./mvnw --batch-mode -f hadoop-maven-plugins/pom.xml install
Review Comment:
this unfortunately does not work, and it was not caught in my local test as it has cache in `~/.m2`, I pushed a hotfix to restore it https://github.com/apache/hadoop/commit/b3cc7d0f97c7aa17faf9fe8a53b2d6b4c7b3c47d
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
Re: [PR] HADOOP-19887. Improve GHA website workflow [hadoop]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 merged PR #8482:
URL: https://github.com/apache/hadoop/pull/8482
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
Re: [PR] HADOOP-19887. Improve GHA website workflow [hadoop]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #8482:
URL: https://github.com/apache/hadoop/pull/8482#issuecomment-4403606791
thanks, merged to trunk (lint check pass, no need to wait for building pipeline as it does not touch the code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
Re: [PR] HADOOP-19887. Improve GHA website workflow [hadoop]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #8482:
URL: https://github.com/apache/hadoop/pull/8482#issuecomment-4403568899
@slfan1989 could you please take a quick look? we need this to recover the website deployed, currently it picks an obsolete version of `mvn` installed by `actions/setup-java`, which violates the `org.apache.maven.enforcer.rules.version.RequireMavenVersion`
https://github.com/apache/hadoop/actions/runs/25535467127/job/74950312789
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
Re: [PR] HADOOP-19887. Improve GHA website workflow [hadoop]
Posted by "hadoop-yetus (via GitHub)" <gi...@apache.org>.
hadoop-yetus commented on PR #8482:
URL: https://github.com/apache/hadoop/pull/8482#issuecomment-4403667277
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 18m 54s | | Docker mode activated. |
| -1 :x: | patch | 0m 5s | | https://github.com/apache/hadoop/pull/8482 does not apply to trunk. Rebase required? Wrong Branch? See https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute for help. |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.54 ServerAPI=1.54 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8482/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/8482 |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8482/1/console |
| versions | git=2.43.0 |
| Powered by | Apache Yetus 0.14.1 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
Re: [PR] HADOOP-19887. Improve GHA website workflow [hadoop]
Posted by "slfan1989 (via GitHub)" <gi...@apache.org>.
slfan1989 commented on PR #8482:
URL: https://github.com/apache/hadoop/pull/8482#issuecomment-4403587447
@pan3793 Thanks for the contribution! LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org