You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Benoit Sigoure (JIRA)" <ji...@apache.org> on 2011/05/05 22:31:03 UTC
[jira] [Created] (HBASE-3859) Increment a counter when a Scanner
lease expires
Increment a counter when a Scanner lease expires
------------------------------------------------
Key: HBASE-3859
URL: https://issues.apache.org/jira/browse/HBASE-3859
Project: HBase
Issue Type: Improvement
Components: regionserver
Affects Versions: 0.90.2
Reporter: Benoit Sigoure
Priority: Minor
Whenever a Scanner lease expires, the RegionServer will close it automatically and log a message to complain. I would like the RegionServer to increment a counter whenever this happens and expose this counter through the metrics system, so we can plug this into our monitoring system (OpenTSDB) and keep track of how frequently this happens. It's not supposed to happen frequently so it's good to keep an eye on it.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3859) Increment a counter when a Scanner
lease expires
Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13450336#comment-13450336 ]
Elliott Clark commented on HBASE-3859:
--------------------------------------
I would be +0 as things stand currently. This isn't a patch for trunk and will require some work to apply, and right now in my opinion the current version of the patch is not really using the Metrics1 classes correctly.
> Increment a counter when a Scanner lease expires
> ------------------------------------------------
>
> Key: HBASE-3859
> URL: https://issues.apache.org/jira/browse/HBASE-3859
> Project: HBase
> Issue Type: Improvement
> Components: metrics, regionserver
> Affects Versions: 0.90.2
> Reporter: Benoit Sigoure
> Assignee: Mubarak Seyed
> Priority: Minor
> Attachments: HBASE-3859.trunk.v1.patch
>
>
> Whenever a Scanner lease expires, the RegionServer will close it automatically and log a message to complain. I would like the RegionServer to increment a counter whenever this happens and expose this counter through the metrics system, so we can plug this into our monitoring system (OpenTSDB) and keep track of how frequently this happens. It's not supposed to happen frequently so it's good to keep an eye on it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-3859) Increment a counter when a Scanner
lease expires
Posted by "Mubarak Seyed (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mubarak Seyed updated HBASE-3859:
---------------------------------
Attachment: HBASE-3859.trunk.v1.patch
The attached file is a patch. Thanks.
> Increment a counter when a Scanner lease expires
> ------------------------------------------------
>
> Key: HBASE-3859
> URL: https://issues.apache.org/jira/browse/HBASE-3859
> Project: HBase
> Issue Type: Improvement
> Components: metrics, regionserver
> Affects Versions: 0.90.2
> Reporter: Benoit Sigoure
> Assignee: Mubarak Seyed
> Priority: Minor
> Attachments: HBASE-3859.trunk.v1.patch
>
>
> Whenever a Scanner lease expires, the RegionServer will close it automatically and log a message to complain. I would like the RegionServer to increment a counter whenever this happens and expose this counter through the metrics system, so we can plug this into our monitoring system (OpenTSDB) and keep track of how frequently this happens. It's not supposed to happen frequently so it's good to keep an eye on it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3859) Increment a counter when a Scanner
lease expires
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13448935#comment-13448935 ]
Lars Hofhansl commented on HBASE-3859:
--------------------------------------
Patch looks good. Should we commit?
I'm a bit fuzzy on the current state of Metrics in HBase (v1 vs v2, etc)
> Increment a counter when a Scanner lease expires
> ------------------------------------------------
>
> Key: HBASE-3859
> URL: https://issues.apache.org/jira/browse/HBASE-3859
> Project: HBase
> Issue Type: Improvement
> Components: metrics, regionserver
> Affects Versions: 0.90.2
> Reporter: Benoit Sigoure
> Assignee: Mubarak Seyed
> Priority: Minor
> Attachments: HBASE-3859.trunk.v1.patch
>
>
> Whenever a Scanner lease expires, the RegionServer will close it automatically and log a message to complain. I would like the RegionServer to increment a counter whenever this happens and expose this counter through the metrics system, so we can plug this into our monitoring system (OpenTSDB) and keep track of how frequently this happens. It's not supposed to happen frequently so it's good to keep an eye on it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3859) Increment a counter when a Scanner
lease expires
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13197395#comment-13197395 ]
stack commented on HBASE-3859:
------------------------------
Patch looks good.
Any evidence it works Mubarak?
> Increment a counter when a Scanner lease expires
> ------------------------------------------------
>
> Key: HBASE-3859
> URL: https://issues.apache.org/jira/browse/HBASE-3859
> Project: HBase
> Issue Type: Improvement
> Components: metrics, regionserver
> Affects Versions: 0.90.2
> Reporter: Benoit Sigoure
> Assignee: Mubarak Seyed
> Priority: Minor
> Attachments: HBASE-3859.trunk.v1.patch
>
>
> Whenever a Scanner lease expires, the RegionServer will close it automatically and log a message to complain. I would like the RegionServer to increment a counter whenever this happens and expose this counter through the metrics system, so we can plug this into our monitoring system (OpenTSDB) and keep track of how frequently this happens. It's not supposed to happen frequently so it's good to keep an eye on it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3859) Increment a counter when a Scanner
lease expires
Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13448971#comment-13448971 ]
Elliott Clark commented on HBASE-3859:
--------------------------------------
Wouldn't it be better to use MetricsTimeVaryingLong rather than a MetricsLongValue and an AtomicLong
[~lhofhansl] We're starting to get close to finishing the move to metrics2 however the HRegionServer is the last part that needs to be moved over. My plan is to move over and clean up stuff in HBASE-4050 in the coming weeks. With that said I still think this can be a useful issue and having it in the Mertics1 version will make sure that it's ported over when the time comes.
> Increment a counter when a Scanner lease expires
> ------------------------------------------------
>
> Key: HBASE-3859
> URL: https://issues.apache.org/jira/browse/HBASE-3859
> Project: HBase
> Issue Type: Improvement
> Components: metrics, regionserver
> Affects Versions: 0.90.2
> Reporter: Benoit Sigoure
> Assignee: Mubarak Seyed
> Priority: Minor
> Attachments: HBASE-3859.trunk.v1.patch
>
>
> Whenever a Scanner lease expires, the RegionServer will close it automatically and log a message to complain. I would like the RegionServer to increment a counter whenever this happens and expose this counter through the metrics system, so we can plug this into our monitoring system (OpenTSDB) and keep track of how frequently this happens. It's not supposed to happen frequently so it's good to keep an eye on it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3859) Increment a counter when a Scanner
lease expires
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13450313#comment-13450313 ]
stack commented on HBASE-3859:
------------------------------
[~eclark] So we should commit it? I tried to and it fails. I tried to fix the failures but was into land of uncertainty (land of metrics). If you get a chance, take a look see?
> Increment a counter when a Scanner lease expires
> ------------------------------------------------
>
> Key: HBASE-3859
> URL: https://issues.apache.org/jira/browse/HBASE-3859
> Project: HBase
> Issue Type: Improvement
> Components: metrics, regionserver
> Affects Versions: 0.90.2
> Reporter: Benoit Sigoure
> Assignee: Mubarak Seyed
> Priority: Minor
> Attachments: HBASE-3859.trunk.v1.patch
>
>
> Whenever a Scanner lease expires, the RegionServer will close it automatically and log a message to complain. I would like the RegionServer to increment a counter whenever this happens and expose this counter through the metrics system, so we can plug this into our monitoring system (OpenTSDB) and keep track of how frequently this happens. It's not supposed to happen frequently so it's good to keep an eye on it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-3859) Increment a counter when a Scanner
lease expires
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-3859:
-------------------------
Component/s: metrics
> Increment a counter when a Scanner lease expires
> ------------------------------------------------
>
> Key: HBASE-3859
> URL: https://issues.apache.org/jira/browse/HBASE-3859
> Project: HBase
> Issue Type: Improvement
> Components: metrics, regionserver
> Affects Versions: 0.90.2
> Reporter: Benoit Sigoure
> Priority: Minor
>
> Whenever a Scanner lease expires, the RegionServer will close it automatically and log a message to complain. I would like the RegionServer to increment a counter whenever this happens and expose this counter through the metrics system, so we can plug this into our monitoring system (OpenTSDB) and keep track of how frequently this happens. It's not supposed to happen frequently so it's good to keep an eye on it.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-3859) Increment a counter when a Scanner
lease expires
Posted by "Mubarak Seyed (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mubarak Seyed reassigned HBASE-3859:
------------------------------------
Assignee: Mubarak Seyed
> Increment a counter when a Scanner lease expires
> ------------------------------------------------
>
> Key: HBASE-3859
> URL: https://issues.apache.org/jira/browse/HBASE-3859
> Project: HBase
> Issue Type: Improvement
> Components: metrics, regionserver
> Affects Versions: 0.90.2
> Reporter: Benoit Sigoure
> Assignee: Mubarak Seyed
> Priority: Minor
>
> Whenever a Scanner lease expires, the RegionServer will close it automatically and log a message to complain. I would like the RegionServer to increment a counter whenever this happens and expose this counter through the metrics system, so we can plug this into our monitoring system (OpenTSDB) and keep track of how frequently this happens. It's not supposed to happen frequently so it's good to keep an eye on it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3859) Increment a counter when a Scanner
lease expires
Posted by "Mubarak Seyed (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13197436#comment-13197436 ]
Mubarak Seyed commented on HBASE-3859:
--------------------------------------
@Stack
Unit test-suite passed. Working on to test it out in cluster to see the metric in Ganglia. Thanks.
> Increment a counter when a Scanner lease expires
> ------------------------------------------------
>
> Key: HBASE-3859
> URL: https://issues.apache.org/jira/browse/HBASE-3859
> Project: HBase
> Issue Type: Improvement
> Components: metrics, regionserver
> Affects Versions: 0.90.2
> Reporter: Benoit Sigoure
> Assignee: Mubarak Seyed
> Priority: Minor
> Attachments: HBASE-3859.trunk.v1.patch
>
>
> Whenever a Scanner lease expires, the RegionServer will close it automatically and log a message to complain. I would like the RegionServer to increment a counter whenever this happens and expose this counter through the metrics system, so we can plug this into our monitoring system (OpenTSDB) and keep track of how frequently this happens. It's not supposed to happen frequently so it's good to keep an eye on it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira