You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Aryeh Katz <ar...@secured-services.com> on 2003/09/18 21:31:35 UTC
mod_info question
In mod_info, SERVER_CONFIG_FILE is used in order to determine which
config file the apache server is running with
However, this ignores the -f option.
Shouldn't we be printing out
ap_conftree->filename?
---
Aryeh Katz
Secured-Services Inc.
Re: mod_info question
Posted by Jeff Trawick <tr...@attglobal.net>.
Günter Knauf wrote:
> Hi,
>
>>Patch below was tested and it worked in a linux environment.
>
>
>># diff -u mod_info.old.c mod_info.c
>>--- mod_info.old.c Mon Sep 15 07:48:59 2003
>>+++ mod_info.c Mon Sep 15 07:50:18 2003
>>@@ -405,7 +405,7 @@
>> ap_rprintf(r, "<dt><strong>Server Root:</strong> "
>> "<tt>%s</tt></dt>\n", ap_server_root);
>> ap_rprintf(r, "<dt><strong>Config File:</strong> "
>>- "<tt>%s</tt></dt>\n", SERVER_CONFIG_FILE);
>>+ "<tt>%s</tt></dt>\n", ap_conftree->filename);
>> ap_rputs("</dl><hr />", r);
>> }
>> for (modp = ap_top_module; modp; modp = modp->next) {
>
> just tested with NetWare and Win32 and works fine.
ooh, great! you just saved me some time :)
I'll commit to 2.1-dev shortly...
> Would be nice to have that in 2.0.48 since it is a simple patch which shouldnt break anything...
...and propose it for merging to the stable branch.
Re: mod_info question
Posted by Günter Knauf <ef...@gmx.net>.
Hi,
> Patch below was tested and it worked in a linux environment.
> # diff -u mod_info.old.c mod_info.c
> --- mod_info.old.c Mon Sep 15 07:48:59 2003
> +++ mod_info.c Mon Sep 15 07:50:18 2003
> @@ -405,7 +405,7 @@
> ap_rprintf(r, "<dt><strong>Server Root:</strong> "
> "<tt>%s</tt></dt>\n", ap_server_root);
> ap_rprintf(r, "<dt><strong>Config File:</strong> "
> - "<tt>%s</tt></dt>\n", SERVER_CONFIG_FILE);
> + "<tt>%s</tt></dt>\n", ap_conftree->filename);
> ap_rputs("</dl><hr />", r);
> }
> for (modp = ap_top_module; modp; modp = modp->next) {
just tested with NetWare and Win32 and works fine.
Would be nice to have that in 2.0.48 since it is a simple patch which shouldnt break anything...
Guenter.
Re: mod_info question
Posted by Aryeh Katz <ar...@secured-services.com>.
> Aryeh Katz wrote:
>
> > In mod_info, SERVER_CONFIG_FILE is used in order to determine which
> > config file the apache server is running with However, this ignores
> > the -f option. Shouldn't we be printing out ap_conftree->filename?
>
> that sounds right to me... got a patch you have tested that I can
> play with? (this time with old file on left and new file on right ;)
Sorry about that last patch :-(
Patch below was tested and it worked in a linux environment.
# diff -u mod_info.old.c mod_info.c
--- mod_info.old.c Mon Sep 15 07:48:59 2003
+++ mod_info.c Mon Sep 15 07:50:18 2003
@@ -405,7 +405,7 @@
ap_rprintf(r, "<dt><strong>Server Root:</strong> "
"<tt>%s</tt></dt>\n", ap_server_root);
ap_rprintf(r, "<dt><strong>Config File:</strong> "
- "<tt>%s</tt></dt>\n", SERVER_CONFIG_FILE);
+ "<tt>%s</tt></dt>\n", ap_conftree->filename);
ap_rputs("</dl><hr />", r);
}
for (modp = ap_top_module; modp; modp = modp->next) {
---
Aryeh Katz
Secured-Services Inc.
Re: mod_info question
Posted by Jeff Trawick <tr...@attglobal.net>.
Aryeh Katz wrote:
> In mod_info, SERVER_CONFIG_FILE is used in order to determine which
> config file the apache server is running with
> However, this ignores the -f option.
> Shouldn't we be printing out
> ap_conftree->filename?
that sounds right to me... got a patch you have tested that I can play
with? (this time with old file on left and new file on right ;) )