[GitHub] [seatunnel] wu-a-ge commented on a diff in pull request #5458: [Improve][Format] [Json] Datetime format deserialization supports custom datetime format and remove the redundant TIME FORMAT

["wu-a-ge (via GitHub)" <gi...@apache.org>]

wu-a-ge commented on code in PR #5458:
URL: https://github.com/apache/seatunnel/pull/5458#discussion_r1325999333


##########
seatunnel-formats/seatunnel-format-json/src/main/java/org/apache/seatunnel/format/json/TimeFormat.java:
##########
@@ -29,4 +35,19 @@ public class TimeFormat {
                     .appendPattern("HH:mm:ss")
                     .appendFraction(ChronoField.NANO_OF_SECOND, 0, MAX_TIME_PRECISION, true)
                     .toFormatter();
+    public static final DateTimeFormatter CUSTOM_DATE_TIME_FORMAT =

Review Comment:
   So far I've only added a common custom date format, the best way to handle this is to add parameters to JsonSchema, and all connectors that use JsonSchema will need to be tweaked and modified



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org