You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pluto-scm@portals.apache.org by ms...@apache.org on 2016/04/22 10:58:44 UTC
[25/30] portals-pluto git commit: For Jayendran Anil Kumar: in
Testmodule3 deleted the test case for the public render parameter alias,
since the function description is unclear in the 2.0 spec and has been removed
from the 3.0 spec.
For Jayendran Anil Kumar: in Testmodule3 deleted the test case for the public
render parameter alias, since the function description is unclear in the 2.0 spec
and has been removed from the 3.0 spec.
Project: http://git-wip-us.apache.org/repos/asf/portals-pluto/repo
Commit: http://git-wip-us.apache.org/repos/asf/portals-pluto/commit/c53495b3
Tree: http://git-wip-us.apache.org/repos/asf/portals-pluto/tree/c53495b3
Diff: http://git-wip-us.apache.org/repos/asf/portals-pluto/diff/c53495b3
Branch: refs/heads/master
Commit: c53495b38a5ab5a62f2eb3e6d52b25f56a206017
Parents: 4156e3e
Author: Scott Nicklous <ms...@apache.org>
Authored: Thu Apr 21 13:30:39 2016 +0200
Committer: Scott Nicklous <ms...@apache.org>
Committed: Thu Apr 21 13:30:39 2016 +0200
----------------------------------------------------------------------
.../portlets/TestModule3_Portlet1.java | 8 --------
.../portlets/TestModule3_Portlet2.java | 20 --------------------
.../xml-resources/tck-TestModule3-tests.xml | 1 -
.../tck/beans/TestModule3Definitions.java | 4 ----
4 files changed, 33 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/portals-pluto/blob/c53495b3/portlet-tck_3.0/TestModule3-portlet1/src/main/java/javax/portlet/tck/TestModule3/portlets/TestModule3_Portlet1.java
----------------------------------------------------------------------
diff --git a/portlet-tck_3.0/TestModule3-portlet1/src/main/java/javax/portlet/tck/TestModule3/portlets/TestModule3_Portlet1.java b/portlet-tck_3.0/TestModule3-portlet1/src/main/java/javax/portlet/tck/TestModule3/portlets/TestModule3_Portlet1.java
index f4f6ef6..3ffcd11 100644
--- a/portlet-tck_3.0/TestModule3-portlet1/src/main/java/javax/portlet/tck/TestModule3/portlets/TestModule3_Portlet1.java
+++ b/portlet-tck_3.0/TestModule3-portlet1/src/main/java/javax/portlet/tck/TestModule3/portlets/TestModule3_Portlet1.java
@@ -89,14 +89,6 @@ public class TestModule3_Portlet1 implements Portlet {
tl = new TestLink(TEST2, purl);
tl.writeTo(writer);
- // Test: TestModule3_PublicRenderParameterTestAlias
- // This portlet generates the link. The companion portlet displays the results.
- purl = response.createRenderURL();
- purl.setParameter(TM3PRP0, TEST3);
- purl.setParameter(TM3PRP3, TM3PRP3);
- tl = new TestLink(TEST3, purl);
- tl.writeTo(writer);
-
}
@Override
http://git-wip-us.apache.org/repos/asf/portals-pluto/blob/c53495b3/portlet-tck_3.0/TestModule3-portlet2/src/main/java/javax/portlet/tck/TestModule3/portlets/TestModule3_Portlet2.java
----------------------------------------------------------------------
diff --git a/portlet-tck_3.0/TestModule3-portlet2/src/main/java/javax/portlet/tck/TestModule3/portlets/TestModule3_Portlet2.java b/portlet-tck_3.0/TestModule3-portlet2/src/main/java/javax/portlet/tck/TestModule3/portlets/TestModule3_Portlet2.java
index 771146f..2511759 100644
--- a/portlet-tck_3.0/TestModule3-portlet2/src/main/java/javax/portlet/tck/TestModule3/portlets/TestModule3_Portlet2.java
+++ b/portlet-tck_3.0/TestModule3-portlet2/src/main/java/javax/portlet/tck/TestModule3/portlets/TestModule3_Portlet2.java
@@ -111,24 +111,6 @@ public class TestModule3_Portlet2 implements Portlet {
tm.writeTo(writer);
}
- // Test: TestModule3_PublicRenderParameterTestAlias
- // Details: A PRP with differing QNames & identifier, but with matching alias,
- // is visible in companion portlet of different portlet application.
- // (expected to succeed)
- if (test.equals(TEST3)) {
- String val = request.getParameter(TM3PRP3a);
- if (val == null) {
- tr = tcd.getTestResultSucceeded(TEST3);
- } else {
- tr = tcd.getTestResultFailed(TEST3);
- tr.appendTcDetail("Expected value of parameter " + TM3PRP3a + ": " + TM3PRP3 + ", Actual value: " + val);
- }
- tr.writeTo(writer);
- } else {
- TestMessage tm = new TestMessage(TEST3, "Waiting for test to be executed.");
- tm.writeTo(writer);
- }
-
} else {
// test not executed yet, or was not correctly executed
TestMessage tm = new TestMessage(TEST0, "Waiting for " + TM3PRP0 + " to be set.");
@@ -137,8 +119,6 @@ public class TestModule3_Portlet2 implements Portlet {
tm.writeTo(writer);
tm = new TestMessage(TEST2, "Waiting for " + TM3PRP0 + " to be set.");
tm.writeTo(writer);
- tm = new TestMessage(TEST3, "Waiting for " + TM3PRP0 + " to be set.");
- tm.writeTo(writer);
}
}
http://git-wip-us.apache.org/repos/asf/portals-pluto/blob/c53495b3/portlet-tck_3.0/TestModule3/src/main/resources/xml-resources/tck-TestModule3-tests.xml
----------------------------------------------------------------------
diff --git a/portlet-tck_3.0/TestModule3/src/main/resources/xml-resources/tck-TestModule3-tests.xml b/portlet-tck_3.0/TestModule3/src/main/resources/xml-resources/tck-TestModule3-tests.xml
index fb77e88..3cb82fa 100644
--- a/portlet-tck_3.0/TestModule3/src/main/resources/xml-resources/tck-TestModule3-tests.xml
+++ b/portlet-tck_3.0/TestModule3/src/main/resources/xml-resources/tck-TestModule3-tests.xml
@@ -4,5 +4,4 @@
<entry key="TestModule3_PublicRenderParameterTestDifferentPortletApplications">TestModule3_2PortletAppsTest</entry>
<entry key="TestModule3_PublicRenderParameterTestDifferentQName">TestModule3_2PortletAppsTest</entry>
<entry key="TestModule3_PublicRenderParameterTestDifferentIdentifier">TestModule3_2PortletAppsTest</entry>
-<entry key="TestModule3_PublicRenderParameterTestAlias">TestModule3_2PortletAppsTest</entry>
</properties>
\ No newline at end of file
http://git-wip-us.apache.org/repos/asf/portals-pluto/blob/c53495b3/portlet-tck_3.0/common/src/main/java/javax/portlet/tck/beans/TestModule3Definitions.java
----------------------------------------------------------------------
diff --git a/portlet-tck_3.0/common/src/main/java/javax/portlet/tck/beans/TestModule3Definitions.java b/portlet-tck_3.0/common/src/main/java/javax/portlet/tck/beans/TestModule3Definitions.java
index 9156e9a..5ddecfe 100644
--- a/portlet-tck_3.0/common/src/main/java/javax/portlet/tck/beans/TestModule3Definitions.java
+++ b/portlet-tck_3.0/common/src/main/java/javax/portlet/tck/beans/TestModule3Definitions.java
@@ -29,15 +29,12 @@ public class TestModule3Definitions {
public final static String TEST0 = "TestModule3_PublicRenderParameterTestDifferentPortletApplications";
public final static String TEST1 = "TestModule3_PublicRenderParameterTestDifferentQName";
public final static String TEST2 = "TestModule3_PublicRenderParameterTestDifferentIdentifier";
- public final static String TEST3 = "TestModule3_PublicRenderParameterTestAlias";
// PRP identifiers
public final static String TM3PRP0 = "TM3PRP";
public final static String TM3PRP1 = "TM3DifferentQName";
public final static String TM3PRP2 = "TM3DifferentIdentifier";
public final static String TM3PRP2a = "TM3DifferentIdentifier-a";
- public final static String TM3PRP3 = "TM3Alias.1";
- public final static String TM3PRP3a = "TM3Alias.2";
// Test case details
public final static TestCaseDetails tcd = initTests();
@@ -46,7 +43,6 @@ public class TestModule3Definitions {
t.put(TEST0, "A PRP set on the render URL is visible in companion portlet of different portlet application. Same QName & Same identifier.");
t.put(TEST1, "A PRP matching identifier but differing QNames is not visible in companion portlet of different portlet application.");
t.put(TEST2, "A PRP with matching QName but differing identifier is visible in companion portlet of different portlet application.");
- t.put(TEST3, "A PRP with differing QNames & identifier, but with matching alias, is visible in companion portlet of different portlet application.");
return t;
}