Re: [PR] HIVE-27833: Hive Acid Replication Support for Dell Powerscale [hive]

["ayushtkn (via GitHub)" <gi...@apache.org>]

ayushtkn commented on code in PR #4841:
URL: https://github.com/apache/hive/pull/4841#discussion_r1378357966


##########
shims/common/src/main/java/org/apache/hadoop/hive/shims/Utils.java:
##########
@@ -172,6 +173,10 @@ public static boolean checkFileSystemXAttrSupport(FileSystem fs) throws IOExcept
       LOG.warn("XAttr won't be preserved since it is not supported for file system: " + fs.getUri());
       return false;
     }
+    catch (AccessControlException e) {
+      LOG.warn(e.getMessage());
+      return false;
+    }

Review Comment:
   Isn't catching this wrong? Other systems like HDFS throws ACE for permission issues, & here we will be catching them as well?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org