You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cxf.apache.org by Jarek Gawor <jg...@gmail.com> on 2007/02/17 04:10:22 UTC
recent changes
Hi,
In the last few days something has changed in CXF that caused
invocations to stop working in Geronimo. I mean, the service got
invoked ok but the HTTP response from the service was empty. I tracked
relevant changes to the following classes:
http://svn.apache.org/viewvc/incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/handler/soap/
After I switched both classes to their previous revisions the
invocations started to work just like before.
I was wondering if somebody can take a look at it. We are shooting for
a milestone release of Geronimo next week and would be good to have
basic invocations working right.
Thanks,
Jarek
Re: recent changes
Posted by Daniel Kulp <da...@iona.com>.
Jarek,
On Monday 19 February 2007 17:20, Jarek Gawor wrote:
> Ok, finally found a way to replicate the problem. I submitted the test
> case in https://issues.apache.org/jira/browse/CXF-429.
I see what's happening. I'll have a fix for it shortly.
In the Hander, if you do smc.getMessage() someplace, it works fine. The
problem is that if a SOAPHandler doesn't actually use the message, it
doesn't write anything back to the stream. Easy to fix.
Thanks for the patch with the test case. That was great. While
debugging it, I found several other bugs. (@PostConstruct not being
called, resource injection not occuring, etc...) I need to go log them
now. :-(
Dan
> Jarek
>
> On 2/19/07, Jarek Gawor <jg...@gmail.com> wrote:
> > Peter,
> >
> > I tried to write a test case for CXF but so far I was unable to
> > replicate the problem. From what I can tell so far even though I set
> > the following in my *Destination class:
> >
> > message.setContent(OutputStream.class, response.getOutputStream());
> >
> > The stream gets closed but nothing gets written to it. Can I turn on
> > some logging, etc. that would help you to debug this problem?
> >
> > Thanks,
> > Jarek
> >
> > On 2/17/07, Peter Jones <pe...@iona.com> wrote:
> > > Hi Jarek,
> > >
> > > On Fri, Feb 16, 2007 at 10:10:22PM -0500, Jarek Gawor wrote:
> > > > Hi,
> > > >
> > > > In the last few days something has changed in CXF that caused
> > > > invocations to stop working in Geronimo. I mean, the service got
> > > > invoked ok but the HTTP response from the service was empty. I
> > > > tracked relevant changes to the following classes:
> > > >
> > > > http://svn.apache.org/viewvc/incubator/cxf/trunk/rt/frontend/jaxws
> > > >/src/main/java/org/apache/cxf/jaxws/handler/soap/
> > >
> > > This addition in revision 507355 of SOAPMessageContentImpl looks
> > > like it could be a little suspicious to me:
> > >
> > > SoapVersion soapVersion =
> > > ((SoapMessage)getWrappedMessage()).getVersion();
> > >
> > > if (soapVersion == null) {
> > > soapVersion = Soap11.getInstance();
> > > }
> > > soapVersion = ((SoapMessage)getWrappedMessage()).getVersion();
> > > [...]
> > > if (soapVersion.getVersion() == 1.1) {
> > >
> > > but I don't know if that could cause the problem you are seeing. Do
> > > you have a test case you could send in? That would definitely help
> > > us track down what the issue might be more quickly.
> > >
> > > Cheers,
> > > Peter
> > >
> > > > After I switched both classes to their previous revisions the
> > > > invocations started to work just like before.
> > > >
> > > > I was wondering if somebody can take a look at it. We are shooting
> > > > for a milestone release of Geronimo next week and would be good to
> > > > have basic invocations working right.
> > > >
> > > > Thanks,
> > > > Jarek
> > >
> > > --
> > > Peter Jones
> > > IONA Technologies Inc.
> > > E-Mail: mailto:peter.jones@iona.com
> > > Tel: (w) 709-738-3725 x22 | Fax: 709-738-3745
> > > 84-86 Elizabeth Ave. St. John's, NL A1A 1W7 Canada
--
J. Daniel Kulp
Principal Engineer
IONA
P: 781-902-8727 C: 508-380-7194
daniel.kulp@iona.com
http://www.dankulp.com/blog
Re: recent changes
Posted by Jarek Gawor <jg...@gmail.com>.
Dan,
Thanks. I think for Geronimo M3 release we will use CXF version from 6
days ago or so. So this is not critical for this release but would be
nice to have it fixed soon.
Jarek
On 2/20/07, Dan Diephouse <da...@envoisolutions.com> wrote:
> Thanks Jarek. I haven't taken a extensive look at this yet, but if this is
> holding you up on doing other stuff let me know and I can try and get
> something in by tomorrow. Otherwise I will take a look at this later this
> week. Cheers,
> - Dan
>
> On 2/19/07, Jarek Gawor <jg...@gmail.com> wrote:
> >
> > Ok, finally found a way to replicate the problem. I submitted the test
> > case in https://issues.apache.org/jira/browse/CXF-429.
> >
> > Jarek
> >
> > On 2/19/07, Jarek Gawor <jg...@gmail.com> wrote:
> > > Peter,
> > >
> > > I tried to write a test case for CXF but so far I was unable to
> > > replicate the problem. From what I can tell so far even though I set
> > > the following in my *Destination class:
> > >
> > > message.setContent(OutputStream.class, response.getOutputStream());
> > >
> > > The stream gets closed but nothing gets written to it. Can I turn on
> > > some logging, etc. that would help you to debug this problem?
> > >
> > > Thanks,
> > > Jarek
> > >
> > > On 2/17/07, Peter Jones <pe...@iona.com> wrote:
> > > >
> > > > Hi Jarek,
> > > >
> > > > On Fri, Feb 16, 2007 at 10:10:22PM -0500, Jarek Gawor wrote:
> > > > > Hi,
> > > > >
> > > > > In the last few days something has changed in CXF that caused
> > > > > invocations to stop working in Geronimo. I mean, the service got
> > > > > invoked ok but the HTTP response from the service was empty. I
> > tracked
> > > > > relevant changes to the following classes:
> > > > >
> > > > >
> > http://svn.apache.org/viewvc/incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/handler/soap/
> > > >
> > > > This addition in revision 507355 of SOAPMessageContentImpl looks like
> > it
> > > > could be a little suspicious to me:
> > > >
> > > > SoapVersion soapVersion =
> > ((SoapMessage)getWrappedMessage()).getVersion();
> > > >
> > > > if (soapVersion == null) {
> > > > soapVersion = Soap11.getInstance();
> > > > }
> > > > soapVersion = ((SoapMessage)getWrappedMessage()).getVersion();
> > > > [...]
> > > > if (soapVersion.getVersion() == 1.1) {
> > > >
> > > > but I don't know if that could cause the problem you are seeing. Do
> > you
> > > > have a test case you could send in? That would definitely help us
> > track
> > > > down what the issue might be more quickly.
> > > >
> > > > Cheers,
> > > > Peter
> > > >
> > > > > After I switched both classes to their previous revisions the
> > > > > invocations started to work just like before.
> > > > >
> > > > > I was wondering if somebody can take a look at it. We are shooting
> > for
> > > > > a milestone release of Geronimo next week and would be good to have
> > > > > basic invocations working right.
> > > > >
> > > > > Thanks,
> > > > > Jarek
> > > >
> > > > --
> > > > Peter Jones
> > > > IONA Technologies Inc.
> > > > E-Mail: mailto:peter.jones@iona.com
> > > > Tel: (w) 709-738-3725 x22 | Fax: 709-738-3745
> > > > 84-86 Elizabeth Ave. St. John's, NL A1A 1W7 Canada
> > > >
> > >
> >
>
>
>
> --
> Dan Diephouse
> Envoi Solutions
> http://envoisolutions.com | http://netzooid.com/blog
>
Re: recent changes
Posted by Dan Diephouse <da...@envoisolutions.com>.
Thanks Jarek. I haven't taken a extensive look at this yet, but if this is
holding you up on doing other stuff let me know and I can try and get
something in by tomorrow. Otherwise I will take a look at this later this
week. Cheers,
- Dan
On 2/19/07, Jarek Gawor <jg...@gmail.com> wrote:
>
> Ok, finally found a way to replicate the problem. I submitted the test
> case in https://issues.apache.org/jira/browse/CXF-429.
>
> Jarek
>
> On 2/19/07, Jarek Gawor <jg...@gmail.com> wrote:
> > Peter,
> >
> > I tried to write a test case for CXF but so far I was unable to
> > replicate the problem. From what I can tell so far even though I set
> > the following in my *Destination class:
> >
> > message.setContent(OutputStream.class, response.getOutputStream());
> >
> > The stream gets closed but nothing gets written to it. Can I turn on
> > some logging, etc. that would help you to debug this problem?
> >
> > Thanks,
> > Jarek
> >
> > On 2/17/07, Peter Jones <pe...@iona.com> wrote:
> > >
> > > Hi Jarek,
> > >
> > > On Fri, Feb 16, 2007 at 10:10:22PM -0500, Jarek Gawor wrote:
> > > > Hi,
> > > >
> > > > In the last few days something has changed in CXF that caused
> > > > invocations to stop working in Geronimo. I mean, the service got
> > > > invoked ok but the HTTP response from the service was empty. I
> tracked
> > > > relevant changes to the following classes:
> > > >
> > > >
> http://svn.apache.org/viewvc/incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/handler/soap/
> > >
> > > This addition in revision 507355 of SOAPMessageContentImpl looks like
> it
> > > could be a little suspicious to me:
> > >
> > > SoapVersion soapVersion =
> ((SoapMessage)getWrappedMessage()).getVersion();
> > >
> > > if (soapVersion == null) {
> > > soapVersion = Soap11.getInstance();
> > > }
> > > soapVersion = ((SoapMessage)getWrappedMessage()).getVersion();
> > > [...]
> > > if (soapVersion.getVersion() == 1.1) {
> > >
> > > but I don't know if that could cause the problem you are seeing. Do
> you
> > > have a test case you could send in? That would definitely help us
> track
> > > down what the issue might be more quickly.
> > >
> > > Cheers,
> > > Peter
> > >
> > > > After I switched both classes to their previous revisions the
> > > > invocations started to work just like before.
> > > >
> > > > I was wondering if somebody can take a look at it. We are shooting
> for
> > > > a milestone release of Geronimo next week and would be good to have
> > > > basic invocations working right.
> > > >
> > > > Thanks,
> > > > Jarek
> > >
> > > --
> > > Peter Jones
> > > IONA Technologies Inc.
> > > E-Mail: mailto:peter.jones@iona.com
> > > Tel: (w) 709-738-3725 x22 | Fax: 709-738-3745
> > > 84-86 Elizabeth Ave. St. John's, NL A1A 1W7 Canada
> > >
> >
>
--
Dan Diephouse
Envoi Solutions
http://envoisolutions.com | http://netzooid.com/blog
Re: recent changes
Posted by Jarek Gawor <jg...@gmail.com>.
Ok, finally found a way to replicate the problem. I submitted the test
case in https://issues.apache.org/jira/browse/CXF-429.
Jarek
On 2/19/07, Jarek Gawor <jg...@gmail.com> wrote:
> Peter,
>
> I tried to write a test case for CXF but so far I was unable to
> replicate the problem. From what I can tell so far even though I set
> the following in my *Destination class:
>
> message.setContent(OutputStream.class, response.getOutputStream());
>
> The stream gets closed but nothing gets written to it. Can I turn on
> some logging, etc. that would help you to debug this problem?
>
> Thanks,
> Jarek
>
> On 2/17/07, Peter Jones <pe...@iona.com> wrote:
> >
> > Hi Jarek,
> >
> > On Fri, Feb 16, 2007 at 10:10:22PM -0500, Jarek Gawor wrote:
> > > Hi,
> > >
> > > In the last few days something has changed in CXF that caused
> > > invocations to stop working in Geronimo. I mean, the service got
> > > invoked ok but the HTTP response from the service was empty. I tracked
> > > relevant changes to the following classes:
> > >
> > > http://svn.apache.org/viewvc/incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/handler/soap/
> >
> > This addition in revision 507355 of SOAPMessageContentImpl looks like it
> > could be a little suspicious to me:
> >
> > SoapVersion soapVersion = ((SoapMessage)getWrappedMessage()).getVersion();
> >
> > if (soapVersion == null) {
> > soapVersion = Soap11.getInstance();
> > }
> > soapVersion = ((SoapMessage)getWrappedMessage()).getVersion();
> > [...]
> > if (soapVersion.getVersion() == 1.1) {
> >
> > but I don't know if that could cause the problem you are seeing. Do you
> > have a test case you could send in? That would definitely help us track
> > down what the issue might be more quickly.
> >
> > Cheers,
> > Peter
> >
> > > After I switched both classes to their previous revisions the
> > > invocations started to work just like before.
> > >
> > > I was wondering if somebody can take a look at it. We are shooting for
> > > a milestone release of Geronimo next week and would be good to have
> > > basic invocations working right.
> > >
> > > Thanks,
> > > Jarek
> >
> > --
> > Peter Jones
> > IONA Technologies Inc.
> > E-Mail: mailto:peter.jones@iona.com
> > Tel: (w) 709-738-3725 x22 | Fax: 709-738-3745
> > 84-86 Elizabeth Ave. St. John's, NL A1A 1W7 Canada
> >
>
Re: recent changes
Posted by Jarek Gawor <jg...@gmail.com>.
Peter,
I tried to write a test case for CXF but so far I was unable to
replicate the problem. From what I can tell so far even though I set
the following in my *Destination class:
message.setContent(OutputStream.class, response.getOutputStream());
The stream gets closed but nothing gets written to it. Can I turn on
some logging, etc. that would help you to debug this problem?
Thanks,
Jarek
On 2/17/07, Peter Jones <pe...@iona.com> wrote:
>
> Hi Jarek,
>
> On Fri, Feb 16, 2007 at 10:10:22PM -0500, Jarek Gawor wrote:
> > Hi,
> >
> > In the last few days something has changed in CXF that caused
> > invocations to stop working in Geronimo. I mean, the service got
> > invoked ok but the HTTP response from the service was empty. I tracked
> > relevant changes to the following classes:
> >
> > http://svn.apache.org/viewvc/incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/handler/soap/
>
> This addition in revision 507355 of SOAPMessageContentImpl looks like it
> could be a little suspicious to me:
>
> SoapVersion soapVersion = ((SoapMessage)getWrappedMessage()).getVersion();
>
> if (soapVersion == null) {
> soapVersion = Soap11.getInstance();
> }
> soapVersion = ((SoapMessage)getWrappedMessage()).getVersion();
> [...]
> if (soapVersion.getVersion() == 1.1) {
>
> but I don't know if that could cause the problem you are seeing. Do you
> have a test case you could send in? That would definitely help us track
> down what the issue might be more quickly.
>
> Cheers,
> Peter
>
> > After I switched both classes to their previous revisions the
> > invocations started to work just like before.
> >
> > I was wondering if somebody can take a look at it. We are shooting for
> > a milestone release of Geronimo next week and would be good to have
> > basic invocations working right.
> >
> > Thanks,
> > Jarek
>
> --
> Peter Jones
> IONA Technologies Inc.
> E-Mail: mailto:peter.jones@iona.com
> Tel: (w) 709-738-3725 x22 | Fax: 709-738-3745
> 84-86 Elizabeth Ave. St. John's, NL A1A 1W7 Canada
>
Re: recent changes
Posted by Peter Jones <pe...@iona.com>.
Hi Jarek,
On Fri, Feb 16, 2007 at 10:10:22PM -0500, Jarek Gawor wrote:
> Hi,
>
> In the last few days something has changed in CXF that caused
> invocations to stop working in Geronimo. I mean, the service got
> invoked ok but the HTTP response from the service was empty. I tracked
> relevant changes to the following classes:
>
> http://svn.apache.org/viewvc/incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/handler/soap/
This addition in revision 507355 of SOAPMessageContentImpl looks like it
could be a little suspicious to me:
SoapVersion soapVersion = ((SoapMessage)getWrappedMessage()).getVersion();
if (soapVersion == null) {
soapVersion = Soap11.getInstance();
}
soapVersion = ((SoapMessage)getWrappedMessage()).getVersion();
[...]
if (soapVersion.getVersion() == 1.1) {
but I don't know if that could cause the problem you are seeing. Do you
have a test case you could send in? That would definitely help us track
down what the issue might be more quickly.
Cheers,
Peter
> After I switched both classes to their previous revisions the
> invocations started to work just like before.
>
> I was wondering if somebody can take a look at it. We are shooting for
> a milestone release of Geronimo next week and would be good to have
> basic invocations working right.
>
> Thanks,
> Jarek
--
Peter Jones
IONA Technologies Inc.
E-Mail: mailto:peter.jones@iona.com
Tel: (w) 709-738-3725 x22 | Fax: 709-738-3745
84-86 Elizabeth Ave. St. John's, NL A1A 1W7 Canada