You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Min Chen <mi...@citrix.com> on 2013/03/16 00:36:40 UTC
Review Request: CLOUDSTACK-1690: NPE from API server when starting mgmt
server.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9978/
-----------------------------------------------------------
Review request for cloudstack and Chip Childers.
Description
-------
This patch fixed the blocker bug CLOUDSTACK-1690, this bug is caused by recent region commit b41e6e929d5f4f9483c326268a7b36779d23dc38. We also need to remove region_id from sql statement in ConfigurationServerImpl saveUser code to be able to persist "system" and "adimn" account during MS startup.
This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-1690.
Diffs
-----
server/src/com/cloud/server/ConfigurationServerImpl.java 8c665ad
Diff: https://reviews.apache.org/r/9978/diff/
Testing
-------
Tested locally.
Thanks,
Min Chen
Re: Review Request: CLOUDSTACK-1690: NPE from API server when starting mgmt
server.
Posted by Chip Childers <ch...@sungard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9978/#review18027
-----------------------------------------------------------
Ship it!
pushed to 4.1 branch
- Chip Childers
On March 15, 2013, 11:36 p.m., Min Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9978/
> -----------------------------------------------------------
>
> (Updated March 15, 2013, 11:36 p.m.)
>
>
> Review request for cloudstack and Chip Childers.
>
>
> Description
> -------
>
> This patch fixed the blocker bug CLOUDSTACK-1690, this bug is caused by recent region commit b41e6e929d5f4f9483c326268a7b36779d23dc38. We also need to remove region_id from sql statement in ConfigurationServerImpl saveUser code to be able to persist "system" and "adimn" account during MS startup.
>
>
> This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-1690.
>
>
> Diffs
> -----
>
> server/src/com/cloud/server/ConfigurationServerImpl.java 8c665ad
>
> Diff: https://reviews.apache.org/r/9978/diff/
>
>
> Testing
> -------
>
> Tested locally.
>
>
> Thanks,
>
> Min Chen
>
>
Re: Review Request: CLOUDSTACK-1690: NPE from API server when starting mgmt
server.
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9978/#review18026
-----------------------------------------------------------
Commit 6d01ce565d4fe01c215eb6d6d894fa0d5555d6f3 in branch refs/heads/4.1 from Chip Childers <ch...@gmail.com>
[ https://git-wip-us.apache.org/repos/asf?p=incubator-cloudstack.git;h=6d01ce5 ]
CLOUDSTACK-1690: Remove region_id from sql insert statement for inserting "system" and "admin" account and user in MS startup due to recent region feature change.
- ASF Subversion and Git Services
On March 15, 2013, 11:36 p.m., Min Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9978/
> -----------------------------------------------------------
>
> (Updated March 15, 2013, 11:36 p.m.)
>
>
> Review request for cloudstack and Chip Childers.
>
>
> Description
> -------
>
> This patch fixed the blocker bug CLOUDSTACK-1690, this bug is caused by recent region commit b41e6e929d5f4f9483c326268a7b36779d23dc38. We also need to remove region_id from sql statement in ConfigurationServerImpl saveUser code to be able to persist "system" and "adimn" account during MS startup.
>
>
> This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-1690.
>
>
> Diffs
> -----
>
> server/src/com/cloud/server/ConfigurationServerImpl.java 8c665ad
>
> Diff: https://reviews.apache.org/r/9978/diff/
>
>
> Testing
> -------
>
> Tested locally.
>
>
> Thanks,
>
> Min Chen
>
>
Re: Review Request: CLOUDSTACK-1690: NPE from API server when starting mgmt
server.
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9978/#review18056
-----------------------------------------------------------
Commit 2b05f546b7b882e61d54a653a8c5069be22b1be2 in branch refs/heads/master from Min Chen <mi...@citrix.com>
[ https://git-wip-us.apache.org/repos/asf?p=incubator-cloudstack.git;h=2b05f54 ]
CLOUDSTACK-1690: Remove region_id from sql insert statement for inserting "system" and "admin" account and user in MS startup due to recent region feature change.
- ASF Subversion and Git Services
On March 15, 2013, 11:36 p.m., Min Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9978/
> -----------------------------------------------------------
>
> (Updated March 15, 2013, 11:36 p.m.)
>
>
> Review request for cloudstack and Chip Childers.
>
>
> Description
> -------
>
> This patch fixed the blocker bug CLOUDSTACK-1690, this bug is caused by recent region commit b41e6e929d5f4f9483c326268a7b36779d23dc38. We also need to remove region_id from sql statement in ConfigurationServerImpl saveUser code to be able to persist "system" and "adimn" account during MS startup.
>
>
> This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-1690.
>
>
> Diffs
> -----
>
> server/src/com/cloud/server/ConfigurationServerImpl.java 8c665ad
>
> Diff: https://reviews.apache.org/r/9978/diff/
>
>
> Testing
> -------
>
> Tested locally.
>
>
> Thanks,
>
> Min Chen
>
>